-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[No QA] [TS migration] Migrate 'Firebase' lib to TypeScript #27661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
madmax330
merged 4 commits into
Expensify:main
from
kubabutkiewicz:ts-migration/Firebase-lib
Sep 22, 2023
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1a97e94
ref: moved Firebase lib to TS
kubabutkiewicz 51b6f4a
fix: added comment explaining why code is commented
kubabutkiewicz 717c85c
Merge branch 'main' into ts-migration/Firebase-lib
kubabutkiewicz 1e7af0f
Merge branch 'main' into ts-migration/Firebase-lib
kubabutkiewicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import {StartTrace, StopTrace} from './types'; | ||
|
||
/** Web does not use Firebase for performance tracing */ | ||
const startTrace: StartTrace = () => {}; | ||
const stopTrace: StopTrace = () => {}; | ||
|
||
export default { | ||
startTrace, | ||
stopTrace, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import {FirebasePerformanceTypes} from '@react-native-firebase/perf'; | ||
|
||
type Trace = { | ||
trace: FirebasePerformanceTypes.Trace; | ||
start: number; | ||
}; | ||
type TraceMap = Record<string, Trace>; | ||
type StartTrace = (customEventName: string) => void; | ||
type StopTrace = (customEventName: string) => void; | ||
|
||
export type {StartTrace, StopTrace, TraceMap}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.