Use correct app icon colour bg for notifications #27213

Julesssss · 2023-09-12T03:09:38Z

Details

Second attempt at fixing the notification icon background colour.

Fixed Issues

$ #26255

Tests

Android notification icon bg should be #03D47C (ONLY IF SUPPORTED!)

Offline tests

N/A

QA Steps

Android notification icon bg should be #03D47C (ONLY IF SUPPORTED!)

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Julesssss · 2023-09-12T03:13:46Z

Generating a build here

OSBotify · 2023-09-12T04:04:06Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/27213/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/27213/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/27213/NewExpensify.dmg	https://27213.pr-testing.expensify.com

aimane-chnaif

LGTM! Here's comparison:

Samsung Galaxy S10

Light mode:

Dark mode:

Google Pixel 3a

Light mode:

Dark mode:

melvin-bot · 2023-09-12T04:22:53Z

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-09-12T04:35:52Z

@dannymcclain @narefyev91 @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss · 2023-09-12T04:38:37Z

Is our automation smart enough to assign a designer when the linked issue is tagged with design? 😮

aimane-chnaif · 2023-09-12T04:42:36Z

I can do reviewer checklist if needed

Julesssss · 2023-09-12T04:53:44Z

I can do reviewer checklist if needed

Yeah please. @dannymcclain should only be doing the design review here

aimane-chnaif · 2023-09-12T05:01:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

N/A

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

N/A

iOS

N/A

Android

Samsung Galaxy S10

Light mode:

Dark mode:

Google Pixel 3a

Light mode:

Dark mode:

Julesssss · 2023-09-12T05:59:04Z

Ready to go after we get design approval from @dannymcclain

(here's the screenshots)

dannymcclain

Looks much better! Also, if I'm understanding the various threads properly: in light mode, the OS is going override whatever we put in there and make us have a white icon, right? I think in a completely ideal world we would have our light green bg with dark green iconmark (matching the app icon) in all scenarios, but that is basically just not possible. Is that correct?

Li357 · 2023-09-12T15:26:29Z

Are we good to merge this @Julesssss?

aimane-chnaif · 2023-09-12T15:27:20Z

Are we good to merge this @Julesssss?

yes - #27213 (comment)

OSBotify · 2023-09-12T15:34:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Julesssss · 2023-09-13T02:21:38Z

in light mode, the OS is going override whatever we put in there and make us have a white icon, right? I think in a completely ideal world we would have our light green bg with dark green iconmark (matching the app icon) in all scenarios, but that is basically just not possible. Is that correct?

@dannymcclain yeah, annoyingly I believe only occurs on non-vanilla Android devices. And Samsung/OnePlus insist on implementing their own dumb logic that prevents us from having a consistent notification icon colour 😞

OSBotify · 2023-09-13T09:13:59Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.69-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mountiny · 2023-09-14T07:08:43Z

The QA still raised this issue #27145 being reproducible in staging

Julesssss · 2023-09-14T07:15:50Z

The QA still raised this issue #27145 being reproducible in staging

It's impossible that the bug is related to this change in that case, as this simply updated the hex value. The only possible explanation is that the bug that made us revert the original PR wasn't actually linked to this PR after all 😞

Which is actually kinda good news. Samsung not respecting the notification color despite us setting the hex means that we can resubmit the original PR.

aimane-chnaif · 2023-09-14T09:40:53Z

The QA still raised this issue #27145 being reproducible in staging

Curious about this. Can we get screenshot from QA team?

OSBotify · 2023-09-14T10:28:13Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.69-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-14T10:55:16Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-18T10:13:15Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Julesssss self-assigned this Sep 12, 2023

Julesssss added the Ready To Build label Sep 12, 2023

Julesssss mentioned this pull request Sep 12, 2023

[HOLD for payment 2023-09-21] [HOLD for payment 2023-09-18] [$500] Expensify logo vs notification color mismatch #26255

Closed

6 tasks

aimane-chnaif approved these changes Sep 12, 2023

View reviewed changes

melvin-bot bot requested a review from neil-marcellini September 12, 2023 04:22

Julesssss marked this pull request as ready for review September 12, 2023 04:35

Julesssss requested a review from a team as a code owner September 12, 2023 04:35

melvin-bot bot requested review from dannymcclain and narefyev91 and removed request for a team September 12, 2023 04:35

aimane-chnaif approved these changes Sep 12, 2023

View reviewed changes

melvin-bot bot requested a review from Li357 September 12, 2023 05:03

Expensify deleted a comment from melvin-bot bot Sep 12, 2023

use correct app icon colour bg for notifications

597d203

dannymcclain approved these changes Sep 12, 2023

View reviewed changes

Li357 approved these changes Sep 12, 2023

View reviewed changes

Li357 merged commit e25a27f into main Sep 12, 2023

Li357 deleted the jules-updateNoticationIconBg branch September 12, 2023 15:29

OSBotify mentioned this pull request Sep 13, 2023

Deploy Checklist: New Expensify 2023-09-13 #27313

Closed

72 tasks

OSBotify mentioned this pull request Sep 14, 2023

Deploy Checklist: New Expensify 2023-09-14 #27425

Closed

Use correct app icon colour bg for notifications #27213

Use correct app icon colour bg for notifications #27213

Uh oh!

Conversation

Julesssss commented Sep 12, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Julesssss commented Sep 12, 2023

Uh oh!

OSBotify commented Sep 12, 2023

Uh oh!

aimane-chnaif left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Samsung Galaxy S10

Google Pixel 3a

Uh oh!

melvin-bot bot commented Sep 12, 2023

Uh oh!

melvin-bot bot commented Sep 12, 2023

Uh oh!

Julesssss commented Sep 12, 2023

Uh oh!

aimane-chnaif commented Sep 12, 2023

Uh oh!

Julesssss commented Sep 12, 2023

Uh oh!

aimane-chnaif commented Sep 12, 2023

Reviewer Checklist

Screenshots/Videos

Samsung Galaxy S10

Google Pixel 3a

Uh oh!

Julesssss commented Sep 12, 2023

Uh oh!

dannymcclain left a comment

Choose a reason for hiding this comment

Uh oh!

Li357 commented Sep 12, 2023

Uh oh!

aimane-chnaif commented Sep 12, 2023

Uh oh!

OSBotify commented Sep 12, 2023

Uh oh!

Julesssss commented Sep 13, 2023

Uh oh!

OSBotify commented Sep 13, 2023

Uh oh!

mountiny commented Sep 14, 2023

Uh oh!

Julesssss commented Sep 14, 2023

Uh oh!

aimane-chnaif commented Sep 14, 2023

Uh oh!

OSBotify commented Sep 14, 2023

Uh oh!

OSBotify commented Sep 14, 2023

Uh oh!

OSBotify commented Sep 18, 2023

Uh oh!

Uh oh!

aimane-chnaif left a comment •

edited

Loading