Skip to content

[No QA] [TS migration] Migrate 'Permissions.js' lib to TypeScript #26861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 0 additions & 108 deletions src/libs/Permissions.js

This file was deleted.

70 changes: 70 additions & 0 deletions src/libs/Permissions.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
import CONST from '../CONST';
import * as OnyxTypes from '../types/onyx';

function canUseAllBetas(betas: OnyxTypes.Beta[]): boolean {
return betas.includes(CONST.BETAS.ALL);
}

function canUseChronos(betas: OnyxTypes.Beta[]): boolean {
return betas.includes(CONST.BETAS.CHRONOS_IN_CASH) || canUseAllBetas(betas);
}

function canUsePayWithExpensify(betas: OnyxTypes.Beta[]): boolean {
return betas.includes(CONST.BETAS.PAY_WITH_EXPENSIFY) || canUseAllBetas(betas);
}

function canUseDefaultRooms(betas: OnyxTypes.Beta[]): boolean {
return betas.includes(CONST.BETAS.DEFAULT_ROOMS) || canUseAllBetas(betas);
}

/**
* IOU Send feature is temporarily disabled.
*/
function canUseIOUSend(): boolean {
return false;
}

function canUseWallet(betas: OnyxTypes.Beta[]): boolean {
return betas.includes(CONST.BETAS.BETA_EXPENSIFY_WALLET) || canUseAllBetas(betas);
}

function canUseCommentLinking(betas: OnyxTypes.Beta[]): boolean {
return betas.includes(CONST.BETAS.BETA_COMMENT_LINKING) || canUseAllBetas(betas);
}

/**
* We're requiring you to be added to the policy rooms beta on dev,
* since contributors have been reporting a number of false issues related to the feature being under development.
* See https://expensify.slack.com/archives/C01GTK53T8Q/p1641921996319400?thread_ts=1641598356.166900&cid=C01GTK53T8Q
*/
function canUsePolicyRooms(betas: OnyxTypes.Beta[]): boolean {
return betas.includes(CONST.BETAS.POLICY_ROOMS) || canUseAllBetas(betas);
}

function canUseTasks(betas: OnyxTypes.Beta[]): boolean {
return betas.includes(CONST.BETAS.TASKS) || canUseAllBetas(betas);
}

function canUseCustomStatus(betas: OnyxTypes.Beta[]): boolean {
return betas.includes(CONST.BETAS.CUSTOM_STATUS) || canUseAllBetas(betas);
}

/**
* Link previews are temporarily disabled.
*/
function canUseLinkPreviews(): boolean {
return false;
}

export default {
canUseChronos,
canUsePayWithExpensify,
canUseDefaultRooms,
canUseIOUSend,
canUseWallet,
canUseCommentLinking,
canUsePolicyRooms,
canUseTasks,
canUseCustomStatus,
canUseLinkPreviews,
};
9 changes: 0 additions & 9 deletions src/libs/__mocks__/Log.js

This file was deleted.

9 changes: 9 additions & 0 deletions src/libs/__mocks__/Log.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Set up manual mocks for any Logging methods that are supposed hit the 'server',
// this is needed because before, the Logging queue would get flushed while tests were running,
// causing unexpected calls to HttpUtils.xhr() which would cause mock mismatches and flaky tests.
export default {
info: (message: string) => console.debug(`[info] ${message} (mocked)`),
alert: (message: string) => console.debug(`[alert] ${message} (mocked)`),
warn: (message: string) => console.debug(`[warn] ${message} (mocked)`),
hmmm: (message: string) => console.debug(`[hmmm] ${message} (mocked)`),
};
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import _ from 'underscore';
import CONST from '../../CONST';

/**
Expand All @@ -10,8 +9,8 @@ import CONST from '../../CONST';

export default {
...jest.requireActual('../Permissions'),
canUseDefaultRooms: (betas) => _.contains(betas, CONST.BETAS.DEFAULT_ROOMS),
canUsePolicyRooms: (betas) => _.contains(betas, CONST.BETAS.POLICY_ROOMS),
canUseIOUSend: (betas) => _.contains(betas, CONST.BETAS.IOU_SEND),
canUseCustomStatus: (betas) => _.contains(betas, CONST.BETAS.CUSTOM_STATUS),
canUseDefaultRooms: (betas: string[]) => betas.includes(CONST.BETAS.DEFAULT_ROOMS),
canUsePolicyRooms: (betas: string[]) => betas.includes(CONST.BETAS.POLICY_ROOMS),
canUseIOUSend: (betas: string[]) => betas.includes(CONST.BETAS.IOU_SEND),
canUseCustomStatus: (betas: string[]) => betas.includes(CONST.BETAS.CUSTOM_STATUS),
};