-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Upgrade to react-native-web v0.19.9 #24482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 34 commits
f4f44ae
eb51a99
8602d9a
0c94199
033d72b
6290c69
822efb5
465f0a8
93f060c
a3bfc89
a0bdde8
55fd034
6c20ce6
6079901
ee8f268
ad265d3
a549f6d
f1a7649
54c90ce
17679f7
523e561
ecaf413
36b0f07
6718f5e
11a4196
a936fe2
916bff0
2e2727f
8223ae0
f7d6952
61b495c
ecdb04d
76b60b9
3b197e5
514e99f
968a37f
893da76
089cc69
2c2b9f2
ce97f45
32ebb44
b339956
f5709f2
522d7f3
3e2b3f7
a37dbfa
17deb6d
9895179
0b4ee5c
5184706
ff8fd42
02aa981
d7a3667
96151dc
c87e7d1
c61a351
8d61c73
fe84d43
b826fab
11fe5b0
48e7300
129ffd8
696739a
429c368
9756b16
6b39885
14b62f4
e012efb
b2bd893
d956b64
f36fea0
11d05cf
30e6d66
f1ba929
3a5fb84
eead447
9ac00cb
d8a013c
39e9f13
53df22c
e054fb9
cb11d1c
3c32805
e5c37f6
f7a4199
345cc42
19f03df
a688b06
bbea394
7fd9eb7
40d3859
8d3b388
19f45cc
68b64c5
0551c8b
77882fd
03c6036
d5d48e0
879aa68
85bb0bf
ce962a9
d56e451
6382489
8d62f3c
186efbc
9994159
fd50db8
0e02485
502ca80
f49fbf1
4c66c87
4d76788
8c3e3bc
b5929dc
a49db65
0a1033f
3320168
ee36454
d22ed89
2b8f115
e87d35d
03a9fe0
71b5b31
8345471
399309e
e3fc7c5
e6461f1
dab2a9a
e6ae642
641c2a2
f26e9f4
05ad0e8
dbbacb2
01a9cc9
f1586ce
f21576e
873a227
899eaf4
b48a7e1
0aff57e
1f3d2a3
c97ff97
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ const includeModules = [ | |
'react-native-animatable', | ||
'react-native-reanimated', | ||
'react-native-picker-select', | ||
'@expensify/react-native-web', | ||
'react-native-web', | ||
'react-native-webview', | ||
'@react-native-picker', | ||
'react-native-modal', | ||
|
@@ -183,8 +183,8 @@ const webpackConfig = ({envFile = '.env', platform = 'web'}) => ({ | |
resolve: { | ||
alias: { | ||
'react-native-config': 'react-web-config', | ||
'react-native$': '@expensify/react-native-web', | ||
'react-native-web': '@expensify/react-native-web', | ||
'react-native$': 'react-native-web', | ||
'react-native-web': 'react-native-web', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here |
||
'react-content-loader/native': 'react-content-loader', | ||
'lottie-react-native': 'react-native-web-lottie', | ||
}, | ||
|
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -37,16 +37,25 @@ The phone number can be formatted in different ways. | |||||||||||
|
||||||||||||
### Native Keyboards | ||||||||||||
|
||||||||||||
We should always set people up for success on native platforms by enabling the best keyboard for the type of input we’re asking them to provide. See [keyboardType](https://reactnative.dev/docs/0.64/textinput#keyboardtype) in the React Native documentation. | ||||||||||||
We should always set people up for success on native platforms by enabling the best keyboard for the type of input we’re asking them to provide. See [inputMode](https://reactnative.dev/docs/textinput#inputmode) in the React Native documentation. | ||||||||||||
|
||||||||||||
Comment on lines
+56
to
57
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe pin the version of doc to 0.72 like this |
||||||||||||
We have a couple of keyboard types [defined](https://github.com/Expensify/App/blob/572caa9e7cf32a2d64fe0e93d171bb05a1dfb217/src/CONST.js#L357-L360) and should be used like so: | ||||||||||||
We have a list of input modes [defined](https://github.com/Expensify/App/blob/9418b870515102631ea2156b5ea253ee05a98ff1/src/CONST.js#L765-L774) and should be used like so: | ||||||||||||
|
||||||||||||
```jsx | ||||||||||||
<TextInput | ||||||||||||
keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD} | ||||||||||||
inputMode={CONST.INPUT_MODE.NUMERIC} | ||||||||||||
/> | ||||||||||||
``` | ||||||||||||
|
||||||||||||
We also have [keyboardType](https://github.com/Expensify/App/blob/9418b870515102631ea2156b5ea253ee05a98ff1/src/CONST.js#L760-L763) and should be used for specific use cases when there is no `inputMode` equivalent of the value exist. and should be used like so: | ||||||||||||
|
||||||||||||
Comment on lines
+67
to
+68
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||
```jsx | ||||||||||||
<TextInput | ||||||||||||
keyboardType={CONST.KEYBOARD_TYPE.ASCII_CAPABLE} | ||||||||||||
/> | ||||||||||||
``` | ||||||||||||
|
||||||||||||
|
||||||||||||
### Autofill Behavior | ||||||||||||
|
||||||||||||
Forms should autofill information whenever possible i.e. they should work with browsers and password managers auto complete features. | ||||||||||||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant ig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubham1206agra Is there any reason to not update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait
Just remove this line
'react-native-web': 'react-native-web',
Sorry my bad. I thought I selected a single line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aimane-chnaif do we want to remove this? i am not sure i want to remove it without knowing the reason why it was added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree 2nd line is redundant. It's just alias