fix: console errors due to faulty prop type #24185

allroundexperts · 2023-08-06T03:27:05Z

Details

This PR fixes the console errors due to a incorrect prop type added to the Report component. It also adds offline mode styles when creating a task.

Fixed Issues

$ #23200
PROPOSAL: #23200 (comment)

Tests

Turn off network
Create a task task
Verify that the task fields in the opened report are greyed out
Turn on the network and verify that fields are not greyed out
Turn off the network again and verify that fields are not greyed out

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Turn off network
Create a task task
Verify that the task fields in the opened report are greyed out
Turn on the network and verify that fields are not greyed out
Turn off the network again and verify that fields are not greyed out

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-07.at.11.59.09.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-08-06.at.8.14.45.AM.mov

Mobile Web - Safari

Screen.Recording.2023-08-06.at.8.15.42.AM.mov

Desktop

Screen.Recording.2023-08-06.at.8.11.54.AM.mov

iOS

Screen.Recording.2023-08-06.at.8.16.59.AM.mov

Android

Screen.Recording.2023-08-06.at.8.17.37.AM.mov

melvin-bot · 2023-08-06T03:27:11Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr · 2023-08-07T14:59:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

24185.Web.mov

Mobile Web - Chrome

Screen_Recording_20230807_222549_Chrome.mp4

Mobile Web - Safari

24185.mWeb.Safari.mp4

Desktop

24185.Desktop.mov

iOS

24185.iOS.mp4

Android

Screen_Recording_20230807_222259_New.Expensify.mp4

mollfpr

LGTM 👍

neil-marcellini

Looks great, one suggestion.

neil-marcellini · 2023-08-07T18:45:48Z

src/libs/actions/Task.js

+                    ...(title && {reportName: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD}),
+                    ...(description && {description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD}),
+                    ...(assigneeAccountID && {managerID: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD}),


I think we should set these all pending on creation. For example in the test videos the assignee field isn't grayed out because it was unset, but I think the whole task should show as grayed out because the entire thing is pending creation.

Makes sense. I'll change this and will let you know.

neil-marcellini · 2023-08-07T18:46:23Z

As usual please DM me on NewDot when it's updated.

neil-marcellini

Good to go!

OSBotify · 2023-08-07T19:09:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-09T09:11:59Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:50:42Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-10T20:09:08Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allroundexperts added 2 commits August 6, 2023 06:53

fix: broken prop types

e21c4b5

feat: add offline mode for new tasks

b0c5773

allroundexperts requested a review from a team as a code owner August 6, 2023 03:27

melvin-bot bot requested review from mollfpr and removed request for a team August 6, 2023 03:27

allroundexperts mentioned this pull request Aug 6, 2023

[HOLD for payment 2023-08-17] [$1000] Update Task title/description/assignee when offline is not grey out #23200

Closed

6 tasks

mollfpr approved these changes Aug 7, 2023

View reviewed changes

melvin-bot bot requested a review from neil-marcellini August 7, 2023 15:51

neil-marcellini requested changes Aug 7, 2023

View reviewed changes

fix: add all task fields as pending

6a3a1d9

allroundexperts requested a review from neil-marcellini August 7, 2023 19:01

neil-marcellini approved these changes Aug 7, 2023

View reviewed changes

neil-marcellini merged commit 4700f96 into Expensify:main Aug 7, 2023

OSBotify mentioned this pull request Aug 9, 2023

Deploy Checklist: New Expensify 2023-08-09 #24307

Closed

87 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: console errors due to faulty prop type #24185

fix: console errors due to faulty prop type #24185

Uh oh!

allroundexperts commented Aug 6, 2023 •

edited

Loading

Uh oh!

melvin-bot bot commented Aug 6, 2023

Uh oh!

mollfpr commented Aug 7, 2023 •

edited

Loading

Uh oh!

mollfpr left a comment

Uh oh!

neil-marcellini left a comment

Uh oh!

neil-marcellini Aug 7, 2023

Uh oh!

allroundexperts Aug 7, 2023

Uh oh!

neil-marcellini commented Aug 7, 2023

Uh oh!

neil-marcellini left a comment

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 10, 2023

Uh oh!

Uh oh!

fix: console errors due to faulty prop type #24185

fix: console errors due to faulty prop type #24185

Uh oh!

Conversation

allroundexperts commented Aug 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 6, 2023

Uh oh!

mollfpr commented Aug 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Aug 7, 2023

Choose a reason for hiding this comment

Uh oh!

allroundexperts Aug 7, 2023

Choose a reason for hiding this comment

Uh oh!

neil-marcellini commented Aug 7, 2023

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 10, 2023

Uh oh!

Uh oh!

allroundexperts commented Aug 6, 2023 •

edited

Loading

mollfpr commented Aug 7, 2023 •

edited

Loading