-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[No QA] Background refresh for Android #24128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b38d73b
add background refresh for android
arosiclair a73c535
use new lastUpdateID to do a quick reconnect
arosiclair 7028add
call confirmReadyToOpenApp to allow reconnectApp to run
arosiclair 02c6981
clearer comment
arosiclair e5fab7d
Merge branch 'main' of github.com:Expensify/App into arosiclair-andro…
arosiclair File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
src/libs/Notification/PushNotification/backgroundRefresh/index.android.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import Onyx from 'react-native-onyx'; | ||
import * as App from '../../../actions/App'; | ||
import Visibility from '../../../Visibility'; | ||
import ONYXKEYS from '../../../../ONYXKEYS'; | ||
|
||
function getLastOnyxUpdateID() { | ||
Julesssss marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return new Promise((resolve) => { | ||
const connectionID = Onyx.connect({ | ||
key: ONYXKEYS.ONYX_UPDATES.LAST_UPDATE_ID, | ||
callback: (lastUpdateID) => { | ||
Onyx.disconnect(connectionID); | ||
resolve(lastUpdateID); | ||
}, | ||
}); | ||
}); | ||
} | ||
|
||
/** | ||
* Runs our reconnectApp action if the app is in the background. | ||
* | ||
* We use this to refresh the app in the background after receiving a push notification (native only). Since the full app | ||
* wakes on iOS and by extension runs reconnectApp already, this is a no-op on everything but Android. | ||
*/ | ||
export default function backgroundRefresh() { | ||
if (Visibility.isVisible()) { | ||
return; | ||
} | ||
|
||
getLastOnyxUpdateID().then((lastUpdateID) => { | ||
/** | ||
* ReconnectApp waits on the isReadyToOpenApp promise to resolve and this normally only resolves when the LHN is rendered. | ||
* However on Android, this callback is run in the background using a Headless JS task which does not render the React UI, | ||
* so we must manually run confirmReadyToOpenApp here instead. | ||
* | ||
* See more here: https://reactnative.dev/docs/headless-js-android | ||
*/ | ||
App.confirmReadyToOpenApp(); | ||
App.reconnectApp(lastUpdateID); | ||
}); | ||
} |
7 changes: 7 additions & 0 deletions
7
src/libs/Notification/PushNotification/backgroundRefresh/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
/** | ||
* Runs our reconnectApp action if the app is in the background. | ||
* | ||
* We use this to refresh the app in the background after receiving a push notification (native only). Since the full app | ||
* wakes on iOS and by extension runs reconnectApp already, this is a no-op on everything but Android. | ||
*/ | ||
export default function backgroundRefresh() {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes console error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#24128 (comment) will be fixed in #24174