subtitle added for share destination #23159

chiragxarora · 2023-07-19T10:41:26Z

Details

In new task page, share destination doesn't have subtitle text for 1 to 1 DM and group chat

Fixed Issues

$ #22296
PROPOSAL: #22296 (comment)

Tests

open the app
click fab > assign task
enter title and description
select an assignee
select share destination and verify that subtitle text is showing for 1:1 DMs

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

open the app
click fab > assign task
enter title and description
select an assignee
select share destination and verify that subtitle text is showing for 1:1 DMs

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-19.at.3.27.28.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-07-19.at.3.43.27.PM.mov

Mobile Web - Safari

Screen.Recording.2023-07-19.at.3.48.41.PM.mov

Desktop

Screen.Recording.2023-07-19.at.3.50.28.PM.mov

iOS

Screen.Recording.2023-07-19.at.3.47.29.PM.mov

Android

Screen.Recording.2023-07-19.at.3.41.03.PM.mov

melvin-bot · 2023-07-19T10:41:30Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/Task.js

Co-authored-by: Eugene Voloshchak <[email protected]>

src/libs/actions/Task.js

src/libs/ReportUtils.js

src/libs/actions/Task.js

eVoloshchak · 2023-07-20T18:52:18Z

@chiragxarora, tests are failing

chiragxarora · 2023-07-20T19:44:59Z

can you check now @eVoloshchak ?

eVoloshchak · 2023-07-20T22:56:20Z

@chiragxarora, tests are good, now there are conflicts😅

chiragxarora · 2023-07-21T13:13:24Z

@eVoloshchak 😅

eVoloshchak · 2023-07-21T13:31:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-21.at.17.52.46.mov

Mobile Web - Chrome

screen-20230721-193021.mp4

Mobile Web - Safari

Screen.Recording.2023-07-21.at.19.27.19.mov

Desktop

Screen.Recording.2023-07-21.at.19.31.41.mov

iOS

Screen.Recording.2023-07-21.at.19.26.38.mov

Android

screen-20230721-192931.mp4

eVoloshchak · 2023-07-21T13:32:54Z

@chiragxarora, why is this needed?

chiragxarora · 2023-07-21T13:36:02Z

Because this function is working on different participants array fetched via lodash rather than getting them from report itself

eVoloshchak · 2023-07-21T15:25:38Z

@chiragxarora, are you experiencing this bug? I can't select a share destination. This wasn't caused by this PR and is present on main

screen-20230721-182435.mp4

chiragxarora · 2023-07-21T15:42:44Z

yes, this is present from quite some time, in my experience, I fail to share tasks with old contacts or those who I haven't communicated with recently.
Not related to my PR @eVoloshchak

main branch

Screen.Recording.2023-07-21.at.9.08.14.PM.mov

my branch

Screen.Recording.2023-07-21.at.9.05.23.PM.mov

eVoloshchak

LGTM

chiragxarora · 2023-07-21T18:11:40Z

@bondydaa could you pls review the PR?

OSBotify · 2023-07-24T15:08:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-25T01:43:24Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-26T15:52:55Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

subtitle added for share destination

b5c2edb

chiragxarora requested a review from a team as a code owner July 19, 2023 10:41

melvin-bot bot removed the request for review from a team July 19, 2023 10:41

melvin-bot bot requested a review from eVoloshchak July 19, 2023 10:41

chiragxarora mentioned this pull request Jul 19, 2023

[HOLD for payment 2023-08-02] [$1000] Web - In new task page, share destination doesn't have subtitle text for 1 to 1 DM and group chat #22296

Closed

6 tasks

chiragxarora and others added 2 commits July 19, 2023 16:20

ran prettier

7077765

Merge branch 'main' into fix/22296

fbbf055

eVoloshchak reviewed Jul 20, 2023

View reviewed changes

src/libs/actions/Task.js Outdated Show resolved Hide resolved

for better code practice

cfc2ea9

Co-authored-by: Eugene Voloshchak <[email protected]>

eVoloshchak reviewed Jul 20, 2023

View reviewed changes

src/libs/actions/Task.js Outdated Show resolved Hide resolved

chiragxarora and others added 3 commits July 20, 2023 23:35

Merge branch 'Expensify:main' into fix/22296

ea11b2d

hasSingleParticipant method added to report util

fd9e2f8

using hasSingleParticipant in other places

dd1416f

eVoloshchak suggested changes Jul 20, 2023

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

src/libs/actions/Task.js Outdated Show resolved Hide resolved

chiragxarora added 2 commits July 21, 2023 00:10

safety check

be1189d

few more modifications

a5389a8

fixed getMoneyRequestOptions

d4aa0fb

chiragxarora requested a review from eVoloshchak July 20, 2023 19:08

Merge branch 'main' into fix/22296

2ee9f21

eVoloshchak approved these changes Jul 21, 2023

View reviewed changes

melvin-bot bot requested a review from bondydaa July 21, 2023 16:36

bondydaa approved these changes Jul 24, 2023

View reviewed changes

bondydaa merged commit 13b7df9 into Expensify:main Jul 24, 2023

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

subtitle added for share destination #23159

subtitle added for share destination #23159

Uh oh!

Conversation

chiragxarora commented Jul 19, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 19, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eVoloshchak commented Jul 20, 2023

Uh oh!

chiragxarora commented Jul 20, 2023

Uh oh!

eVoloshchak commented Jul 20, 2023

Uh oh!

chiragxarora commented Jul 21, 2023

Uh oh!

eVoloshchak commented Jul 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented Jul 21, 2023

Uh oh!

chiragxarora commented Jul 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eVoloshchak commented Jul 21, 2023

Uh oh!

chiragxarora commented Jul 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

chiragxarora commented Jul 21, 2023

Uh oh!

OSBotify commented Jul 24, 2023

Uh oh!

OSBotify commented Jul 25, 2023

Uh oh!

OSBotify commented Jul 26, 2023

Uh oh!

Uh oh!

eVoloshchak commented Jul 21, 2023 •

edited

Loading

chiragxarora commented Jul 21, 2023 •

edited

Loading

chiragxarora commented Jul 21, 2023 •

edited

Loading