Skip to content

🍒 Cherry pick PR #22662 to staging 🍒 #22722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,13 @@ android {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
multiDexEnabled rootProject.ext.multiDexEnabled
<<<<<<< HEAD
versionCode 1001033907
versionName "1.3.39-7"
=======
versionCode 1001033905
versionName "1.3.39-5"
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
}

splits {
Expand Down
4 changes: 4 additions & 0 deletions ios/NewExpensify/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@
</dict>
</array>
<key>CFBundleVersion</key>
<<<<<<< HEAD
<string>1.3.39.7</string>
=======
<string>1.3.39.5</string>
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
<key>LSApplicationQueriesSchemes</key>
Expand Down
4 changes: 4 additions & 0 deletions ios/NewExpensifyTests/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<<<<<<< HEAD
<string>1.3.39.7</string>
=======
<string>1.3.39.5</string>
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
</dict>
</plist>
8 changes: 8 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"name": "new.expensify",
<<<<<<< HEAD
"version": "1.3.39-7",
=======
"version": "1.3.39-5",
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
"author": "Expensify, Inc.",
"homepage": "https://new.expensify.com",
"description": "New Expensify is the next generation of Expensify: a reimagination of payments based atop a foundation of chat.",
Expand Down
4 changes: 4 additions & 0 deletions src/components/ReportActionItem/ReportPreview.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,11 @@ function ReportPreview(props) {
accessibilityRole="button"
accessibilityLabel={props.translate('iou.viewDetails')}
>
<<<<<<< HEAD
<View style={styles.iouPreviewBox}>
=======
<View style={[styles.iouPreviewBox, props.isHovered ? styles.iouPreviewBoxHover : undefined]}>
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
<View style={styles.flexRow}>
<View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}>
<Text style={[styles.textLabelSupporting, styles.mb1, styles.lh16]}>
Expand Down
4 changes: 4 additions & 0 deletions src/components/UserDetailsTooltip/index.web.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,11 @@ function UserDetailsTooltip(props) {
/>
</View>
<Text style={[styles.mt2, styles.textMicroBold, styles.textReactionSenders, styles.textAlignCenter]}>{title}</Text>
<<<<<<< HEAD
<Text style={[styles.textMicro, styles.fontColorReactionLabel]}>{subtitle}</Text>
=======
<Text style={[styles.textMicro, styles.fontColorReactionLabel, styles.breakWord, styles.textAlignCenter]}>{subtitle}</Text>
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
</View>
),
[props.icon, userAvatar, userAccountID, userLogin, title, subtitle],
Expand Down
12 changes: 12 additions & 0 deletions src/languages/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,11 @@ export default {
},
twoFactorAuthForm: {
error: {
<<<<<<< HEAD
pleaseFillTwoFactorAuth: 'Please enter your two-factor code',
=======
pleaseFillTwoFactorAuth: 'Please enter your two-factor authentication code',
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
incorrect2fa: 'Incorrect two-factor authentication code. Please try again.',
},
},
Expand Down Expand Up @@ -712,7 +716,11 @@ export default {
error: {
pleaseFillMagicCode: 'Please enter your magic code',
incorrectMagicCode: 'Incorrect magic code.',
<<<<<<< HEAD
pleaseFillTwoFactorAuth: 'Please enter your two-factor code',
=======
pleaseFillTwoFactorAuth: 'Please enter your two-factor authentication code',
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
},
},
passwordForm: {
Expand Down Expand Up @@ -1294,6 +1302,10 @@ export default {
completed: 'completed task',
canceled: 'canceled task',
reopened: 'reopened task',
<<<<<<< HEAD
=======
error: 'You do not have the permission to do the requested action.',
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
},
markAsDone: 'Mark as done',
markAsIncomplete: 'Mark as incomplete',
Expand Down
13 changes: 13 additions & 0 deletions src/languages/es.js
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,11 @@ export default {
},
twoFactorAuthForm: {
error: {
<<<<<<< HEAD
pleaseFillTwoFactorAuth: 'Por favor, introduce tu código 2 factores',
=======
pleaseFillTwoFactorAuth: 'Por favor, introduce tu código de autenticación de dos factores',
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
incorrect2fa: 'Código de autenticación de dos factores incorrecto. Por favor, inténtalo de nuevo',
},
},
Expand Down Expand Up @@ -714,7 +718,11 @@ export default {
error: {
pleaseFillMagicCode: 'Por favor, introduce el código mágico',
incorrectMagicCode: 'Código mágico incorrecto.',
<<<<<<< HEAD
pleaseFillTwoFactorAuth: 'Por favor, introduce tu código 2 factores',
=======
pleaseFillTwoFactorAuth: 'Por favor, introduce tu código de autenticación de dos factores',
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
},
},
passwordForm: {
Expand Down Expand Up @@ -1302,7 +1310,12 @@ export default {
messages: {
completed: 'tarea completada',
canceled: 'tarea cancelada',
<<<<<<< HEAD
reopened: 'tarea reabierta',
=======
reopened: 'tarea reabrir',
error: 'No tiene permiso para realizar la acción solicitada.',
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
},
markAsDone: 'Marcar como completada',
markAsIncomplete: 'Marcar como incompleta',
Expand Down
8 changes: 8 additions & 0 deletions src/libs/EmojiUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ Onyx.connect({
frequentlyUsedEmojis = _.map(val, (item) => {
const emoji = Emojis.emojiCodeTable[item.code];
if (emoji) {
<<<<<<< HEAD
return {name: emoji.name, code: emoji.code, count: item.count, lastUpdatedAt: item.lastUpdatedAt};
=======
return {...emoji, count: item.count, lastUpdatedAt: item.lastUpdatedAt};
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
}
});
},
Expand Down Expand Up @@ -228,8 +232,12 @@ function getFrequentlyUsedEmojis(newEmoji) {
frequentEmojiList.splice(emojiIndex, 1);
}

<<<<<<< HEAD
const {name, code} = Emojis.emojiCodeTable[emoji.code];
const updatedEmoji = {name, code, count: currentEmojiCount, lastUpdatedAt: currentTimestamp};
=======
const updatedEmoji = {...Emojis.emojiCodeTable[emoji.code], count: currentEmojiCount, lastUpdatedAt: currentTimestamp};
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)

// We want to make sure the current emoji is added to the list
// Hence, we take one less than the current frequent used emojis
Expand Down
30 changes: 30 additions & 0 deletions src/libs/ReportUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -1081,10 +1081,17 @@ function getTransactionReportName(reportAction) {
* Get money request message for an IOU report
*
* @param {Object} report
<<<<<<< HEAD
* @param {Object} reportAction
* @returns {String}
*/
function getReportPreviewMessage(report, reportAction) {
=======
* @param {Object} [reportAction={}]
* @returns {String}
*/
function getReportPreviewMessage(report, reportAction = {}) {
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
const reportActionMessage = lodashGet(reportAction, 'message[0].html', '');

if (_.isEmpty(report) || !report.reportID) {
Expand Down Expand Up @@ -1561,6 +1568,7 @@ function buildOptimisticIOUReportAction(type, amount, currency, comment, partici
};
}

<<<<<<< HEAD
function buildOptimisticReportPreview(reportID, iouReportID, payeeAccountID) {
return {
reportActionID: NumberUtils.rand64(),
Expand All @@ -1573,14 +1581,36 @@ function buildOptimisticReportPreview(reportID, iouReportID, payeeAccountID) {
{
html: '',
text: '',
=======
function buildOptimisticReportPreview(chatReport, iouReport) {
const message = getReportPreviewMessage(iouReport);
return {
reportActionID: NumberUtils.rand64(),
reportID: chatReport.reportID,
actionName: CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW,
pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
originalMessage: {
linkedReportID: iouReport.reportID,
},
message: [
{
html: message,
text: message,
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
isEdited: false,
type: CONST.REPORT.MESSAGE.TYPE.COMMENT,
},
],
<<<<<<< HEAD
originalMessage: {
linkedReportID: iouReportID,
},
actorAccountID: currentUserAccountID,
=======
created: DateUtils.getDBTime(),
accountID: iouReport.managerID || 0,
actorAccountID: iouReport.managerID || 0,
>>>>>>> 1a4190b (Merge pull request #22662 from Expensify/stites-fixFrequentlyUsedEmojis)
};
}

Expand Down
Loading