Skip to content

Fix HTML rendering issues #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2020
Merged

Fix HTML rendering issues #203

merged 1 commit into from
Aug 16, 2020

Conversation

AndrewGable
Copy link
Contributor

Closes #188

1 2
Screen Shot 2020-08-15 at 6 09 06 PM Screen Shot 2020-08-15 at 6 08 50 PM

@AndrewGable AndrewGable self-assigned this Aug 16, 2020
@AndrewGable
Copy link
Contributor Author

Note - Still WIP, need to address some iOS issues as well.

tgolen
tgolen approved these changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@tgolen tgolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! I'm going to merge now for the testing, but would you mind doing a followup PR for the lint errors?

@tgolen tgolen changed the title [WIP] Fix HTML rendering issues Fix HTML rendering issues Aug 16, 2020
@tgolen tgolen merged commit 5b0f959 into master Aug 16, 2020
@tgolen tgolen deleted the andrew-fix-html branch August 16, 2020 02:03
@AndrewGable AndrewGable mentioned this pull request Aug 16, 2020
Merged
mountiny pushed a commit that referenced this pull request Feb 12, 2025
@adamgrzybowski
Merge pull request #203 from software-mansion-labs/splits/review-fixe…
7a94577 
…s-v3

Splits/review fixes v3
@github-actions github-actions bot mentioned this pull request Feb 12, 2025
Closed
57 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.98-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.98-8 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgolen tgolen tgolen approved these changes

Assignees

@AndrewGable AndrewGable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Known issues with HTML on iOS/Android
2 participants
@AndrewGable @tgolen