Optimistically generate transactions in existing IOU flows

jest/setup.js

@@ -11,7 +11,7 @@ jest.mock('react-native/Libraries/Animated/NativeAnimatedHelper');
 
 // We have to mock the SQLiteStorage provider because it uses the native module SQLiteStorage, which is not available in jest.
 // Mocking this file in __mocks__ does not work because jest doesn't support mocking files that are not directly used in the testing project
-jest.mock('react-native-onyx/lib/storage/providers/SQLiteStorage', () => require('react-native-onyx/lib/storage/providers/__mocks__/SQLiteStorage'));
+jest.mock('react-native-onyx/lib/storage', () => require('react-native-onyx/lib/storage/__mocks__'));
 
 // Turn off the console logs for timing events. They are not relevant for unit tests and create a lot of noise
 jest.spyOn(console, 'debug').mockImplementation((...params) => {

package.json

@@ -108,7 +108,7 @@
     "react-native-key-command": "^1.0.0",
     "react-native-localize": "^2.2.6",
     "react-native-modal": "^13.0.0",
-    "react-native-onyx": "1.0.39",
+    "react-native-onyx": "1.0.41",
     "react-native-pdf": "^6.6.2",
     "react-native-performance": "^4.0.0",
     "react-native-permissions": "^3.0.1",

src/libs/ReportUtils.js

@@ -1073,15 +1073,14 @@ function getIOUReportActionMessage(type, total, participants, comment, currency,
  * @param {String} currency
  * @param {String} comment - User comment for the IOU.
  * @param {Array}  participants - An array with participants details.
+ * @param {String} iouTransactionID - Only required if the IOUReportAction type is oneOf(cancel, decline). Generates a randomID as default.
+ *
  * @param {String} [paymentType] - Only required if the IOUReportAction type is 'pay'. Can be oneOf(elsewhere, payPal, Expensify).
- * @param {String} [iouTransactionID] - Only required if the IOUReportAction type is oneOf(cancel, decline). Generates a randomID as default.
  * @param {String} [iouReportID] - Only required if the IOUReportActions type is oneOf(decline, cancel, pay). Generates a randomID as default.
  * @param {Boolean} [isSettlingUp] - Whether we are settling up an IOU.
- *
  * @returns {Object}
  */
-function buildOptimisticIOUReportAction(type, amount, currency, comment, participants, paymentType = '', iouTransactionID = '', iouReportID = '', isSettlingUp = false) {
-    const IOUTransactionID = iouTransactionID || NumberUtils.rand64();
+function buildOptimisticIOUReportAction(type, amount, currency, comment, participants, iouTransactionID, paymentType = '', iouReportID = '', isSettlingUp = false) {
     const IOUReportID = iouReportID || generateReportID();
     const parser = new ExpensiMark();
     const commentText = getParsedComment(comment);
@@ -1091,7 +1090,7 @@ function buildOptimisticIOUReportAction(type, amount, currency, comment, partici
         amount,
         comment: textForNewComment,
         currency,
-        IOUTransactionID,
+        IOUTransactionID: iouTransactionID,
         IOUReportID,
         type,
     };

src/libs/TransactionUtils.js

@@ -0,0 +1,28 @@
+import CONST from '../CONST';
+import DateUtils from './DateUtils';
+import * as NumberUtils from './NumberUtils';
+
+/**
+ * Optimistically generate a transaction.
+ *
+ * @param {Number} amount – in cents
+ * @param {String} currency
+ * @param {String} comment
+ * @returns {Object}
+ */
+function buildOptimisticTransaction(amount, currency, comment = '') {
+    // transactionIDs are random, positive, 64-bit numbers.
+    // Because JS can only handle 53-bit numbers, transactionIDs are strings in the front-end (just like reportActionID)
+    const transactionID = NumberUtils.rand64();
+    return {
+        transactionID,
+        amount,
+        comment,
+        created: DateUtils.getDBTime(),
+        pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
+    };
+}
+
+export default {
+    buildOptimisticTransaction,
+};