Skip to content

Detailed list of reaction senders when long-/right-pressing a reaction #15685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
f6279ea
ReactionList
perunt Mar 6, 2023
bc5a517
update styles
perunt Mar 7, 2023
5732ada
add isLongPressEnabledWithHover to PressableWithSecondaryInteraction
perunt Mar 7, 2023
72d53e9
reactionCount
perunt Mar 7, 2023
0280636
typo
perunt Mar 7, 2023
82b02be
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
perunt Mar 8, 2023
156d6ef
Merge branch 'hanno/feat-tolltip-reaction-senders' of https://github.…
perunt Mar 10, 2023
c66388b
import getPersonalDetailsByIDs
perunt Mar 10, 2023
0317bd7
take hasUserReacted from Report
perunt Mar 10, 2023
e36ba93
Resolving a merge conflict
perunt Mar 10, 2023
b16febf
Merge branch 'hanno/feat-tolltip-reaction-senders' of https://github.…
perunt Mar 13, 2023
fbc69cf
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
perunt Mar 15, 2023
502920e
remove container
perunt Mar 16, 2023
5bc555d
Merge branch 'main' of https://github.com/Expensify/App into perunt/r…
perunt Mar 16, 2023
6bc54ce
update propTypes
perunt Mar 20, 2023
e96d82b
changes after the review
perunt Mar 20, 2023
acf6f2e
Merge branch 'main' of https://github.com/Expensify/App into perunt/r…
perunt Mar 20, 2023
838585d
Merge branch 'main' of https://github.com/Expensify/App into perunt/r…
perunt Mar 23, 2023
01848c6
Merge branch 'perunt/reaction-list-on-secondary-interaction' of https…
perunt Mar 23, 2023
5523614
Merge branch 'main' of https://github.com/Expensify/App into perunt/r…
perunt Mar 24, 2023
e528087
remove unnecessary check for instance ID
perunt Mar 24, 2023
b91f52c
remove space
perunt Mar 24, 2023
96d05f6
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
perunt Mar 27, 2023
524546b
removed unused eslint rules which appeared after merge
perunt Mar 27, 2023
b4343a8
add onyx eslint rules
perunt Mar 27, 2023
d129b8c
Merge branch 'main' of https://github.com/Expensify/App into perunt/r…
perunt Mar 30, 2023
6ebe8ac
update keyExtractor key
perunt Mar 30, 2023
308f673
remove mobile HeaderReactionList
perunt Mar 30, 2023
38db154
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
perunt Apr 6, 2023
b2a1c65
style
perunt Apr 6, 2023
4ffd2ff
Improvements following review
perunt Apr 13, 2023
6df949e
Merge branch 'main' of https://github.com/Expensify/App into perunt/r…
perunt Apr 13, 2023
907fd16
removed sizeScale
perunt Apr 13, 2023
a09ad6b
revert, rename enableLongPressWithHover
perunt Apr 28, 2023
cb14807
clean
perunt Apr 28, 2023
5dada1a
Merge branch 'main' of https://github.com/Expensify/App into perunt/r…
perunt Apr 28, 2023
a989192
popoverWidth
perunt Apr 28, 2023
3604015
disable touch response for item list
perunt May 1, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/pages/home/report/ReactionList/BaseReactionList.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ const renderItem = ({item}) => (
<OptionRow
item={item}
boldStyle
isDisabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also makes the text on the item unselectable. Is it fine? @Julesssss and others.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot. I think that's okay given that there are other ways for web/Desktop users to copy this text.

style={{maxWidth: variables.mobileResponsiveWidthBreakpoint}}
option={{
text: Str.removeSMSDomain(item.displayName),
Expand Down