-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Detailed list of reaction senders when long-/right-pressing a reaction #15685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cristipaval
merged 38 commits into
Expensify:main
from
margelo:perunt/reaction-list-on-secondary-interaction
May 4, 2023
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
f6279ea
ReactionList
perunt bc5a517
update styles
perunt 5732ada
add isLongPressEnabledWithHover to PressableWithSecondaryInteraction
perunt 72d53e9
reactionCount
perunt 0280636
typo
perunt 82b02be
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
perunt 156d6ef
Merge branch 'hanno/feat-tolltip-reaction-senders' of https://github.…
perunt c66388b
import getPersonalDetailsByIDs
perunt 0317bd7
take hasUserReacted from Report
perunt e36ba93
Resolving a merge conflict
perunt b16febf
Merge branch 'hanno/feat-tolltip-reaction-senders' of https://github.…
perunt fbc69cf
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
perunt 502920e
remove container
perunt 5bc555d
Merge branch 'main' of https://github.com/Expensify/App into perunt/r…
perunt 6bc54ce
update propTypes
perunt e96d82b
changes after the review
perunt acf6f2e
Merge branch 'main' of https://github.com/Expensify/App into perunt/r…
perunt 838585d
Merge branch 'main' of https://github.com/Expensify/App into perunt/r…
perunt 01848c6
Merge branch 'perunt/reaction-list-on-secondary-interaction' of https…
perunt 5523614
Merge branch 'main' of https://github.com/Expensify/App into perunt/r…
perunt e528087
remove unnecessary check for instance ID
perunt b91f52c
remove space
perunt 96d05f6
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
perunt 524546b
removed unused eslint rules which appeared after merge
perunt b4343a8
add onyx eslint rules
perunt d129b8c
Merge branch 'main' of https://github.com/Expensify/App into perunt/r…
perunt 6ebe8ac
update keyExtractor key
perunt 308f673
remove mobile HeaderReactionList
perunt 38db154
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
perunt b2a1c65
style
perunt 4ffd2ff
Improvements following review
perunt 6df949e
Merge branch 'main' of https://github.com/Expensify/App into perunt/r…
perunt 907fd16
removed sizeScale
perunt a09ad6b
revert, rename enableLongPressWithHover
perunt cb14807
clean
perunt 5dada1a
Merge branch 'main' of https://github.com/Expensify/App into perunt/r…
perunt a989192
popoverWidth
perunt 3604015
disable touch response for item list
perunt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also makes the text on the item unselectable. Is it fine? @Julesssss and others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot. I think that's okay given that there are other ways for web/Desktop users to copy this text.