-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Scroll To Last Index After Layout Change Of List #15662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
722d2e8
added layoutChange on report scroll manager and calling it from layou…
Litande 7715aba
Updated comment on lastIndex reference
Litande ec95e93
Update index.native.js
Litande ffebdb0
Update ReportActionsList.js
Litande 1bf4564
review updates
Litande 20687e5
missing export
Litande 1f309ff
Update src/libs/ReportScrollManager/index.native.js
Litande b1ce92c
Update src/libs/ReportScrollManager/index.js
Litande 0778282
Update src/libs/ReportScrollManager/index.js
Litande c278d6e
split native-ios
Litande File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
import React from 'react'; | ||
|
||
// This ref is created using React.createRef here because this function is used by a component that doesn't have access | ||
// to the original ref. | ||
const flatListRef = React.createRef(); | ||
|
||
// A reference to the last index required to scroll to, for async layout change handler. | ||
let lastIndex; | ||
|
||
/** | ||
* Scroll to the provided index. | ||
* | ||
* @param {Object} index | ||
*/ | ||
function scrollToIndex(index) { | ||
flatListRef.current.scrollToIndex(index); | ||
lastIndex = index; | ||
} | ||
|
||
/** | ||
* Scroll to the last saved index on layout change | ||
* See https://github.com/Expensify/App/issues/15303 for more context | ||
*/ | ||
function scrollToLastIndex() { | ||
if (!flatListRef.current) { | ||
return; | ||
} | ||
if (lastIndex === undefined) { | ||
return; | ||
} | ||
|
||
flatListRef.current.scrollToIndex(lastIndex); | ||
lastIndex = undefined; | ||
} | ||
|
||
/** | ||
* Scroll to the bottom of the flatlist. | ||
* | ||
*/ | ||
function scrollToBottom() { | ||
if (!flatListRef.current) { | ||
return; | ||
} | ||
|
||
flatListRef.current.scrollToOffset({animated: false, offset: 0}); | ||
lastIndex = 0; | ||
} | ||
|
||
export { | ||
flatListRef, | ||
scrollToIndex, | ||
scrollToBottom, | ||
scrollToLastIndex, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.