Skip to content

Correct the Onyx beta key that sidebar connects to #11188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2022
Merged

Correct the Onyx beta key that sidebar connects to #11188

merged 1 commit into from
Sep 22, 2022

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Sep 21, 2022

I noticed this bug from #10800

Tests & QA

  1. Make sure you have an account in the policyRooms beta
  2. Create a # New Room from the global create menu
  3. Verify that the new room appears in the LHN after creating it

cc @marcaaron @neil-marcellini oops!

@tgolen tgolen self-assigned this Sep 21, 2022
@tgolen tgolen marked this pull request as ready for review September 21, 2022 22:28
@tgolen tgolen requested a review from a team as a code owner September 21, 2022 22:28
@melvin-bot melvin-bot bot requested review from youssef-lr and removed request for a team September 21, 2022 22:29
@youssef-lr
Copy link
Contributor

youssef-lr commented Sep 21, 2022 •
edited
Loading

Make sure you have an account in the policyRooms beta

hey @tgolen! Care to guide me on how to have an account in policyRooms beta? Thanks!

@marcaaron
Copy link
Contributor

Is the other PR on staging and if so should we CP this to staging?

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@tgolen
Copy link
Contributor Author

tgolen commented Sep 22, 2022

@marcaaron Good point, I'll add the CP staging label and you can merge this.

@youssef-lr All dev accounts have all betas enabled. The normal process for adding someone to a beta is outlined in https://stackoverflow.com/c/expensify/questions/5563

@tgolen tgolen mentioned this pull request Sep 22, 2022
Closed
16 tasks
@luacmartins
Copy link
Contributor

luacmartins commented Sep 22, 2022 •
edited
Loading

Hmm this PR appeared as a Deploy Blocker in the checklist somehow, but that doesn't seem to be the case?

@luacmartins luacmartins merged commit 60ca87e into main Sep 22, 2022
@luacmartins luacmartins deleted the tgolen-correct-connection branch September 22, 2022 16:08
@melvin-bot melvin-bot bot added the Emergency label Sep 22, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2022

@luacmartins looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@luacmartins
Copy link
Contributor

luacmartins commented Sep 22, 2022 •
edited
Loading

We skipped the checklist tests to get this CP'ed asap to unblock the deploy. Removing the Emergency label.

OSBotify pushed a commit that referenced this pull request Sep 22, 2022
@luacmartins @OSBotify
Merge pull request #11188 from Expensify/tgolen-correct-connection
a9085b0 
Correct the Onyx beta key that sidebar connects to

(cherry picked from commit 60ca87e)
@OSBotify OSBotify mentioned this pull request Sep 22, 2022
Merged
OSBotify added a commit that referenced this pull request Sep 22, 2022
@OSBotify
Merge pull request #11210 from Expensify/OSBotify-cherry-pick-staging…
96af086 
…-11188

🍒 Cherry pick PR #11188 to staging 🍒
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @luacmartins in version: 1.2.4-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Sep 22, 2022
Closed
20 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @luacmartins in version: 1.2.4-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Oct 14, 2022
Closed
53 tasks
@OSBotify OSBotify mentioned this pull request May 2, 2023
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luacmartins luacmartins luacmartins approved these changes

@marcaaron marcaaron marcaaron approved these changes

@youssef-lr youssef-lr Awaiting requested review from youssef-lr

Assignees

@tgolen tgolen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tgolen @youssef-lr @marcaaron @luacmartins @OSBotify