Fix Deep Links not working on Android 12+ #10128
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| [{ | ||
| "relation": ["delegate_permission/common.handle_all_urls"], | ||
| "target": { | ||
| "namespace": "android_app", | ||
| "package_name": "com.expensify.chat", | ||
| "sha256_cert_fingerprints": ["2E:65:6F:1C:34:F5:7E:BF:FC:C0:2D:A3:14:0E:83:FE:61:51:F2:9B:5D:59:58:61:C4:4D:A9:99:0C:CA:F4:8E"] | ||
| } | ||
| }] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -29,23 +29,24 @@ | |||||
| <activity | ||||||
| android:name=".bootsplash.BootSplashActivity" | ||||||
| android:theme="@style/BootTheme" | ||||||
| android:launchMode="singleTask" | ||||||
| android:exported="true"> | ||||||
|
There was a problem hiding this comment.
Suggested change
There was a problem hiding this comment. The value for According to Android docs:
Our app component includes the LAUNCHER category |
||||||
|
|
||||||
| <intent-filter android:autoVerify="true"> | ||||||
| <action android:name="android.intent.action.MAIN" /> | ||||||
| <category android:name="android.intent.category.LAUNCHER" /> | ||||||
| </intent-filter> | ||||||
|
|
||||||
| <!-- Custom URI handlers. Used to intercept Urban Airship deep links. --> | ||||||
| <intent-filter android:autoVerify="true"> | ||||||
| <action android:name="android.intent.action.VIEW"/> | ||||||
| <category android:name="android.intent.category.DEFAULT"/> | ||||||
| <category android:name="android.intent.category.BROWSABLE"/> | ||||||
| <data android:scheme="new-expensify"/> | ||||||
| </intent-filter> | ||||||
|
|
||||||
| <!-- Web URL handlers. Used to intercept web links. --> | ||||||
| <intent-filter android:autoVerify="true"> | ||||||
| <action android:name="android.intent.action.VIEW"/> | ||||||
| <category android:name="android.intent.category.DEFAULT"/> | ||||||
| <category android:name="android.intent.category.BROWSABLE"/> | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? Or we have to change it. The gpg key in the codebase is encrypted if you used that to get the signature.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I extracted it from the New Expensify's APK from the Play Store, so it should probably work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrewGable Could you please verify this? https://developer.android.com/training/app-links/verify-site-associations#web-assoc .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrewGable might be a bit slow to respond this week… He's getting married 😅 💍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, definitely he won't be able to respond. In that case, @deetergp Could you please check the signature? https://developer.android.com/training/app-links/verify-site-associations#web-assoc has details to get the signature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.. Please let's double check this..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified in Google Play store and it is correct!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @luacmartins