[$250] Phone number given at the example isn't a valid number it has 9 digits - reported by @Puneet-here

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to concierge chat
2. Click phone icon
3. Enter an alphabet
4. Press Call me

Expected Result:

The number at error message example should be a valid number

Actual Result:

The number isn't a valid number

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1657142374202149

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kevinksullivan (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Puneet-here]

Proposal

Need to change the number to +15005550006 or +447782339811 (we are already using these numbers on some other places) at:-

App/src/languages/en.js

Line 84 in 03a2422

phoneNumber: 'Please enter a valid phone number, with the country code (e.g. +1234567890)',

App/src/languages/es.js

Line 84 in 03a2422

phoneNumber: 'Ingresa un teléfono válido, incluyendo el código de país (p. ej. +1234567890)',

also shouldn't we use one same number here too?

App/src/languages/en.js

Line 583 in 03a2422

errorMessageInvalidPhone: 'Please enter a valid phone number without brackets or dashes. If you\'re outside the US please include your country code, eg. +447782339811',

App/src/languages/en.js

Line 860 in 03a2422

pleaseEnterValidLogin: 'Please ensure the email or phone number is valid (e.g. +15005550006).',

[melvin-bot]

@kevinksullivan Still overdue 6 days?! Let's take care of this!

[kevinksullivan]

Heh, nice catch!

[kevinksullivan]

https://www.upwork.com/jobs/~0187f2a7b5616f036e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot]

Triggered auto assignment to @tgolen (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hamzashakeel348]

Hi Expensify team, I hope you are well.

The issue of the error message, that contains the wrong phone no. It is because of the data provided to the app by the backend. We have to updated the json file, that is containing that specific data. For that, I already cloned the repo and I am working on a app for you.

I can do it just a couple of hours. Looking forward to hearing from you at the earliest.

Regards,
Hamza

[hamzashakeel348]

Can I get credentials to login and to check the updates, as I am stuck on login.

?

[Puneet-here]

@hamzashakeel348, you need to create your own account to login.

[hamzashakeel348]

@Puneet-here I am trying to create it, but it is giving "Looks like you're offline. Please check your connection and try again." error.

[Puneet-here]

Are you on localhost:8080 ?
Also try reading this, it might help.

[hamzashakeel348]

Yes, I am on Localhost:8080.

[hamzashakeel348]

@Puneet-here Here you can see the results of my update, phone no mentioned above in the comments is no rendering, I think so this is what was required, you can guide me further.

[Puneet-here]

@hamzashakeel348, you have to post a proposal here about what changes you will make and you have to mention where you will be making them (link of specific code)

You can check the closed issues (fixed ones) in the repo to find how things work.
Also, I will suggest you to check other issues with the help wanted label on it and propose solution there as this is simple issue and I have already added the solution here.

And yeah read this one too- https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md

[hamzashakeel348]

@Puneet-here I already post the proposal above in the comments, as you said that this issue already got resolved, but recently an hour ago your team posted an upwork job for it, so I was supposed to do so by following that post.

Let me know what to do for it now, in the meanwhile I am looking for other issues.

[Puneet-here]

I meant I have already commented the solution, also you have to post a proposal like this. You have to link the code, where you will be making the changes.

[tgolen]

Not overdue

[rushatgabhane]

@kevinksullivan this issue can be settled.

Melvin didn't comment the payment date because it was OOO during a release cycle xD

[Puneet-here]

@kevinksullivan is OOO ( getting married 💍 🥂 ).
@tgolen please re-apply external label so that someone else can be assigned here.

[melvin-bot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[adelekennedy]

checking on this, @rushatgabhane from the comment above it sounds like payment is due! Is that correct?

[rushatgabhane]

@adelekennedy yes, that's right

[adelekennedy]

reopened the job - just sent you an offer @rushatgabhane

[rushatgabhane]

@adelekennedy thank you!

[Puneet-here]

Hey @adelekennedy, the reporting and fixing compensation is also pending.

[anasdeyra]

PROPOSAL
If I understood the issue right there is a constant called EXAMPLE_PHONE_NUMBER in src/CONST.js that needs to be changed to a valid number

[melvin-bot]

@tgolen, @kevinksullivan, @rushatgabhane, @adelekennedy Eep! 4 days overdue now. Issues have feelings too...

[tgolen]

@anasdeyra thanks for the proposal, but this has already been worked on and fixed. I think we're just trying to settle it up.

[kevinksullivan]

Sorry for the delay everyone, and thanks for stepping in @adelekennedy . Paid @Puneet-here for reporting + solving, and @rushatgabhane for C+.