[HOLD for payment 2022-04-12] Security - Button color in the confirmation popup "Okay, Got it" is grey instead of green when closing the account

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/[](javascript:)
2. Log in to account [email protected]/Feya86Katya
3. Go to Settings - Security - Close account
4. Enter the message in input box
5. Enter email which you are going to close
6. Click close account

Expected Result:

"Okay, Got it" button is green color.

Actual Result:

"Okay, Got it" button is grey color instead of green color.

Workaround:

Visual

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.41.4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected] / Feya86Katya
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5482831_Recording__38.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause (Exploratory)
Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mateusbra]

PROPOSAL (if external)

We need to pass success prop as true

App/src/pages/settings/Security/CloseAccountPage.js

Lines 113 to 116 in bc4f429

	<ConfirmModal
	title=""
	success={false}
	confirmText={this.props.translate('closeAccountPage.okayGotIt')}

Will change line 115 to:

<ConfirmModal
    title=""
    success
    confirmText={this.props.translate('closeAccountPage.okayGotIt')}

SCREENSHOT

[MelvinBot]

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[thesahindia]

@tylerkaraszewski, I think we need to assign @stephanieelliott here

[thesahindia]

@mateusbra, I think you should wait until the issue gets external label.

Proposal

Just need to remove success={false} we don't need to pass success as its value is true by default.

 <ConfirmModal 
     title="" 
-    success={false} 
     confirmText={this.props.translate('closeAccountPage.okayGotIt')} 

App/src/pages/settings/Security/CloseAccountPage.js

Lines 113 to 117 in 67f26ba

	<ConfirmModal
	title=""
	success={false}
	confirmText={this.props.translate('closeAccountPage.okayGotIt')}
	prompt={(

[MelvinBot]

Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[MelvinBot]

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

[MelvinBot]

📣 @Santhosh-Sellavel You have been assigned to this job by @melvin-bot[bot]!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Triggered auto assignment to @deetergp (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[stephanieelliott]

Posted to Upwork: https://www.upwork.com/jobs/~01999d68f951063456

@Santhosh-Sellavel and @deetergp we have two proposals already here (first) and here (second).

[tamal-thetaonelab]

Proposal:

Just to pass true instead of false for the prop success
https://github.com/Expensify/App/blob/main/src/pages/settings/Security/CloseAccountPage.js#L115

https://www.awesomescreenshot.com/video/7997953?key=1d5729698e07c9f0a5520229487c31bc

[Santhosh-Sellavel]

@deetergp
Simple on all the proposals are similar!
So let's go with the first one, @mateusbra Proposal LGTM!
🎀👀🎀 C+ reviewed.

Note:
I see @thesahindia suggested removing the prop itself. I prefer keeping it there for easier understanding.

[deetergp]

I agree, @Santhosh-Sellavel, let's go with @mateusbra's proposal 👍

[mateusbra]

@stephanieelliott I think you gaved us the wrong link on #8048 (comment)

I found the correct one here:
https://www.upwork.com/jobs/~0173d8f308a66109e4
I sent you a proposal on Upwork

[stephanieelliott]

Oop, thanks @mateusbra! Hired you in Upwork.

[MelvinBot]

📣 @mateusbra You have been assigned to this job by @stephanieelliott!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[stephanieelliott]

PR is undergoing QA

[stephanieelliott]

PR on staging

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.49-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Button color change on close account popup. #8283

If no regressions arise, payment will be issued on 2022-04-12. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[stephanieelliott]

@mateusbra paid you out in Upwork!
@Santhosh-Sellavel will pay you out ASAP, please accept the Upwork offer when you get a chance!

[Santhosh-Sellavel]

@stephanieelliott done thanks!

[stephanieelliott]

All paid, thanks!