Workspace - Can't open the Admin owner profile in Members tab

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.47-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition: User has created a workspace before

1. Go to the Workspace editor
2. Click on the Members tab
3. Click on the Admin owner profile

Expected Result:

The user can open the Admin profile

Actual Result:

Nothing happen after clicking on the Admin owner

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6836966_1747738379647.owner_profile.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021924814134896421646
• Upwork Job ID: 1924814134896421646
• Last Price Increase: 2025-05-20

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Valforte (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nlemma]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[Valforte]

This bug looks to be a little deeper, If I'm not the workspace Admin I can't open any member tab.
Comparing to prod the request is not being sent to its a front-end issue, can be handled by external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021924814134896421646

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[Valforte]

Sorry, I haven't had to set a deploy blocker to external, figuring out the proper way to do it

[Valforte]

Found the offending PR #61834 @ChavdaSachin can you update me on the status of this issue? Also read my comment here please #62360 (comment)

[Valforte]

Tagging @Pujan92 to follow

[LorenzoBloedow]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Can't open the owner profile in workspace members tab

What is the root cause of that problem?

Returning early if isDisableCheckbox is true:

App/src/pages/workspace/WorkspaceMembersPage.tsx

Lines 401 to 403 in fa08e61

	if (item.isDisabledCheckbox) {
	return;
	}

which gets set to true if the current account ID is the owner's:

App/src/pages/workspace/WorkspaceMembersPage.tsx

Line 471 in fa08e61

isDisabledCheckbox: !(isPolicyAdmin && accountID !== policy?.ownerAccountID && accountID !== session?.accountID),

What changes do you think we should make in order to solve the problem?

Along with the isDisabledCheckbox check we need to make sure we're not specifically targeting the owner.

if (item.isDisabledCheckbox && policy?.ownerAccountID !== item.accountID) {
  return;
}

put that here:

App/src/pages/workspace/WorkspaceMembersPage.tsx

Lines 401 to 403 in fa08e61

	if (item.isDisabledCheckbox) {
	return;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• UI test that checks if we can open the workspace owner's detail page.

What alternative solutions did you explore? (Optional)

N/A

[ChavdaSachin]

@Valforte this is coming from my pr please assign me along with @Pujan92

[ChavdaSachin]

@Valforte I have the fix but I am unable to enable selection mode on workspaceViewTags page, which is blocking me from testing the fix for current issue.

This issue is on both staging and production.

Screen.Recording.2025-05-20.at.7.20.07.PM.mov

I have a fix for this selection mode as well, could you please create a new issue for the selectionMode not turning-on on workspaceViewTags. so that I could raise a quick PR to fix the selection mode and then I could raise a pr for current issue as well.

Repro steps:

1. have a workspace with multi level tags.
2. Navigate to workspace > tags > subtags.
3. long press the item.
4. notice selection mode does not turn on.

[LorenzoBloedow]

@Valforte Hi! Could you please let me know if deploy blockers are only supposed to be fixed by the authors of the offending PR? I'm not opposing that @ChavdaSachin fixes it, I'm just asking so I can skip these issues in the future. Thanks! :)

[Valforte]

@LorenzoBloedow, they can be fixed by other external contributors; it was an error on my end by applying the external label early! Sorry about that, and you should NOT skip those! For the moment, I'll try to work on this with @ChavdaSachin, but it can become open for other proposals at a later moment!
Again, sorry about the confusion I caused!

[LorenzoBloedow]

No worries, thank you for the quick response! :)

[Valforte]

As for @ChavdaSachin please give me a moment to figure out the proper way to move forward! I'll reply and tag you as soon as possible

[Pujan92]

@Valforte You can directly assign this issue to @ChavdaSachin and me. @ChavdaSachin will raise a PR against our PR which caused a regression.

[ChavdaSachin]

please take a look at this as well
#62360 (comment)

[Pujan92]

I will check it from my side, meanwhile plz open a draft PR with the other changes.

[arosiclair]

So to confirm, #61834 is the root cause of this issue? This seems maybe not straight forward to fix from this comment? If so, I think we should just revert and clean everything up later. Thoughts @Valforte?

[Valforte]

Yeah I think its better to revert while the fix is worked on, what is the process for that @arosiclair?

[arosiclair]

1. Use the Revert button on the PR
2. Get the revert PR reviewed (you can assign me)
3. Request a cherry-pick in the #deployer channel (use the Workflow at the top of the window)
4. Wait until it's done and QA it on staging

[arosiclair]

Working on the CP and still needs QA

[arosiclair]

Still waiting on @Valforte for QA

[arosiclair]

Fixed