Skip to content

Tooltip - Workspaces tooltip appears above Workspaces row and overlaps with Workspaces header #62141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 of 16 tasks
lanitochka17 opened this issue May 15, 2025 · 10 comments
Open
3 of 16 tasks
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented May 15, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.46-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch Expensify app
  2. Go to Workspaces
  3. Tap Workspaces
  4. Create a new workspace
  5. Tap Workspaces tab twice

Expected Result:

Workspaces tooltip should appear below Workspaces icon (production behavior)

Actual Result:

Workspaces tooltip appears above Workspaces row and overlaps with Workspaces header
The tooltip is white instead of green which does not match other tooltips (GBR tooltip for instance)

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6832513_1747341822053.ScreenRecording_05-16-2025_03-48-07_1.1.mp4
Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @WojtekBoman
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label May 15, 2025
Copy link

melvin-bot bot commented May 15, 2025

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 15, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

Production:

Image

@WojtekBoman
Copy link
Contributor

Hey, I'll take a look at as I'm the author of the offending PR

@WojtekBoman
Copy link
Contributor

@flaviadefaria @mountiny

I wonder if I should adjust the position of this tooltip or remove it completely? We don't have a tooltip leading to this tab (here's the description why), so I'm curious if this tooltip is still needed

@mountiny
Copy link
Contributor

I think this is quite minor so potentially does not have to hold the deploy

@WojtekBoman I think we should adjust the position, can you work on that?

@WojtekBoman
Copy link
Contributor

Sure, the PR will be ready soon!

@flaviadefaria
Copy link
Contributor

I wonder if I should adjust the position of this tooltip or remove it completely?

Oh, I thought we had removed it already when we last discussed the Settings tooltip. Yes, let's remove it completely but I agree that this shouldn't block the deploy.

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment labels May 16, 2025
@mountiny
Copy link
Contributor

Lets remove it then and demoted too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants