Skip to content

[Due for payment 2025-05-27] [Due for payment 2025-05-14] [Desktop Navigation] Add a new Workspaces tab to the navigators and update navigation bar styles #59371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mountiny opened this issue Mar 31, 2025 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Mar 31, 2025

Part of https://github.com/Expensify/Expensify/issues/468845

Implement this section of the Design doc (linking to the tasks section as this project is being handled by SWM).

Issue OwnerCurrent Issue Owner: @sonialiap
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Mar 31, 2025
Copy link

melvin-bot bot commented Mar 31, 2025

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 31, 2025
@adamgrzybowski
Copy link
Contributor

This one is for me 👋

@adamgrzybowski
Copy link
Contributor

The draft is here. After merging other PRs from this project and removing beta, we will need to do some finishing touches. #60184

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 5, 2025
@melvin-bot melvin-bot bot changed the title [Desktop Navigation] Add a new Workspaces tab to the navigators and update navigation bar styles [Due for payment 2025-05-14] [Desktop Navigation] Add a new Workspaces tab to the navigators and update navigation bar styles May 7, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 7, 2025
Copy link

melvin-bot bot commented May 7, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 7, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-14. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 7, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@dukenv0307] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 13, 2025
@sonialiap
Copy link
Contributor

@mountiny do you think we need a regression test here?

@mountiny
Copy link
Contributor Author

We have not deployed yet but we will handle the regression steps altogether

Copy link

melvin-bot bot commented May 14, 2025

Payment Summary

Upwork Job

BugZero Checklist (@sonialiap)

  • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@sonialiap
Copy link
Contributor

Deployed to production. @mountiny will the regression steps be handled in another issue so I can close this, or should I keep this open?

@mountiny
Copy link
Contributor Author

These will be handled together as part of the project so I think we can close this - payment is the same

@github-project-automation github-project-automation bot moved this from Todo to Done in [#whatsnext] #convert May 15, 2025
Copy link

melvin-bot bot commented May 16, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 20, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-05-14] [Desktop Navigation] Add a new Workspaces tab to the navigators and update navigation bar styles [Due for payment 2025-05-27] [Due for payment 2025-05-14] [Desktop Navigation] Add a new Workspaces tab to the navigators and update navigation bar styles May 20, 2025
Copy link

melvin-bot bot commented May 20, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-27. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 20, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@dukenv0307] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
Development

No branches or pull requests

5 participants