[Due for payment 2025-05-22] [Payment Due 05-22-2025][$250] Reports - After refreshing Default report title RHP, More features page opens and RHP closes

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.45-18
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: #59568
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Go to Reports tab.
4. Click Default report title.
5. Refresh the page.

Expected Result:

App will stay in Reports page with Default report title RHP opened.

Actual Result:

App opens More features and Default report title RHP is closed.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021922998382341134185
• Upwork Job ID: 1922998382341134185
• Last Price Increase: 2025-05-15
• Automatic offers:
• ChavdaSachin | Contributor | 107319117

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - After refreshing Default report title RHP, More features page opens and RHP closes

What is the root cause of that problem?

Missing case during migration from reportFields to reports.

In linker the report -> default report title page is associated with wrong central screen

App/src/libs/Navigation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts

Line 246 in 84d940b

SCREENS.WORKSPACE.RULES_CUSTOM_NAME,

What changes do you think we should make in order to solve the problem?

Move it from [SCREENS.WORKSPACE.RULES] to [SCREENS.WORKSPACE.REPORT_FIELDS]

App/src/libs/Navigation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts

Line 205 in 84d940b

[SCREENS.WORKSPACE.REPORT_FIELDS]: [

Also we should fix the path here

        route: 'settings/workspaces/:policyID/reportFields/name',

App/src/ROUTES.ts

Lines 1821 to 1823 in 84d940b

	RULES_CUSTOM_NAME: {
	route: 'settings/workspaces/:policyID/rules/name',
	getRoute: (policyID: string) => `settings/workspaces/${policyID}/rules/name` as const,

We should also rename the route appropriately.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ChavdaSachin]

I've verified - my solution is working perfectly. I could raise a quick PR if needed.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021922998382341134185

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[dukenv0307]

@ChavdaSachin's proposal looks good to me and test well.

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @Gonals is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @ChavdaSachin 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Gonals]

All yours, @ChavdaSachin. This is a deploy blocker, so we'll want the fix ready ASAP :)

[ChavdaSachin]

Would be ready within an hour

[mountiny]

@ChavdaSachin Lets get it out for a review

[ChavdaSachin]

few minutes, capturing videos

[ChavdaSachin]

Ready for review #62112

[ChavdaSachin]

Since this was a blocker I quickly raised the fix.
But there should be followup cleanup for RulesCustomNamePage.

1. Change the RulesCustomNamePage directory from src/pages/workspace/rules to src/pages/workspace/reportFields and rename the file appropriately.
2. All the translations are located under workspace.rules section in en.ts and es.ts which should be migrated under workspace.reports section.
3. Fix the page path from route: 'settings/workspaces/:policyID/rules/name', to route: 'settings/workspaces/:policyID/reportFields/name', and rename the route name from RULES_CUSTOM_NAME to REPORTS_CUSTOM_NAME

Since there were many changes here I just raised the fix to quickly tackle the blocker.

@Gonals should I make these changes in following PR or the original PR author should do the cleanup?

cc. @Gonals @dukenv0307 @mountiny

[mountiny]

@ChavdaSachin Who worked on the original change? I think they should do this

[dukenv0307]

@ChavdaSachin Good catch, I think we should handle it in other PRs

[ChavdaSachin]

This PR originally moved the custom report name feature from workspace -> rules to workspace -> reports.

[ChavdaSachin]

Perhaps automation failed here.
This should be ready for payment on 22-5-2025
@Gonals

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix RulesCustomNamePage linking #62112

If no regressions arise, payment will be issued on 2025-05-27. 🎊

For reference, here are some details about the assignees on this issue:

• @ChavdaSachin requires payment automatic offer (Contributor)
• @dukenv0307 requires payment through NewDot Manual Requests

[melvin-bot]

@dukenv0307 @adelekennedy @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[ChavdaSachin]

Again Melvin messed it up 🤦🏻‍♂️

[adelekennedy]

I've updated the title