[hold for payment 2025-05-22] [$250] Thread-User invited via Whisper not shown in Members section & cannot invited in 2nd expense

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: V9.1.40-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/a
Email or phone of affected tester (no customers): Slottwo1 [email protected]
Issue reported by: Applause Internal Team
Device used: Redminote note 10s android 13
App Component: Chat Report View

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Open workspace chat
3. Create a manual expense
4. Open the expense
5. Send a mention
6. Tap invite
7. Check in members page, invited member is not added by tapping header - members section
8. Create another expense
9. Open the expense
10. Invite the same user via whisper
11. Note mention is not shown
12. Send another mention
13. Invite them by tapping invite in whisper
14. Go to members and check invited member is displayed
15. Open first expense and note user invited not shown in members section

Expected Result:

User invited to a report via Whisper must be shown in Members section of that report.

Actual Result:

User invited via whisper to a report is not always shown in the members section of that report.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021920119943181329486
• Upwork Job ID: 1920119943181329486
• Last Price Increase: 2025-05-07

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[joekaufmanexpensify]

Hmm, interesting. I am checking to make sure it is expected that the parent report and each child transaction thread can have separate member lists. I think they can. If so, I agree you should be able to invite a user via mention to the parent report or any of its child transaction threads and actually have them be added to the thread.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User invited from whisper isn't shown on the members page.

What is the root cause of that problem?

The user is actually invited successfully, and the expense report contains the member from expense A and expense B. For example, if we invite user 1 in expense A and user 2 in expense B, the expense report will have both user 1 and 2as the members.

The problem here is that those users have a hidden notification preference, and we exclude it from the members.

App/src/pages/ReportDetailsPage.tsx

Lines 269 to 271 in 802e0d7

	const participants = useMemo(() => {
	return getParticipantsList(report, personalDetails, shouldOpenRoomMembersPage);
	}, [report, personalDetails, shouldOpenRoomMembersPage]);

App/src/libs/ReportUtils.ts

Lines 2769 to 2770 in 1082941

	const shouldExcludeHiddenParticipants = !isReportGroupChat && !isReportIOU;
	const chatParticipants = getParticipantsAccountIDsForDisplay(report, isRoomMembersList || shouldExcludeHiddenParticipants, false, false, reportMetadata);

What changes do you think we should make in order to solve the problem?

If we want to include hidden notification preference users in the members of both expense report and transaction thread, then we can update shouldExcludeHiddenParticipants to also check for expense report and transaction thread (isMoneyRequest, isMoneyRequestReport, and track too if needed).

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Create a test for getParticipantsList and make sure all hidden participant is returned for expense and transaction thread.

[joekaufmanexpensify]

Looked into this more, and if someone is invited via a mention to a specific report, we do want to add them to that specific report and show them on the members list.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021920119943181329486

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[bradyrose]

Withdrawing this proposal to comply with Expensify’s one-proposal-at-a-time policy.
Hope to circle back if it’s still open later. Thanks!

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[bradyrose]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

thanks, I have updated the proposal.

[ishpaul777]

@bernhardoj proposal makes sense to me 🚀

🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[bernhardoj]

PR is ready

cc: @ishpaul777

[joekaufmanexpensify]

PR in review

[joekaufmanexpensify]

Automation failed here. Payment is due 2025-05-22.

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[joekaufmanexpensify]

Assigning another BZ because I am OOO from May 21st - May 30th. If it's still open then I'll take it back over! Next steps are to issue payment on 2025-05-22. Payment is:

• $250 to @bernhardoj for PR via NewDot.
• $250 to @ishpaul777 for C+ via NewDot.