Skip to content

Review duplicates - Attendees field can be edited on confirmation page #61431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 of 8 tasks
mitarachim opened this issue May 6, 2025 · 9 comments · Fixed by #61484
Closed
7 of 8 tasks

Review duplicates - Attendees field can be edited on confirmation page #61431

mitarachim opened this issue May 6, 2025 · 9 comments · Fixed by #61484
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.40-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: #58402
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two manual expenses with the same amount and merchant.
  4. Go to transaction thread of any expense.
  5. Click Review duplicates.
  6. Select Keep this one on any expense preview.
  7. On the confirmation page, click Attendees.
  8. Edit the attendees.

Expected Result:

Attendees field should be disabled on the confirmation page when reviewing duplicates (other fields are disabled on confirmation page).

Actual Result:

Attendees field is not disabled on the confirmation page when reviewing duplicates and can be edited.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6822642_1746496671111.20250506_095253.mp4

View all open jobs on GitHub

@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 6, 2025
Copy link

melvin-bot bot commented May 6, 2025

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 6, 2025

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 6, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 6, 2025
Copy link
Contributor

github-actions bot commented May 6, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@ijmalik
Copy link
Contributor

ijmalik commented May 6, 2025

This issue is also resolved by this proposal

Image

@joekaufmanexpensify
Copy link
Contributor

cc @francoisl @allroundexperts too as they are both leading the attendees project

@danieldoglas
Copy link
Contributor

Removing DelployBlocker, doesn't seem related to the backend - possibly related to a new feature.

@danieldoglas danieldoglas removed the DeployBlocker Indicates it should block deploying the API label May 6, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels May 6, 2025
@Julesssss Julesssss assigned Julesssss and unassigned aldo-expensify May 6, 2025
@Julesssss
Copy link
Contributor

New feature, I put this back under feature flag while we polish a few more things.

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label May 6, 2025
@aldo-expensify
Copy link
Contributor

Thanks for handling @Julesssss , I was traveling and my internet was horrible ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants