-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[$125] android-status-After selecting emoji, message field shown focused but keypad not shown #61328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @twisterdotcom ( |
Yeah, sure. Niche but would be nice to show the keyboard whenever the field is focused of course. |
Job added to Upwork: https://www.upwork.com/jobs/~021918306415997154754 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf ( |
Upwork job price has been updated to $125 |
ProposalPlease re-state the problem that we are trying to solve in this issue.After selecting emoji, message field shown focused but keypad not shown. What is the root cause of that problem?Here we are focusing the text input when the App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx Lines 200 to 202 in 3a7784e
The root cause is a race condition between the dismissal animation of the modal and the invocation of the What changes do you think we should make in order to solve the problem?We should delay the .focus() call until after the modal has fully closed by using setTimeout with a slight delay (e.g. 150ms), or use InteractionManager.runAfterInteractions() to ensure the UI is idle before focusing the input. onModalHide={() => {
setTimeout(() => {
inputRef.current?.focus();
}, 150);
}} Results After_Keyboard_Fix.mp4What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?None, it's a timing issue in the UI What alternative solutions did you explore? (Optional)None :( Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
ProposalPlease re-state the problem that we are trying to solve in this issue.The keyboard doesn't show after the emoji picker is closed. What is the root cause of that problem?We immediately focus on the input when the modal hides, App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx Lines 200 to 202 in 395f65f
but it's a known issue on Android that modal hide callback is called too early, which is why most of the time, we delay the focus. What changes do you think we should make in order to solve the problem?We can use
or We can use
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?N/A |
🚨 Edited by proposal-police: This proposal was edited at 2025-05-02 21:53:04 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.android-status-After selecting emoji, message field shown focused but keypad not shown What is the root cause of that problem?Once the emoji picker modal closes, it calls the App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx Lines 200 to 202 in 7f68056
What changes do you think we should make in order to solve the problem?We should make use of Update this line: App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx Lines 200 to 202 in 7f68056
with, onModalHide={() => {
InteractionManager.runAfterInteractions(() => {
setTimeout(() => {
inputRef.current?.focus();
}, 50);
});
}} What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?NA What alternative solutions did you explore? (Optional)ResultReminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
|
@allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Looking today! |
Solution from @bernhardoj makes the most sense to me, lets go with their proposal. 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
PR is ready cc: @allgandalf |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
^ false flag |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: V9.1 30-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/a
Email or phone of affected tester (no customers): Slottwo1 [email protected]
Issue reported by: Applause Internal Team
Device used: Redminote note 10s android 13
App Component: User Settings
Action Performed:
Expected Result:
After selecting emoji, message field shown focused so keypad must be shown.
Actual Result:
After selecting emoji, message field shown focused but keypad not shown.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6819575_1746190171165.Screenrecorder-2025-05-02-18-10-00-746.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @yuwenmemonThe text was updated successfully, but these errors were encountered: