[Due for payment 2025-05-14] [Due for payment 2025-05-13] [$250] Login - Email field is auto unfocused

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.39-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: NA
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 10 /Chrome
App Component: Other

Action Performed:

1. Go to staging.new.expensify.com
2. Log out if logged in.
3. Refresh the page.

Expected Result:

Email field will auto focus.

Actual Result:

Email field is auto unfocused. Error is thrown.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6818931_1746132744385.bandicam_2025-05-01_23-44-26-585.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021918094989548484511
• Upwork Job ID: 1918094989548484511
• Last Price Increase: 2025-05-02
• Automatic offers:
• suneox | Reviewer | 107144301
• ChavdaSachin | Contributor | 107144303

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[chiragsalian]

Good catch, normally i would say a stylistic change shouldn't be a blocker but in this case it also throws an error which is not ideal. Yeah let's tackle this. Marking it as external. Its only a blocker for App and not for web-e.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021918094989548484511

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login - Email field is auto unfocused

What is the root cause of that problem?

Fallback value false is being passed here

App/src/pages/signin/SignInPage.tsx

Line 157 in 4a667a3

const isAccountValidated = account?.validated ?? false;

Due which blurOnSubmit is always true when user is not logged in

App/src/pages/signin/SignInPage.tsx

Line 324 in 4a667a3

blurOnSubmit={isAccountValidated === false}

before this refactor this condition was working perfectly coz useAccountValidation hook would return undefined on login page and hence the condition was false and would not auto blur the input field on login page.

What changes do you think we should make in order to solve the problem?

Remove fallback value here.

App/src/pages/signin/SignInPage.tsx

Line 157 in 4a667a3

const isAccountValidated = account?.validated ?? false;

    const isAccountValidated = account?.validated;

Additionally there are a few more pages where similar code is used which should be checked if the same issue is recurring there,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[ChavdaSachin]

@chiragsalian I've checked my solution, and it is working perfectly.
I could raise a quick PR if you need.

I've also checked for possible side effects but there's nothing to worry about

[chiragsalian]

Nice, pretty quick. i found the issue came from this PR. Reverting it solves the issue. But i like that you have a proposal. Looking 👀

[chiragsalian]

Neat, your proposal LGTM. I like that we don't have the default.
Since this is an hourly, Can you put up a PR quickly to tackle this? assigning it to you @ChavdaSachin.

[melvin-bot]

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jliexpensify]

Payment Summary

• C: @ChavdaSachin $250 (to be paid via Upworks)

https://www.upwork.com/jobs/~021918094989548484511

[ChavdaSachin]

@jliexpensify I think there should be no payment for @suneox here.
Please confirm with @chiragsalian

[jliexpensify]

Oh right, it looks like it's a revert from a PR. @chiragsalian - no payment for @suneox?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP-stag] Remove fallback value #61286

If no regressions arise, payment will be issued on 2025-05-14. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Reviewer)
• @ChavdaSachin requires payment automatic offer (Contributor)

[melvin-bot]

@suneox @jliexpensify @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[chiragsalian]

Its not a revert. We went with the solution from @ChavdaSachin.
So @ChavdaSachin should get paid.

No payment for @suneox because i rushed this forward since it was a deploy blocker. So @suneox didnt have any involvement here cause he didnt do proposal or PR review. Because i skipped it for him in the interest of speed.

[jliexpensify]

Thanks @chiragsalian - updated the payment summary here. Do we need a checklist then?

[jliexpensify]

@chiragsalian just checking - is a checklist needed?

[chiragsalian]

sorry i missed this. did you mean the bugzero checklist? If so yeah i dont think its needed for this issue at this time.

[jliexpensify]

Sweet, thanks Chirag!

Payment Summary is here, closing!

[ChavdaSachin]

@jliexpensify you closed the issue but forgot to release the payment perhaps.

[jliexpensify]

@ChavdaSachin you're not paid via New Expensify?

[jliexpensify]

Ah sorry, got confused - let me sort it out now.

[jliexpensify]

Paid and job closed cc @ChavdaSachin

[ChavdaSachin]

Thanks.