[$250] "Migrated User Welcome" modal URL has no response

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.33-8
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #60719
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 10 /Chrome, Samsung Galaxy s10/ Chrome
App Component: Other

Action Performed:

1. Navigate to staging.new.expensify.com
2. Log in to any account
3. Change the URL to https://staging.new.expensify.com/onboarding/migrated-user-welcome

Expected Result:

The Migrated User Welcome Modal should be visible.

Actual Result:

Migrated User Welcome modal URL has no response

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021919413824317356860
• Upwork Job ID: 1919413824317356860
• Last Price Increase: 2025-05-05
• Automatic offers:
• huult | Contributor | 107275018

Issue Owner

Current Issue Owner: @francoisl

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@slafortune Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021919413824317356860

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Migrated User Welcome" modal URL has no response

What is the root cause of that problem?

This condition prevents the Migrated User Welcome modal from being displayed. It redirects to lastVisitedPath if the user accesses onboarding/migrated-user-welcome after isOnboardingCompleted and authenticated are both true.

App/src/libs/Navigation/NavigationRoot.tsx

Lines 110 to 112 in 094bc6a

	if (path?.includes(ROUTES.MIGRATED_USER_WELCOME_MODAL) && lastVisitedPath && isOnboardingCompleted && authenticated) {
	return getAdaptedStateFromPath(lastVisitedPath, linkingConfig.config);
	}

What changes do you think we should make in order to solve the problem?

To resolve this issue, we just need to navigate to the Migrated User Welcome modal after accessing onboarding/migrated-user-welcome, while keeping the initial route as lastVisitedPath to preserve the exact last page.

1 we navigate to the Migrated User Welcome modal after accessing onboarding/migrated-user-welcome,

App/src/libs/Navigation/NavigationRoot.tsx

Lines 110 to 112 in 094bc6a

	if (path?.includes(ROUTES.MIGRATED_USER_WELCOME_MODAL) && lastVisitedPath && isOnboardingCompleted && authenticated) {
	return getAdaptedStateFromPath(lastVisitedPath, linkingConfig.config);
	}

update to

  if (path?.includes(ROUTES.MIGRATED_USER_WELCOME_MODAL) && lastVisitedPath && isOnboardingCompleted && authenticated) {
      InteractionManager.runAfterInteractions(() => { // Delay to wait until `initialState` is updated
          Navigation.navigate(ROUTES.MIGRATED_USER_WELCOME_MODAL);
      });

      return getAdaptedStateFromPath(lastVisitedPath, linkingConfig.config);
  }

2 Update condition to return to keep last page

App/src/components/MigratedUserWelcomeModal.tsx

Line 62 in 5e2a9a5

if ((hasBeenAddedToNudgeMigration && !dismissedProductTraining?.migratedUserWelcomeModal) || route?.params?.isNavigationRoot === 'true') {

update to

     if ((hasBeenAddedToNudgeMigration && !dismissedProductTraining?.migratedUserWelcomeModal) || route?.params?.isNavigationRoot === 'true') { // update this
            return;
        }

Test branch

This test branch includes all my elements to fix this issue

Screen.Recording.2025-05-06.at.12.11.00.mp4

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[allroundexperts]

@slafortune @jponikarchuk Is this a bug? If onboarding was completed, then opening this link shouldn't show the modal. Do you agree?

[huult]

@allroundexperts @slafortune @jponikarchuk I think we should be able to see the Migrated User Welcome Modal again. I want to revisit its content in case I forgot something and would like to watch it again.

[jponikarchuk]

@allroundexperts According to step 2 of this PR it should be possible to see the Migrated User Welcome Modal again.

[allroundexperts]

Okay. Given that, @huult's proposal looks good to me. Let's go with them.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @huult 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖