[Due for payment 2025-05-22] [$250] Expense - Incorrect payment amount in LHN and report when report has track & submitted expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.33-5
Reproducible in staging?: Y
Reproducible in production?: Y
**If this was caught during regression testing, add the test name, ID and lin
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Account has self DM
• Log in with Expensifail account

1. Go to staging.new.expensify.com
2. Go to self DM
3. Track a manual expense of amount RM100 (any currency)
4. Click Share it with my account
5. Click New workspace (if acccount already has workspace)
6. Enter merchant, select a category and click Create expense
7. On workspace chat, submit another expense of amount RM120 (any currency) via + menu
8. Click on the expense preview
9. Click More > Submit (if workspace has enabled delay submissions)
10. Click Pay elsewhere
11. Note that the paid system message in the expense report is "paid MYR 120.00 elsewhere", whereas LHN shows "paid MYR 220.00 elsewhere"
12. Click More > Cancel payment
13. Click Cancel payment
14. Note that the payment cancelation system message in the expense report and LHN is "canceled the MYR 220.00 payment", when RM120.00 was paid in Step 11

Expected Result:

In Step 11, the paid system message in the expense report and LHN should show "paid MYR 120.00 elsewhere"
In Step 14, the payment cancelation system message in the expense report and LHN should be "canceled the MYR 120.00 payment" because RM120.00 was paid in Step 11 (the payment button also shows Pay RM120.00 elsewhere)

Actual Result:

In Step 11, the paid system message in the expense report is "paid MYR 120.00 elsewhere", whereas LHN shows "paid MYR 220.00 elsewhere"
In Step 14, the payment cancelation system message in the expense report and LHN is "canceled the MYR 220.00 payment", when RM120.00 was paid in Step 11

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6816480_1745936374999.20250429_220556.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021917864478821489895
• Upwork Job ID: 1917864478821489895
• Last Price Increase: 2025-05-01
• Automatic offers:
• FitseTLT | Contributor | 107138473

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-29 15:17:38 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Incorrect payment amount in LHN and report when report has track & submitted expense

What is the root cause of that problem?

1. We are using total spend of the break down here for paid LHN instead of the reimbursableSpend
   

   App/src/libs/ReportUtils.ts

   Line 4188 in 62fdc63

   const totalAmount = getMoneyRequestSpendBreakdown(report).totalDisplaySpend;

2. But for the case of canceled payment we use the originalMessage.amount value
   

   App/src/libs/ReportUtils.ts

   Lines 3159 to 3160 in 62fdc63

   	const originalMessage = getOriginalMessage(reportAction);
   	const amount = originalMessage?.amount;

   
   which is wrongly set to the total value by the backend

What changes do you think we should make in order to solve the problem?

1. We should use reimbursableSpend

    const totalAmount = getMoneyRequestSpendBreakdown(report).reimbursableSpend;

but the amount is used for other types of action in the function so if needed we can use the total spend for other cases as approve here

App/src/libs/ReportUtils.ts

Lines 4196 to 4200 in 62fdc63

	if (isReportApproved({report}) && isPaidGroupPolicy(report)) {
	return translateLocal('iou.managerApprovedAmount', {
	manager: payerName ?? '',
	amount: formattedAmount,
	});

and only add a new remibursable amount variable and use it for the cases that apply like our case of pay here.
Or alternatively we can take the correct amount from the the iouAction originalMessage.amount to align with what we display in the report screen here)

2. The BE should be fixed to return the canceled payment report action's originalMessage.amount equal to reimbursable amount instead of the total. Additionally, the original message we are setting optimistically should be fixed. We should deduct the iouReport nonReimbursableAmount as we are doing for pay here
   

   App/src/libs/actions/IOU.ts

   Line 9312 in 62fdc63

   const optimisticReportAction = buildOptimisticCancelPaymentReportAction(expenseReport.reportID, -(expenseReport.total ?? 0), expenseReport.currency ?? '');

const optimisticReportAction = buildOptimisticCancelPaymentReportAction(
        expenseReport.reportID,
        -((expenseReport.total ?? 0) - (expenseReport?.nonReimbursableTotal ?? 0)),
        expenseReport.currency ?? '',
    );

But if we are ok with a FE workaround we can calculate the reimbursable amount from the iou report's break down just like we are doing here

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can make test to assert that the canceled payment action created has got the correct amount with the non-reimbursable amount deducted from the total.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021917864478821489895

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[jjcoffee]

@FitseTLT's proposal makes sense to me. We are using reimbursableSpend for the pay button's display.

App/src/components/ReportActionItem/ReportPreview.tsx

Line 204 in ae4e0d2

const {totalDisplaySpend, reimbursableSpend} = getMoneyRequestSpendBreakdown(iouReport);

App/src/components/ReportActionItem/ReportPreview.tsx

Line 306 in ae4e0d2

return convertToDisplayString(reimbursableSpend, iouReport?.currency);

We do need a BE fix for the cancelled message as well.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

Can look at the backend here, though probably not until tomorrow! Front end update sounds good too

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@dangrous Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jjcoffee]

@FitseTLT I think you can get started on the FE PR for this as it doesn't rely on BE changes.

[dangrous]

backend is merged! Not yet deployed but shouldn't be long since it's in the repo without staging.

[sonialiap]

BE has been deployed to production https://github.com/Expensify/Auth/pull/15166

[jjcoffee]

@FitseTLT Can you let us know when we can expect a PR?

[FitseTLT]

Will draft the pr today

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - Expense - Incorrect payment amount in LHN and report when report has track & submitted expense #61621

If no regressions arise, payment will be issued on 2025-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment through NewDot Manual Requests
• @FitseTLT requires payment automatic offer (Contributor)

[melvin-bot]

@jjcoffee @sonialiap @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]