-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[$250] Receipt Loading Spinners on Reports Page Are Too Large #61073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @greg-schroeder ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Receipt loading spinners on the Reports page currently appear oversized What is the root cause of that problem?The loading indicator has size App/src/components/FullscreenLoadingIndicator.tsx Lines 15 to 20 in f950eb9
What changes do you think we should make in order to solve the problem?We should define an iconSize prop on App/src/components/FullscreenLoadingIndicator.tsx Lines 15 to 20 in f950eb9
Then pass it down from here and here to here with What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?UI issue What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
|
@shawnborton Can you elaborate this part?
|
I added mockups to the "expected results" portion of the OP, that's what we want here, cc @Expensify/design for viz! |
@shawnborton The background is the same as the thumbnail image like this, right ![]() |
Correct! |
Thanks, got it. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Receipt loading spinners on the Reports page currently appear too large and are visually inconsistent with the expected design for thumbnail areas. What is the root cause of that problem?The default loading spinner rendered by the What changes do you think we should make in order to solve the problem?We should make two focused changes:
Updated <View
style={[
StyleUtils.getWidthAndHeightStyle(variables.h36, variables.w40),
StyleUtils.getBorderRadiusStyle(variables.componentBorderRadiusSmall),
styles.overflowHidden,
backgroundStyles,
styles.bgTransparent
]}
>
<ReceiptImage
...
loadingIndicatorSize="small"
/>
</View> Changes to
<ActivityIndicator
color={theme.spinner}
size={loadingIndicatorSize ?? 'large'} // default remains 'large'
/> This keeps the design consistent while offering flexibility for other usages of the What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?N/A What alternative solutions did you explore? (Optional) |
Job added to Upwork: https://www.upwork.com/jobs/~021919892449136201950 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb ( |
Based on the mockup, we need to apply transparent background to the underlying ![]() @nkdengineer proposal LGTM 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @Valforte, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Let's move forward with @nkdengineer proposal! |
📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): #Expensify Bugs
Action Performed:
Expected Result:
Default BG color fill for the thumbnail area, and use a 20x20 spinner in the middle of the thumbnail area for these
Actual Result:
Receipt loading spinners on the Reports page currently appear oversized
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Platforms Tested:
On which of our officially supported platforms was this issue tested:Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ValforteThe text was updated successfully, but these errors were encountered: