-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-05-20] [$150] Expensify Card - Limit input page shows error after incorrect magic code is entered #61051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
🚨 Edited by proposal-police: This proposal was edited at 2025-04-29 11:13:50 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Expensify Card - Limit input page shows error after incorrect magic code is entered What is the root cause of that problem?After entering the wrong magic code, the error is saved in the key Lines 746 to 755 in ca7e756
We don't add policyID as param in this command Line 469 in 3941adf
What changes do you think we should make in order to solve the problem?
Line 469 in 3941adf
API.write(WRITE_COMMANDS.RESEND_VALIDATE_CODE, {policyID}, {optimisticData, successData, failureData})
sendValidateCode={() => requestValidateCodeAction(policyID)} Note: We can check for similar errors with pages where we use What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?None What alternative solutions did you explore? (Optional) |
🚨 Edited by proposal-police: This proposal was edited at 2025-05-01 16:28:53 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Limit input page shows error - You must be a domain admin to create the virtual card. What is the root cause of that problem?We already have logics to clear error here
Lines 373 to 375 in b1fcf20
However, when validating with incorrect magic code, We don’t send ![]() So we're not clearing the correct Onyx entry and the error persists. What changes do you think we should make in order to solve the problem?
Lines 373 to 375 in b1fcf20
function clearIssueNewCardError(policyID: string | undefined) {
Onyx.merge(`${ONYXKEYS.COLLECTION.ISSUE_NEW_EXPENSIFY_CARD}${policyID}`, {errors: null});
Onyx.merge(‘issueNewExpensifyCard’, {errors: null});
} What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?I don't think we need one, because it's error when sending API. What alternative solutions did you explore? (Optional)We should pass Lines 768 to 775 in 3941adf
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
Reproduced. The error clears if you proceed past it, so it's no major impact. But it's confusing so feels worth cleaning it up. |
Job added to Upwork: https://www.upwork.com/jobs/~021917579859517676775 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 ( |
I'm not sure why BE returns the error for 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@dukenv0307 so to be clear, we could fix this either in the BE or FE, but we should probably fix it in the backend? Looks like we basically had this exact same issue a couple months ago: #56363 |
That's expected as the frontend doesn't provide a The fix needs to be frontend related. cc @blimpich |
Updated proposal |
Current assignee @blimpich is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Upwork job price has been updated to $150 |
Reducing price because Lucien basically solved this for us and the fix is just a simple parameter change. |
@mkzie2 is there an ETA for a PR? |
PR will be up in several hours. |
PR in review |
PR on staging |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-05-20. 🎊 For reference, here are some details about the assignees on this issue:
|
@dukenv0307 @joekaufmanexpensify @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
BugZero Checklist:
Bug classificationSource of bug:
Where bug was reported:
Who reported the bug:
Regression Test ProposalTest:
Do we agree 👍 or 👎 |
Will handle next steps today so we're prepped to pay tomorrow |
This is a pretty niche bug. Only applicable if you're issuing multiple cards in short succession and incorrectly enter magic code when issuing the first one. I don't think we need to have QA test this flow in every test run as it is not likely to be something commonly done by actual users. Going to skip the test for now. |
All set to pay tomorrow! We need to pay:
|
@mkzie2 $150 sent and contract ended! |
Upwork job closed. |
@dukenv0307 Please request payment at your earliest convenience. Closing as this is otherwise all set! |
$150 approved for @dukenv0307 |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.33-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings
Action Performed:
Precondition:
Expected Result:
Limit input page will not show error.
Actual Result:
Limit input page shows error - You must be a domain admin to create the virtual card.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6816046_1745907880813.20250429_141825.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @joekaufmanexpensifyThe text was updated successfully, but these errors were encountered: