[Due for payment 2025-05-20] [$250] iOS - Workspace - Unable to delete workspace, app freezes after tapping Delete workspace #61040

jponikarchuk · 2025-04-29T07:49:46Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.1.33-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Workspace Settings

Action Performed:

Launch Expensify app.
Log in with a new Gmail account.
Select Something else during onboarding and complete the flow.
Go to Account > Workspaces.
Create a new workspace.
Tap app back button to return to workspace list.
Tap 3-dot menu.
Tap Delete workspace.

Expected Result:

Confirmation modal to delete workspace will show up.

Actual Result:

Confirmation modal to delete workspace does not show up.
After tapping Delete workspace, tapping any button on the same page is not responsive.

Workaround:

Unknown

Platforms:

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021917225435968213171
Upwork Job ID: 1917225435968213171
Last Price Increase: 2025-05-06
Automatic offers:

daledah | Contributor | 107203490

Issue Owner

Current Issue Owner: @maddylewis

melvin-bot · 2025-04-29T07:49:58Z

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

daledah · 2025-04-29T12:01:46Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Confirmation modal to delete workspace does not show up.
After tapping Delete workspace, tapping any button on the same page is not responsive.

What is the root cause of that problem?

When pressing "Delete workspace", we open the Delete modal immediately without waiting for the popover menu to close. This behaviour creates a race condition where the modal Onyx values are all set to false when popover menu closes, but Delete modal still opens

So on screen, the Delete modal is not shown but the invisible overlay still exists, blocking user from interacting with any other components under.

What changes do you think we should make in order to solve the problem?

We should close the popover menu before opening delete modal

App/src/hooks/usePayAndDowngrade.ts

Line 22 in d391099

setIsDeleteModalOpen(true);

            close(() => {
                setIsDeleteModalOpen(true);
            });

Screen.Recording.2025-04-29.at.19.01.12.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

It's a modal race condition so I don't think we need a test

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

bernhardoj · 2025-04-29T12:06:21Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Can't delete workspace.

What is the root cause of that problem?

When we try to delete a workspace and shouldCalculateBillNewDot is true, it will calculate the bill first

App/src/pages/workspace/WorkspacesListPage.tsx

Lines 217 to 241 in d391099

    
               onSelected: () => { 
        
                   if (loadingSpinnerIconIndex !== null) { 
        
                       return; 
        
                   } 
        
                   if (isSupportalAction) { 
        
                       setIsSupportalActionRestrictedModalOpen(true); 
        
                       return; 
        
                   } 
        
                   setPolicyIDToDelete(item.policyID); 
        
                   setPolicyNameToDelete(item.title); 
        
                   if (shouldCalculateBillNewDot) { 
        
                       setIsDeletingPaidWorkspace(true); 
        
                       calculateBillNewDot(); 
        
                       setLoadingSpinnerIconIndex(index); 
        
                       return; 
        
                   } 
        
                   setIsDeleteModalOpen(true); 
        
               }, 
        
               shouldKeepModalOpen: shouldCalculateBillNewDot, 
        
               shouldCallAfterModalHide: !shouldCalculateBillNewDot, 
        
           });

Only after the calculate bill completes, we close the current modal,

App/src/pages/workspace/WorkspacesListRow.tsx

Lines 134 to 144 in d391099

    
           useEffect(() => { 
        
               if (isLoadingBill) { 
        
                   return; 
        
               } 
        
               resetLoadingSpinnerIconIndex?.(); 
        
               if (!threeDotsMenuRef.current?.isPopupMenuVisible) { 
        
                   return; 
        
               } 
        
               threeDotsMenuRef?.current?.hidePopoverMenu(); 
        
           }, [isLoadingBill, resetLoadingSpinnerIconIndex]);

and then show the delete confirm modal.

App/src/hooks/usePayAndDowngrade.ts

Lines 16 to 22 in d391099

    
           useEffect(() => { 
        
               if (!isDeletingPaidWorkspaceRef.current || isLoadingBill) { 
        
                   return; 
        
               } 
        
               if (!shouldBillWhenDowngrading) { 
        
                   setIsDeleteModalOpen(true);

However, on iOS, if we want to show a modal from another modal, we need to wait for the previous modal to close first. That's why we have the shouldCallAfterModalHide. We set it to false if shouldCalculateBillNewDot is true, because we don't want to close the modal yet until the calculation is complete.

What changes do you think we should make in order to solve the problem?

To fix this, after completing the calculation, we need to close the previous modal first using Modal.close.

We can add it into usePayAndDowngrade hook.

close(() => setIsDeleteModalOpen(true));

We can optionally do it using a props because usePayAndDowngrade is used in overview page too which doesn't need it.

Or to make it cleaner, we can update the setIsDeleteModalOpen props to be a calculate complete callback, but doesn't need pay when downgrading. So, we can use it like:

const showDeleteModal = useCallback(() => {
    close(() => setIsDeleteModalOpen(true));
}, []);
const {...} = usePayAndDowngrade(showDeleteModal);

Then, we can remove the modal hide from here.

App/src/pages/workspace/WorkspacesListRow.tsx

Lines 134 to 144 in d391099

    
           useEffect(() => { 
        
               if (isLoadingBill) { 
        
                   return; 
        
               } 
        
               resetLoadingSpinnerIconIndex?.(); 
        
               if (!threeDotsMenuRef.current?.isPopupMenuVisible) { 
        
                   return; 
        
               } 
        
               threeDotsMenuRef?.current?.hidePopoverMenu(); 
        
           }, [isLoadingBill, resetLoadingSpinnerIconIndex]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

github-actions · 2025-04-29T12:06:41Z

⚠️ @bernhardoj Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

melvin-bot · 2025-04-29T14:32:21Z

Job added to Upwork: https://www.upwork.com/jobs/~021917225435968213171

melvin-bot · 2025-04-29T14:32:26Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

melvin-bot · 2025-05-05T09:21:19Z

@shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

shubham1206agra · 2025-05-06T05:13:52Z

@daledah's proposal looks good to me.

🎀👀🎀 C+ reviewed

melvin-bot · 2025-05-06T05:14:09Z

Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

bernhardoj · 2025-05-06T13:14:02Z

Any thoughts on my proposal? I think I provided a more complete proposal.

shubham1206agra · 2025-05-06T14:06:20Z

Your changes was optional, and I don't think it was that critical. So I chose the first proposal in line.

melvin-bot · 2025-05-06T16:00:05Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

neil-marcellini · 2025-05-06T19:52:43Z

@daledah's proposal looks good to me.

🎀👀🎀 C+ reviewed

Agreed, hiring

melvin-bot · 2025-05-06T19:53:01Z

📣 @daledah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

daledah · 2025-05-07T08:46:25Z

@shubham1206agra PR is ready.

maddylewis · 2025-05-13T13:33:10Z

@shubham1206agra - plz review @daledah 's PR when you have a chance - ty!

shubham1206agra · 2025-05-13T13:54:24Z

@maddylewis PR is on staging

melvin-bot · 2025-05-13T17:57:53Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2025-05-13T17:57:59Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Unable to delete workspace, app freezes after tapping Delete workspace #61561

If no regressions arise, payment will be issued on 2025-05-20. 🎊

For reference, here are some details about the assignees on this issue:

@shubham1206agra requires payment through NewDot Manual Requests
@daledah requires payment automatic offer (Contributor)

melvin-bot · 2025-05-13T17:58:01Z

@shubham1206agra @maddylewis @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

maddylewis · 2025-05-20T17:00:37Z

maddylewis · 2025-05-20T17:01:18Z

Payments + Final To-Dos

@shubham1206agra requires payment through NewDot Manual Requests - $250
@daledah requires payment automatic offer (Contributor) - $250
Regression test GH

shubham1206agra · 2025-05-20T17:08:05Z

jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Apr 29, 2025

melvin-bot bot assigned maddylewis Apr 29, 2025

maddylewis added the External Added to denote the issue can be worked on by a contributor label Apr 29, 2025

melvin-bot bot changed the title ~~iOS - Workspace - Unable to delete workspace, app freezes after tapping Delete workspace~~ [$250] iOS - Workspace - Unable to delete workspace, app freezes after tapping Delete workspace Apr 29, 2025

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 29, 2025

melvin-bot bot assigned shubham1206agra Apr 29, 2025

nlemma mentioned this issue May 2, 2025

ios hybrid - No delete modal displayed when user attempt to delete WS #61323

Closed

8 tasks

melvin-bot bot added the Overdue label May 5, 2025

melvin-bot bot removed the Overdue label May 6, 2025

melvin-bot bot assigned neil-marcellini May 6, 2025

neil-marcellini assigned daledah May 6, 2025

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 6, 2025

daledah mentioned this issue May 7, 2025

fix: Unable to delete workspace, app freezes after tapping Delete workspace #61561

Merged

51 tasks

melvin-bot bot added Reviewing Has a PR in review and removed Daily KSv2 labels May 7, 2025

melvin-bot bot added the Weekly KSv2 label May 7, 2025

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 13, 2025

melvin-bot bot changed the title ~~[$250] iOS - Workspace - Unable to delete workspace, app freezes after tapping Delete workspace~~ [Due for payment 2025-05-20] [$250] iOS - Workspace - Unable to delete workspace, app freezes after tapping Delete workspace May 13, 2025

melvin-bot bot removed the Reviewing Has a PR in review label May 13, 2025

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 20, 2025

shubham1206agra mentioned this issue May 20, 2025

create pay and downgrade rhp #59070

Merged

50 tasks

maddylewis closed this as completed May 20, 2025

[Due for payment 2025-05-20] [$250] iOS - Workspace - Unable to delete workspace, app freezes after tapping Delete workspace #61040

[Due for payment 2025-05-20] [$250] iOS - Workspace - Unable to delete workspace, app freezes after tapping Delete workspace #61040

Comments

jponikarchuk commented Apr 29, 2025 • edited by melvin-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Apr 29, 2025

Uh oh!

daledah commented Apr 29, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Uh oh!

bernhardoj commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

melvin-bot bot commented Apr 29, 2025

Uh oh!

melvin-bot bot commented Apr 29, 2025

Uh oh!

melvin-bot bot commented May 5, 2025

Uh oh!

shubham1206agra commented May 6, 2025

Uh oh!

melvin-bot bot commented May 6, 2025

Uh oh!

bernhardoj commented May 6, 2025

Uh oh!

shubham1206agra commented May 6, 2025

Uh oh!

melvin-bot bot commented May 6, 2025

Uh oh!

neil-marcellini commented May 6, 2025

Uh oh!

melvin-bot bot commented May 6, 2025

Uh oh!

daledah commented May 7, 2025

Uh oh!

maddylewis commented May 13, 2025

Uh oh!

shubham1206agra commented May 13, 2025

Uh oh!

melvin-bot bot commented May 13, 2025

Uh oh!

melvin-bot bot commented May 13, 2025

Uh oh!

melvin-bot bot commented May 13, 2025

Uh oh!

maddylewis commented May 20, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Uh oh!

maddylewis commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Payments + Final To-Dos

Uh oh!

shubham1206agra commented May 20, 2025 • edited by maddylewis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BugZero Checklist:

Regression Test Proposal

Test:

Uh oh!

jponikarchuk commented Apr 29, 2025 •

edited by melvin-bot bot

Loading

bernhardoj commented Apr 29, 2025 •

edited

Loading

maddylewis commented May 20, 2025 •

edited

Loading

shubham1206agra commented May 20, 2025 •

edited by maddylewis

Loading