[$250] Update all references from "workspace chat" to "expense chat"

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation (hyperlinked to channel name): #Quality

Action Performed:

1. Admin removes approver from the workspace chat
2. System message appears to the Approver

Expected Result:

All references should consistently say "expense chat" instead of "workspace chat."

Actual Result:

Removed you from xxx's approval workflow and workspace chat. Previously submitted.... whisper message displayed
Copy "Workspace chat" is not updated as "Expense chat"

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021917225274770505798
• Upwork Job ID: 1917225274770505798
• Last Price Increase: 2025-04-29

Issue Owner

Current Issue Owner: @luacmartins

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update all references from "workspace chat" to "expense chat"

What is the root cause of that problem?

• Translation update

What changes do you think we should make in order to solve the problem?

• Update the translations in both en.ts and es.ts files.
  

  App/src/languages/en.ts

  Lines 5106 to 5112 in b7df6b6

  	return {
  	one: `removed you from ${joinedNames}'s approval workflow and workspace chat. Previously submitted reports will remain available for approval in your Inbox.`,
  	other: `removed you from ${joinedNames}'s approval workflows and workspace chats. Previously submitted reports will remain available for approval in your Inbox.`,
  	};
  	},
  	demotedFromWorkspace: ({policyName, oldRole}: DemotedFromWorkspaceParams) =>
  	`updated your role in ${policyName} from ${oldRole} to user. You have been removed from all submitter workspace chats except for you own.`,

• We might don't need to update demotedFromWorkspace translation, but that can be confirmed later.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A - Translation update

What alternative solutions did you explore? (Optional)

N/A

Result

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update all references from "workspace chat" to "expense chat"

What is the root cause of that problem?

Copy update

What changes do you think we should make in order to solve the problem?

We need to update ALL references of "workspace chat" that users can see to "expense chat".

1. In en.ts and es.ts here
2. In our help docs for example here, here and several other places
3. From the engineers perspective we might want to use "workspace chat" and "expense chat" interchangeably. If so, we can optionally add a note in README.md for that to avoid misunderstandings.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021917225274770505798

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[rojiphil]

2. In our help docs for example here, here and several other places

@mkzie2 The statement seems to be quite generic. Can you please be more specific as to what needs to change in help docs?

[mkzie2]

@rojiphil I meant to update all instances of "workspace chat" to "expense chat" in help docs. Sorry since I linked code permalink so if you opened the markdown preview, you wouldn't see the highlighted line. You need to open Code mode.

[rojiphil]

Thanks for all the proposals
@mkzie2 proposal LGTM. Along with the translations in en/es.ts files, we can also update the help docs accordingly.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Krishna2323]

@rojiphil, thanks for the review! However, I think we should first confirm whether we want to update the documentation at all before selecting a proposal. I'm fairly certain that this change is only intended for the translations copy. The OP seems to clearly refer to system messages, and in the documentation, I believe it makes more sense to continue calling it "Workspace chat" instead of "Expense chat.

@puneetlath, could you please help confirm that? Thanks!

App/docs/articles/new-expensify/connections/quickbooks-desktop/QuickBooks-Desktop-Troubleshooting.md

Line 83 in 4453806

These errors usually generate a system message in Workspace Chat indicating the issue.

App/docs/articles/new-expensify/connections/quickbooks-desktop/QuickBooks-Desktop-Troubleshooting.md

Line 123 in 4453806

3. Check Workspace Chat in Expensify to confirm successful export.

Removed you from xxx's approval workflow and workspace chat. Previously submitted.... whisper message displayed
Copy "Workspace chat" is not updated as "Expense chat"

System message appears to the Approver

[puneetlath]

We are not using the "workspace chat" terminology anymore, so it shouldn't be anywhere in the product or the documentation. This is now referred to as an "expense chat" for a given user.

[mkzie2]

@luacmartins Can you assign me so I can start working on PR?

[melvin-bot]

@luacmartins Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

❌ There was an error making the offer to @mkzie2 for the Contributor role. The BZ member will need to manually hire the contributor.

[luacmartins]

Ah yes, sorry! I thought I had done that already. All yours.

[mkzie2]

@luacmartins @puneetlath One thing to confirm: Do we want to update the instances of "workspace chat" in our developer/code documentation as well? For example:

App/README.md

Lines 700 to 703 in 100d5ed

	- Admins are not able to leave/be removed from the workspace chat
	- Default members(automatically invited) are not able to leave/be removed from the workspace chat
	- Invited members(invited by members) are not able to invite or remove from the workspace chat
	- Invited members(invited by members) are able to leave the workspace chat

App/contributingGuides/NAVIGATION_TESTS.md

Line 142 in 95ec76c

3. Submit a manual expense to any user (as long as the user is not the currently opened report and the receiver is not workspace chat).

App/src/components/MoneyRequestConfirmationList.tsx

Line 157 in 1dac52e

/** A flag for verifying that the current report is a sub-report of a workspace chat */

App/src/libs/actions/Report.ts

Line 5096 in 3ed638b

// Update the workspace chat report

[puneetlath]

I say yes, let's update it everywhere. That'll make it less likely that it accidentally sneaks back into the product.