[Due for payment 2025-05-22] [$250] Error messages not displayed consistently for invalid receipt

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.31-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Create an expense with a receipt
2. Replace this receipt with an invalid receipt
3. Note that: Error message is displayed below the receipt
4. Delete this receipt
5. Choose an invalid receipt
6. Note that: Error message is displayed above the receipt

Expected Result:

Error messages should be displayed consistently.

Actual Result:

Error messages not displayed consistently.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

inconsistent-error.mp4

Recording.1154.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021917323761405300915
• Upwork Job ID: 1917323761405300915
• Last Price Increase: 2025-04-29

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

Proposal by @dukenv0307

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error messages should be displayed inconsistently.

What is the root cause of that problem?

In case we have the receipt and replace this receipt with an invalid receipt we'll show error message and the recipt here

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 521 to 525 in 838784b

	{(hasReceipt || !!errors) && (
	<OfflineWithFeedback
	pendingAction={isDistanceRequest ? getPendingFieldAction('waypoints') : getPendingFieldAction('receipt')}
	errors={errors}
	errorRowStyles={[styles.mh4]}

In case we don't have receipt, we'll display the error message here

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 524 in 838784b

errors={errors}

and display the empty receipt below

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 561 to 563 in 838784b

	{shouldShowReceiptEmptyState && (
	<OfflineWithFeedback pendingAction={getPendingFieldAction('receipt')}>
	<ReceiptEmptyState

What changes do you think we should make in order to solve the problem?

In case we want to show error message below the receipt, we should move empty receipt code block to above this block

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 521 to 525 in 838784b

	{(hasReceipt || !!errors) && (
	<OfflineWithFeedback
	pendingAction={isDistanceRequest ? getPendingFieldAction('waypoints') : getPendingFieldAction('receipt')}
	errors={errors}
	errorRowStyles={[styles.mh4]}

In case show error message above receipt, we can add props shouldDisplayErrorAbove here

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 522 in 838784b

<OfflineWithFeedback

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

[melvin-bot]

@johncschuster Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021917323761405300915

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[johncschuster]

I agree this is a bug in that the location of the error message is inconsistent. @Expensify/design where is the error message supposed to be here?

[dubielzyk-expensify]

Yeah, this looks weird to me:

The error that's below the receipt thumbnail looks right to me. cc @shawnborton for gut check

[shawnborton]

Yup, I agree with that. We should keep it below the receipt.

[eVoloshchak]

Seems pretty straightforward, @dukenv0307's proposal looks good to me!

We should keep it below the receipt

🎀👀🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@rlinoz @johncschuster @eVoloshchak @dukenv0307 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Error messages not displayed consistently for invalid receipt #61467

If no regressions arise, payment will be issued on 2025-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @dukenv0307 requires payment through NewDot Manual Requests

[melvin-bot]

@eVoloshchak / @dukenv0307 @johncschuster @eVoloshchak / @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[johncschuster]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[johncschuster]

Payment Summary (to be issued after regression window has passed)

Contributor: @dukenv0307 owed $250 via NewDot
Contributor+: @eVoloshchak owed $250 via NewDot