-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[$250][HIGH] Android - Try it out button is not functional in scan tab #60634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @adelekennedy ( |
@adelekennedy Eep! 4 days overdue now. Issues have feelings too... |
Job added to Upwork: https://www.upwork.com/jobs/~021917343972744005666 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.In the Scan tab tooltip, the "Try it out" button is not functional. When users click it, nothing happens — the test receipt is not loaded, and they are not navigated to the Create Expense page as expected. What is the root cause of that problem?After reviewing the code, the issue likely lies in the Specifically:
What changes do you think we should make in order to solve the problem?To address this issue, I propose updating
These changes ensure a more stable experience across all supported Android versions, especially Android 13 and above. What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?While this is largely platform-specific, we can add the following tests:
|
@suneox , @adelekennedy , are you able to reproduce? I started this as HIGH status, it seems like ALL new users might encounter this, so we should likely prioritize trying to get it fixed. I'll stay subscribed and update if/when needed. @suneox please review the proposal above. |
I can reproduce this issue on Android 11.
@Raven13111 The root cause you provided is not sufficiently evidenced and convincing. We need a clear identification of the root cause first before proceeding to a solution.
Currently, we can access the logs by navigating to Settings > Troubleshoot and enabling Client-side Logging. |
{ |
@Raven13111 It makes sense now that we have a log. I’ll verify your solution as soon as the build is complete. Could you please provide the test branch? ![]() |
https://github.com/Raven13111/App/tree/test-receipt-loading |
No, we just need to follow the contributor guidelines App/contributingGuides/CONTRIBUTING.md Line 154 in 6155e9a
|
Welcome @Raven13111. Per the Upwork job .
|
@suneox Whoops! This issue is 2 days overdue. Let's get this updated quick! |
We're still looking proposal for this one, i've posted to slack to get more eyes? |
@suneox @adelekennedy this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@suneox Whoops! This issue is 2 days overdue. Let's get this updated quick! |
🚨 Edited by proposal-police: This proposal was edited at 2025-05-11 03:22:12 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Android - Try it out button is not functional in scan tab What is the root cause of that problem?The root cause is the same as in #59953 #59470 the onPress event is flaky on Android devices, which causes the button inside the tooltip to not trigger reliably when tapped. What changes do you think we should make in order to solve the problem?Since this is a App/src/components/ProductTrainingContext/index.tsx Lines 330 to 335 in 81b1b49
<Button
success
text={translate('productTrainingTooltip.scanTestTooltip.tryItOut')}
style={[styles.flex1]}
onPressIn={
getPlatform() === CONST.PLATFORM.ANDROID
? () => {
config.onConfirm?.();
}
: undefined
}
// For other platforms, we stick with `onPress`.
onPress={
getPlatform() !== CONST.PLATFORM.ANDROID
? () => {
config.onConfirm?.();
}
: undefined
}
/>
// Apply same fix for onDismiss button For a cleaner solution, we can extract this platform-specific logic into an index.android.ts and index.ts file to avoid cluttering the component code with conditional checks. What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?N/A What alternative solutions did you explore? (Optional)Instead of using We can follow a similar pattern to what we implemented in the Note I prefer this alternative solution—it's more consistent with how similar interactions are handled elsewhere |
@linhvovan29546 Thank you for your proposal, but it looks like the original PR was also closed to continue the investigation |
@suneox The original issue was fixed here #59577 You can also refer to the QA's comment. #59557 (comment) |
The workaround proposal from @linhvovan29546 LGTM, we can proceed with it for this high-priority issue, similar to the fix for #59470 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
cc @grgia since this seems to affect the testing receipt functionality |
cc @grgia ^ #60634 (comment) |
It looks like the proposed fix for the 'x' button never got merged: #59557, why is that? Is this issue consistently reproducible? |
@aldo-expensify #60634 (comment) Please check this, we have two PR |
ahh, I missed that, thanks for point it out |
📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @linhvovan29546 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Note: I’m currently unable to build the iOS app after merging main. I’ll create the PR once I’ve resolved the issue |
PR is ready for review! ^ cc @suneox |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.1.31-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #60307
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Tecno Spark 20/ Android 13
App Component: Money Requests
Action Performed:
Expected Result:
User is navigated to create expense with a test receipt
Actual Result:
Try it out button is not functional and user is not navigated to create expense with a test receipt.
Workaround:
Unknown
Platforms:
Screenshots/Videos
1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @aldo-expensifyThe text was updated successfully, but these errors were encountered: