[Due for payment 2025-05-20] [$250] Workspace - Bank address suggestion modal isn't showing

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check in Production, it asks to update the currency to USD.
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #56931
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, macOS Sequoia 15.3
App Component: Workspace Settings

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with a new Expensifail account
3. Create a workspace with "EUR" default currency
4. Navigate to Workspace settings - Workflows - Connect bank account - Connect manually
5. Select "Croatia" as the Country
6. Click on the "Confirm" button
7. Input any number or letters to the "Bank Address" field that would normally trigger an auto suggestion

Expected Result:

Bank address suggestion modal should be visible.

Actual Result:

Bank address suggestion modal isn't showing.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021917342205783621702
• Upwork Job ID: 1917342205783621702
• Last Price Increase: 2025-04-29

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank address suggestion modal doesn't show.

What is the root cause of that problem?

We render all the field as a TextInput,

App/src/pages/ReimbursementAccount/NonUSD/BankInfo/subSteps/BankAccountDetails.tsx

Lines 79 to 91 in 7a42c6a

	return bankAccountDetailsFields?.map((field) => {
	if (field.valueSet !== undefined) {
	return getInputForValueSet(field, String(defaultValues[field.id as keyof typeof defaultValues]), isEditing, styles);
	}
	return (
	<View
	style={styles.mb6}
	key={field.id}
	>
	<InputWrapper
	InputComponent={TextInput}
	inputID={field.id}

It's the same with account holder details too.

What changes do you think we should make in order to solve the problem?

We can use the same approach as in BankInformation.

App/src/pages/settings/Wallet/InternationalDepositAccount/substeps/BankInformation.tsx

Lines 20 to 31 in 7a42c6a

	function getInputComponent(field: CorpayFormField) {
	if ((field.valueSet ?? []).length > 0) {
	return ValuePicker;
	}
	if (CONST.CORPAY_FIELDS.SPECIAL_LIST_REGION_KEYS.includes(field.id)) {
	return ValuePicker;
	}
	if (CONST.CORPAY_FIELDS.SPECIAL_LIST_ADDRESS_KEYS.includes(field.id)) {
	return AddressSearch;
	}
	return TextInput;
	}

First, create the getInputComponent function in both BankAccountDetails and AccountHolderDetails.

App/src/pages/ReimbursementAccount/NonUSD/BankInfo/subSteps/BankAccountDetails.tsx

Lines 89 to 97 in 7a42c6a

	<InputWrapper
	InputComponent={TextInput}
	inputID={field.id}
	label={field.label}
	aria-label={field.label}
	role={CONST.ROLE.PRESENTATION}
	shouldSaveDraft={!isEditing}
	defaultValue={String(defaultValues[field.id as keyof typeof defaultValues]) ?? ''}
	/>

Next, limit the address search to the selected country and map the id to the correct one.

For BankAccountDetails, we can get the country from reimbursementAccountDraft and map the input id as below.

limitSearchesToCountry={reimbursementAccountDraft?.['country']}
renamedInputKeys={{
    street: 'bankAddressLine1',
    city: 'bankCity',
}}

For AccountHolderDetails, we can get the country from defaultValues and map the input id as below.

limitSearchesToCountry={defaultValues['accountHolderCountry']}
renamedInputKeys={{
    street: 'accountHolderAddress1',
    city: 'accountHolderCity',
}}

(we can optionally map the other input to empty string)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

@adelekennedy Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021917342205783621702

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[mallenexpensify]

Select "Croatia" as the Country

Starting this as LOW status cuz I'm thinking/hoping it's an edge case. If we find it's not, bump to HIGH and/or tag me. Thx

[thesahindia]

@bernhardoj's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@thienlnam @adelekennedy @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[bernhardoj]

PR is ready

cc: @thesahindia

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show address autocomplete on the bank and account holder details #61589

If no regressions arise, payment will be issued on 2025-05-20. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment through NewDot Manual Requests
• @thesahindia requires payment through NewDot Manual Requests

[melvin-bot]

@thesahindia @adelekennedy @thesahindia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @bernhardoj owed $250 via NewDot
• Reviewer: @thesahindia owed $250 via NewDot

BugZero Checklist (@adelekennedy)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1917342205783621702/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[adelekennedy]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[adelekennedy]

The payment summary above is correct - adding the checklist above @thesahindia!

[bernhardoj]

Requested in ND.