Android & iOS hybrid - Login - "Welcome to Expensify" modal is missing video

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.29-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User has created a new account on staging.new.expensify.com and has not signed into hybrid app

1. Launch Expensify app
2. Log in with the new account created on web app for the first time

Expected Result:

"Welcome to Expensify" modal will show the video

Actual Result:

"Welcome to Expensify" modal is missing video

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6805283_1744908253206.Screen_Recording_20250418_004043_Expensify.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcaaron]

I'm not able to get this video to show up at all. Will check the preconditions.

[marcaaron]

Hmm so this is the logic for showing this modal...

App/src/hooks/useOnboardingFlow.ts

Lines 37 to 70 in 10fbf03

	InteractionManager.runAfterInteractions(() => {
	if (isLoadingApp !== false) {
	return;
	}
	if (isLoadingOnyxValue(isOnboardingCompletedMetadata, tryNewDotdMetadata, dismissedProductTrainingMetadata)) {
	return;
	}
	if (CONFIG.IS_HYBRID_APP && isLoadingOnyxValue(isSingleNewDotEntryMetadata)) {
	return;
	}
	if (hasBeenAddedToNudgeMigration && !isProductTrainingElementDismissed('migratedUserWelcomeModal', dismissedProductTraining)) {
	const defaultCannedQuery = buildCannedSearchQuery();
	const query = defaultCannedQuery;
	Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query}));
	Navigation.navigate(ROUTES.MIGRATED_USER_WELCOME_MODAL);
	return;
	}
	if (hasBeenAddedToNudgeMigration) {
	return;
	}
	if (CONFIG.IS_HYBRID_APP) {
	// For single entries, such as using the Travel feature from OldDot, we don't want to show onboarding
	if (isSingleNewDotEntry) {
	return;
	}
	// When user is transitioning from OldDot to NewDot, we usually show the explanation modal
	if (isHybridAppOnboardingCompleted === false) {
	Navigation.navigate(ROUTES.EXPLANATION_MODAL_ROOT);
	}

Lots of conditions there. I am not too sure what state an account needs to be in to get this modal to appear.

[marcaaron]

Was able to repro with expensifail.com account. There's lots of logs but this sticks out to me:

E/AVManager(25355): Cannot install JSI bindings for AV module because JS context is not available

I think that's coming from ExpoAV? This PR seems like a potential culprit: #59896

[marcaaron]

@JakubKorytko @mountiny @DylanDylann Can you look at this please?

[marcaaron]

Ok this was somehow caused by #60078 I can't tell exactly how so going to revert.

[marcaaron]

We CP'd a fix for this. Asked for a re-test.

[kavimuru]

@marcaaron bug is not reproducible

2025-04-18.8.01.58.AM.mp4