Skip to content

[Due for payment 2025-04-28] [Due for payment 2025-04-25] [Test Drive][Phase 1] Implement the Test Drive modal #60040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danieldoglas opened this issue Apr 10, 2025 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 NewFeature Something to build that is a new item.

Comments

@danieldoglas
Copy link
Contributor

Implement this part of the design doc

Copy link

melvin-bot bot commented Apr 10, 2025

Triggered auto assignment to @OfstadC (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 10, 2025
@danieldoglas
Copy link
Contributor Author

We're working with an Agency here, so I don't thing we need anyone from the BZ team for now!

@pac-guerreiro
Copy link
Contributor

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Apr 11, 2025
@pac-guerreiro
Copy link
Contributor

@danieldoglas @fabioh8010 The PR is ready for review!

@eh2077
Copy link
Contributor

eh2077 commented Apr 14, 2025

@danieldoglas I was assigned to review the PR, can I get accessed to design doc please? Thanks

@danieldoglas
Copy link
Contributor Author

pinged @eh2077 to provide me his email 1:1

@pac-guerreiro
Copy link
Contributor

The PR is finally merged! Thanks! 😄

Copy link

melvin-bot bot commented Apr 17, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 18, 2025
@melvin-bot melvin-bot bot changed the title [Test Drive][Phase 1] Implement the Test Drive modal [Due for payment 2025-04-25] [Test Drive][Phase 1] Implement the Test Drive modal Apr 18, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 18, 2025
Copy link

melvin-bot bot commented Apr 18, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 18, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-25. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 18, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@fabioh8010 / @pac-guerreiro] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 21, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-04-25] [Test Drive][Phase 1] Implement the Test Drive modal [Due for payment 2025-04-28] [Due for payment 2025-04-25] [Test Drive][Phase 1] Implement the Test Drive modal Apr 21, 2025
Copy link

melvin-bot bot commented Apr 21, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.30-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-28. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 21, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@fabioh8010 / @pac-guerreiro] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Apr 25, 2025
Copy link

melvin-bot bot commented Apr 28, 2025

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Copy link

melvin-bot bot commented Apr 28, 2025

@danieldoglas, @fabioh8010, @pac-guerreiro Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@eh2077
Copy link
Contributor

eh2077 commented Apr 29, 2025

@danieldoglas I helped review PR #60485. Can you help assign a BZ team member to add payment summary please? Thank you

@danieldoglas
Copy link
Contributor Author

Sorry Eric, assigning a BZ so you can get paid.

@danieldoglas danieldoglas added the Bug Something is broken. Auto assigns a BugZero manager. label Apr 29, 2025
Copy link

melvin-bot bot commented Apr 29, 2025

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@laurenreidexpensify
Copy link
Contributor

Payment Summary

C+ Review @eh2077 $250 can request in New Expensify

@melvin-bot melvin-bot bot added the Overdue label May 5, 2025
@danieldoglas
Copy link
Contributor Author

Payment being processed.

@JmillsExpensify
Copy link

$250 approved for @eh2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 NewFeature Something to build that is a new item.
Projects
Development

No branches or pull requests

7 participants