[Due for payment 2025-04-28] [Due for payment 2025-04-25] Onboarding - Infinite Loading when logging in by adding a existing private domain

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.29-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54186
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Chat Report View

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new Gmail account.
3. Enter a private domain email address that already exists > validate.
4. Finish the onboarding flow.

Expected Result:

No infinite loading on the chat

Actual Result:

Infinite loading on the chat

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6804452_1744850762163.Screen_Recording_2025-04-17_at_3.27.31_at_night.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[allgandalf]

@mollfpr are you able to reproduce this one?, i tested and can’t

[mollfpr]

Checking 👀

[mollfpr]

@allgandalf I can reproduce the issue. You must use an email with a private domain that has already been validated previously.

Screen.Recording.2025-04-17.at.22.35.08.mp4

After I refresh the page, it will show the Concierge report from the merged account.

[blimpich]

So there is a workaround, refreshing the page, which fixes the issue at least. Weird bug though 🐛

[blimpich]

I don't see any obvious errors coming from the backend that would cause this, so I suspect this will be a frontend fix, but still very strange.

[allgandalf]

Checking now

[ikevin127]

↪ Looking at this video seems like the OpenApp API call right after the MergeIntoAccountAndLogin API call is what's causing the infinite loading for some reason, on a previously loaded Concierge report.

[allgandalf]

okay, i get this one, the reportID of the concierge is still that of the old public email, on FE we need to update to save the report ID of the new concierge chat!, looking at that logic now!

[allgandalf]

Alright, what happened here was that:

Originally we do not pass any reportID to navigateAfterOnboarding function.

• If we have missing reportID, it will either navigate to:
  • deep-linked report (if we open via a link)
  • open the last accessed report

Now the last accessed report in this case was the concierge report of the old (public email) account, but the new (work email) account no longer has access to the old accounts concierge chat. This causes the infinite loading spinning!

To fix it, we pass the concierge chat reportID to navigateAfterOnboarding so that we navigate to the concierge chat of the new (work email) account in case a user merges their public and work emails. 👍

[blimpich]

Nice job figuring that out!

[blimpich]

Fix is CP-ed to staging, asking for retest

[kavimuru]

Reproducible in 9.1.29-9

Screen.Recording.2025-04-18.at.7.34.16.AM.mov

[allgandalf]

@kavimuru i think this now has to do with the layout changing, the navigation bar changed it’s position from the bottom to left, so i guess this is only reproducible for accounts on that beta and real users won’t face this, as @ikevin127 and i both were able to see concierge chat with latests changes!

[ikevin127]

Yeah, I wanted to mention the new app layout update and most likely it's a regression from there - not related to private domain onboarding.

[mollfpr]

Screen.Recording.2025-04-18.at.10.03.06.mp4

I confirm the issue is fixed. @kavimuru Could you retest with private domain without beta?

[IuliiaHerets]

QA team checked with a private domain without beta, but the flow is stuck. Add work email button is loaded, and doesn't work

bandicam.2025-04-18.10-26-42-453.mp4

[allgandalf]

@IuliiaHerets, from the video i can see that you are facing this issue, it's a know BE bug, what you need to do is that once you enter a email, please complete that onboarding flow, then signup again with a different email, don't change the work email twice on the same screen. can you please retest this way and confirm if the bug has been fixed

[IuliiaHerets]

@allgandalf I checked with another temporary email and it works well

bandicam.2025-04-18.10-59-02-621.mp4

[allgandalf]

nice, @mollfpr good to close then!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging]: Infinite Loading when logging in by adding a existing private domain  #60461

If no regressions arise, payment will be issued on 2025-04-25. 🎊

[melvin-bot]

@mollfpr @greg-schroeder @mollfpr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.30-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging]: Infinite Loading when logging in by adding a existing private domain  #60461

If no regressions arise, payment will be issued on 2025-04-28. 🎊

[melvin-bot]

@mollfpr @greg-schroeder @mollfpr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]