[Due for payment 2025-05-30] [$250] Hybrid - The app log out the Gmail account after enter MC when adding copilot

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.28-13
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #60128
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 12 / iOS 17.7.2
App Component: User Settings

Action Performed:

1. Log in to the Hybrid app with a brand new Gmail account
2. Tap on the Join button
3. Select any onboarding
4. Tap on the Settings
5. Tap on the Security
6. Tap on the Add copilot
7. Enter a valid account
8. Select any option
9. Tap on the Add copilot button
10. Enter the MC

Expected Result:

The app returns to the Security page with the added copilot

Actual Result:

The app log out of the user

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6803495_1744795200991.Copilot.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021913224811608693711
• Upwork Job ID: 1913224811608693711
• Last Price Increase: 2025-05-02

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ashuvssut]

Not reproducible on Android: Standalone or iOS: Standalone.
This issue likely exists only on Android: HybridApp and iOS: HybridApp, which we, as external contributors, cannot access or debug since we only have access to build standalone app

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021913224811608693711

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[huult]

Do we have a plan to grant contributor access to the Hydrid app?

[melvin-bot]

@akinwale Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@akinwale Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hybrid - The app log out the Gmail account after enter MC when adding copilot

What is the root cause of that problem?

The API command AddDelegate returns 407 error when a non-validated account tries to add a new copilot account

In Hybrid, App will try to renew the access token, but unsuccessfully, and thus redirect to sign-in page

What changes do you think we should make in order to solve the problem?

We should require a new user account to validate their account first before they can add their Copilot account. Same with this PR #59454. We can introduce either HOC or Wrapper to be reusable.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add unit tests for AddDelegatePage so that with non-validated account, it should show VerifyAccountPage first.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@akinwale 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@akinwale @abekkala this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@akinwale 10 days overdue. I'm getting more depressed than Marvin.

[abekkala]

@akinwale can you review the proposal above please?

[akinwale]

@hoangzinh's proposal works here.

🎀👀🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@tylerkaraszewski Eep! 4 days overdue now. Issues have feelings too...

[abekkala]

@tylerkaraszewski do you agree with the chosen proposal above?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - The app log out the Gmail account after enter MC when adding copilot #61830

If no regressions arise, payment will be issued on 2025-05-30. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment through NewDot Manual Requests
• @hoangzinh requires payment through NewDot Manual Requests

[melvin-bot]

@akinwale / @hoangzinh @abekkala @akinwale / @hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[akinwale]

BugZero Checklist:

• [@akinwale] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A

• [@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Launch Expensify.
2. Sign in with a brand new account.
3. Click or tap on the Join button.
4. Select any of the onboarding options.
5. Navigate to Settings > Security and select Add copilot.
6. Verify that account validation is required before the copilot account can be added.
7. Enter the correct magic code.
8. Verify that the app successfully navigates to the add copilot screen.
9. Provide a valid account.
10. Select any option.
11. Click or tap on the Add copilot button.
12. Enter the correct magic code.
13. Verify that the app navigates back to the Security page, and the added copilot is displayed.

Do we agree 👍 or 👎?