[Due for payment 2025-04-17] Copilot - Copilot context menu is blocked at the bottom of the page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.24-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/5891840
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: User Settings

Action Performed:

Precondition:

• Use a normal display instead of huge/wide display.

1. Go to staging.new.expensify.com
2. Go to Settings > Security.
3. Click Add copilot.
4. Select a user.
5. Select any access.
6. Click Add copilot.
7. Enter magic code.
8. Scroll to the bottom of Security page.
9. Click on the copilot.

Expected Result:

Copilot 3-dot menu will be displayed completely.

Actual Result:

Copilot 3-dot menu is blocked. User cannot scroll the page down further to see the menu.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6795714_1744091027315.20250408_134052.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021909532646492238545
• Upwork Job ID: 1909532646492238545
• Last Price Increase: 2025-04-08
• Automatic offers:
• ZhenjaHorbach | Reviewer | 106833615

Issue Owner

Current Issue Owner: @lydiabarclay

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mitarachim]

Issue not reproduce in Production while percentage of screen 80% or more , Copilot 3-dot menu is shown up perfectly.

Screen.Recording.2025-04-08.at.12.53.57.PM.mp4

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copilot 3-dot menu is blocked. User cannot scroll the page down further to see the menu.

What is the root cause of that problem?

Offending PR

In here:

App/src/components/PopoverWithMeasuredContent.tsx

Lines 142 to 144 in 689e60c

	if (anchorAlignment.vertical === CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP) {
	shiftedAnchorPosition.top = adjustedAnchorPosition.top;
	}

If vertical anchor is TOP then we just use adjustedAnchorPosition.top directly without considering popoverHeight, so when the threedot menu is close to bottom, the menu will be cut off at bottom.

What changes do you think we should make in order to solve the problem?

We should handle this case with popoverHeight taking into account

App/src/components/PopoverWithMeasuredContent.tsx

Lines 142 to 144 in 689e60c

	if (anchorAlignment.vertical === CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP) {
	shiftedAnchorPosition.top = adjustedAnchorPosition.top;
	}

Sample code change, can improve in the PR phase

if (anchorAlignment.vertical === CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP) {
	let potentialTop = adjustedAnchorPosition.top + verticalShift
	const popoverBottomEdge = potentialTop + popoverHeight
	if (popoverBottomEdge > windowHeight - verticalShift) {
		potentialTop = windowHeight - popoverHeight - verticalShift
	}
	potentialTop = Math.max(verticalShift, potentialTop)
	shiftedAnchorPosition.top = potentialTop
}

Screen.Recording.2025-04-08.at.13.48.54.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[daledah]

I can help raise a quick PR if needed.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021909532646492238545

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[rezkiy37]

Hi, I am Michael (Mykhailo) from Callstack, an expert agency, and I can work on this issue. It looks like a regression from #59226.

[daledah]

@rezkiy37 According to the Expensify Contributing Guideline, existing proposals should be prioritized:

App/contributingGuides/CONTRIBUTING.md

Line 206 in ad68890

- If there are existing proposals, BZ will put the issue on hold. [Contributor+](https://github.com/Expensify/App/blob/main/contributingGuides/HOW_TO_BECOME_A_CONTRIBUTOR_PLUS.md) will review the existing proposals. If a contributor’s proposal is accepted then the contributor will be assigned to the issue. If not the issue will be assigned to the agency-employee.

If not it'd be unfair for contributors who follow the guideline and who post proposals to help with the issue.

[ZhenjaHorbach]

@rezkiy37 According to the Expensify Contributing Guideline, existing proposals should be prioritized:

App/contributingGuides/CONTRIBUTING.md

Line 206 in ad68890

• If there are existing proposals, BZ will put the issue on hold. Contributor+ will review the existing proposals. If a contributor’s proposal is accepted then the contributor will be assigned to the issue. If not the issue will be assigned to the agency-employee.
  If not it'd be unfair for contributors who follow the guideline and who post proposals to help with the issue.

This is a regression from our PR
Plus this is a deploy blocker

And here it makes no difference who did the PR (an expert agency or a contributor) 😅

[daledah]

@ZhenjaHorbach Yes and it also is opened for Contributors, so I think it's best to follow contributing guides here.

[cristipaval]

@daledah, thanks a lot for your proposals! I really appreciate your contributions to our project!

We usually try to assign the deploy blockers to the authors of the offending PR, and if they are not available in time to fix them in a timely manner, we hire other contributors and apply penalties (if applicable) to the original author and C+.

Also, please keep in mind this from the guidelines

[rezkiy37]

I've opened #59808 for review.

[jasperhuangg]

Retested, and this passes!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Adjust popover positioning logic to ensure it remains within window #59808

If no regressions arise, payment will be issued on 2025-04-16. 🎊

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @ZhenjaHorbach requires payment automatic offer (Reviewer)

[melvin-bot]

@ZhenjaHorbach @lydiabarclay @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[lydiabarclay]

Hi @cristipaval and @jasperhuangg, I want to double check about next steps here. I see @ZhenjaHorbach was assigned as reviewer yesterday, so I'm assuming that they still require payment? If so, could they please complete the checklist above?

[cristipaval]

@lydiabarclay, no payment is needed here because this was a regression from this PR (a bug introduced by it), and it was fixed by the author and the C+ of that offending PR.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.25-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Adjust popover positioning logic to ensure it remains within window #59808

If no regressions arise, payment will be issued on 2025-04-17. 🎊

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @ZhenjaHorbach requires payment automatic offer (Reviewer)

[melvin-bot]

@ZhenjaHorbach @lydiabarclay @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]