[Due for payment 2025-04-16] Modal with payment methods blinks

[rezkiy37]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: yes
Reproducible in production?: no
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @rezkiy37
Slack conversation (hyperlinked to channel name):

Action Performed:

Break down in numbered steps

Found in this PR - #50640 (comment).

1. Open an invoice report as a receiver.
2. Click on the pay button.
3. Select the individual or business payment flow.
4. Click out of the modal to hide it.
5. Click on the pay button again.

Expected Result:

Describe what you think should've happened

The modal does not blink and opens immediately from the very beginning.

Actual Result:

Describe what actually happened

The modal blinks and opens on the payment actions and rerenders for resetting to the very beginning.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

423694579-7fdd1e0b-d511-4d03-ab70-51900654e175.mov

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @rezkiy37

[rezkiy37]

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

[rezkiy37]

Working on the issue.

[rezkiy37]

I’m planning a day off today. I will work on the issue tomorrow.

[rezkiy37]

The bug is pretty tricky, but it looks like I've found a component (PopoverWithMeasuredContent.tsx) where I need to fix something. I've attached a screenshot where you can see values are not stable and quickly change between re-renders. I am actively working on the issue.

[cristipaval]

@rezkiy37, I got into this PR that caught my eye today. Do you think it might fix a similar issue as the one we're fixing here?

[rezkiy37]

@cristipaval I see but they are not similar. The root cause is different. Anyway, thank you for informing me 🙂

[rezkiy37]

I've found the root cause and working on the PR (#59226).

[rezkiy37]

I've opened the PR for review.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[rezkiy37]

I've opened a fix PR for review: #59808.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Enhance content measuring in PopoverWithMeasuredContent #59226

If no regressions arise, payment will be issued on 2025-04-16. 🎊

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @ZhenjaHorbach requires payment (Needs manual offer from BZ)

[melvin-bot]

@ZhenjaHorbach @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @trjExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @rezkiy37 is from an agency-contributor and not due payment
• Reviewer: @ZhenjaHorbach owed $250 via NewDot

BugZero Checklist (@trjExpensify)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[trjExpensify]

👋 @ZhenjaHorbach can you look at the checklist, and confirm the payment amounts with regressions here? Thanks!

[melvin-bot]

@rezkiy37 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[rezkiy37]

The PR was merged and we can finish the issue.

[melvin-bot]

@rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rezkiy37]

The issue can be closed.

[ZhenjaHorbach]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Unfortunately I did't find a suitable PR
  But we decided to create this issue after this PR
  Although the issue was reproduced before

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: NA

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Test:

1. Open an invoice report as a receiver.
2. Click on the pay button.
3. Click out of the modal to hide it.
4. Click on the pay button again.
5. Verify that the modal does not blink and opens immediately from the very beginning.

Do we agree 👍 or 👎

[ZhenjaHorbach]

@cristipaval
Could you reopen this issue, please ?
I hope we need to make a payment here 😅

[ZhenjaHorbach]

👋 @ZhenjaHorbach can you look at the checklist, and confirm the payment amounts with regressions here? Thanks!

And sorry
Didn't notice this message
And yeah
We had an one regression 🥲
So I guess we need to decrease a payment