[Due for payment 2025-04-25] [$250] Web - Search - Search is not opened on report page with CMD(ctrl) + K

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.23-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: -
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Search

Action Performed:

1. Login to an account that has a report with multiple expenses
2. Go to Reports > Expense reports
3. Click on any report with multiple expenses
4. Press CMD(ctrl) + K

Expected Result:

Search is opened and focused

Actual Result:

Search is not opened.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6791774_1743726112826.Screen_Recording_2025-04-04_at_12.45.58_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021909318554554905924
• Upwork Job ID: 1909318554554905924
• Last Price Increase: 2025-04-07
• Automatic offers:
• nkdengineer | Contributor | 106880633

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-04 07:36:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search is not opened.

What is the root cause of that problem?

When users go to Expense report page, we trigger the following logic to register the input ref

App/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx

Line 101 in f01c7de

registerSearchPageInput(textInputRef.current);

and if the inputRef has value we will prevent showing the search router

App/src/components/Search/SearchRouter/SearchRouterContext.tsx

Line 54 in f01c7de

if (isUserOnSearchPage && searchPageInputRef.current) {

What changes do you think we should make in order to solve the problem?

We should unregister the inputRef if the Expense report page is removed

useEffect(() => {

          if(!isFocused && textInputRef.current) {
                unregisterSearchPageInput();
                 return;
            }
        if (displayNarrowHeader || !isFocused || !textInputRef.current) {
            return;
        }

        registerSearchPageInput(textInputRef.current);
    }, [isFocused, registerSearchPageInput, displayNarrowHeader]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Update the condition here

App/src/components/Search/SearchRouter/SearchRouterContext.tsx

Line 52 in f01c7de

const isUserOnSearchPage = isSearchTopmostFullScreenRoute();

to

const searchFullScreenRoutes = navigationRef.getRootState()?.routes.findLast((route) => route.name === NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR);
const lastRoute = searchFullScreenRoutes?.state?.routes?.at(-1);
const isUserOnSearchPage = isSearchTopmostFullScreenRoute() && lastRoute?.name === SCREENS.SEARCH.ROOT;

so isUserOnSearchPage is true only when users are on the search root page.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@isabelastisser Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021909318554554905924

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)