[$250] Expense preview- Report title part of report preview is blank briefly after submitting expense #59525

IuliiaHerets · 2025-04-02T09:39:44Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.1.22-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #58479
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

Log in with Expensifail account.

Go to staging.new.expensify.com
Go to workspace chat.
Submit a manual expense.
Note that the report title part of the expense report preview is blank briefly.
Click Submit.
Go offline.
Submit another manual expense.

Expected Result:

The report title part of the expense report preview should not be blank after submitting the expense.

Actual Result:

In offline mode, the report title part of the expense report preview is blank after submitting the expense.
In online mode, the same part is blank briefly after submitting the expense.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/32aa7967-a8b9-48b8-bc88-31b2fddf27ed

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021907791019793338504
Upwork Job ID: 1907791019793338504
Last Price Increase: 2025-04-03
Automatic offers:

nkdengineer | Contributor | 106825210

Issue Owner

Current Issue Owner: @Beamanator

melvin-bot · 2025-04-02T09:39:53Z

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

daledah · 2025-04-02T10:43:53Z

🚨 Edited by proposal-police: This proposal was edited at 2025-04-02 10:48:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In offline mode, the report title part of the expense report preview is blank after submitting the expense.
In online mode, the same part is blank briefly after submitting the expense.

What is the root cause of that problem?

We don't return the childReportName when we run buildOptimisticReportPreview to update Onyx data

App/src/libs/ReportUtils.ts

Lines 5953 to 5980 in 66f28d3

    
           return { 
        
               reportActionID: reportActionID ?? rand64(), 
        
               reportID: chatReport?.reportID, 
        
               actionName: CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW, 
        
               pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               originalMessage: { 
        
                   linkedReportID: iouReport?.reportID, 
        
               }, 
        
               message: [ 
        
                   { 
        
                       html: message, 
        
                       text: message, 
        
                       isEdited: false, 
        
                       type: CONST.REPORT.MESSAGE.TYPE.COMMENT, 
        
                   }, 
        
               ], 
        
               delegateAccountID: delegateAccountDetails?.accountID, 
        
               created, 
        
               accountID: iouReport?.managerID, 
        
               // The preview is initially whispered if created with a receipt, so the actor is the current user as well 
        
               actorAccountID: hasReceipt ? currentUserAccountID : reportActorAccountID, 
        
               childReportID: childReportID ?? iouReport?.reportID, 
        
               childMoneyRequestCount: 1, 
        
               childLastActorAccountID: currentUserAccountID, 
        
               childLastMoneyRequestComment: comment, 
        
               childRecentReceiptTransactionIDs: hasReceipt && !isEmptyObject(transaction) && transaction?.transactionID ? {[transaction.transactionID]: created} : undefined, 
        
               ...(isTestTransaction && {childStateNum: 2, childStatusNum: 4}), 
        
           };

It leads to action.childReportName being empty when creating an expense in offline

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Lines 483 to 488 in 66f28d3

    
           <Text 
        
               style={[styles.headerText]} 
        
               testID="MoneyRequestReportPreview-reportName" 
        
           > 
        
               {action.childReportName} 
        
           </Text>

What changes do you think we should make in order to solve the problem?

We have some ways to fix it as follows

The simplest way is that we will not show this View when there is no childReportName
We can add fallback here like 'Expense report'

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Line 487 in 66f28d3

{action.childReportName}

We will calculate and return additional childReportName in buildOptimisticReportPreview by using populateOptimisticReportFormula function

Create a new pattern in const.ts file DEFAULT_REPORT_ID_PATTERN: '{report:type} {report:reportID}'
Update function populateOptimisticReportFormula to match with DEFAULT_REPORT_ID_PATTERN here

        .replaceAll('{report:reportID}', report.reportID ?? '')

Return childReportName in buildOptimisticReportPreview function

    const childReportName = populateOptimisticReportFormula(CONST.POLICY.DEFAULT_REPORT_ID_PATTERN, iouReport, undefined);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

nkdengineer · 2025-04-03T07:34:21Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

In offline mode, the report title part of the expense report preview is blank after submitting the expense.
In online mode, the same part is blank briefly after submitting the expense.

What is the root cause of that problem?

We're displaying the report title in report preview from childReportName of REPORTPREVIEW action,

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Lines 483 to 488 in 66f28d3

    
           <Text 
        
               style={[styles.headerText]} 
        
               testID="MoneyRequestReportPreview-reportName" 
        
           > 
        
               {action.childReportName} 
        
           </Text>

But childReportName is empty when we create optimistic data for REPORTPREVIEW action that leads the report title is empty briefly until the API is done.

App/src/libs/ReportUtils.ts

Lines 5953 to 5980 in 66f28d3

    
           return { 
        
               reportActionID: reportActionID ?? rand64(), 
        
               reportID: chatReport?.reportID, 
        
               actionName: CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW, 
        
               pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               originalMessage: { 
        
                   linkedReportID: iouReport?.reportID, 
        
               }, 
        
               message: [ 
        
                   { 
        
                       html: message, 
        
                       text: message, 
        
                       isEdited: false, 
        
                       type: CONST.REPORT.MESSAGE.TYPE.COMMENT, 
        
                   }, 
        
               ], 
        
               delegateAccountID: delegateAccountDetails?.accountID, 
        
               created, 
        
               accountID: iouReport?.managerID, 
        
               // The preview is initially whispered if created with a receipt, so the actor is the current user as well 
        
               actorAccountID: hasReceipt ? currentUserAccountID : reportActorAccountID, 
        
               childReportID: childReportID ?? iouReport?.reportID, 
        
               childMoneyRequestCount: 1, 
        
               childLastActorAccountID: currentUserAccountID, 
        
               childLastMoneyRequestComment: comment, 
        
               childRecentReceiptTransactionIDs: hasReceipt && !isEmptyObject(transaction) && transaction?.transactionID ? {[transaction.transactionID]: created} : undefined, 
        
               ...(isTestTransaction && {childStateNum: 2, childStatusNum: 4}), 
        
           };

What changes do you think we should make in order to solve the problem?

Add childReportName as iouReport.reportName here

childReportName: iouReport.reportName,

App/src/libs/ReportUtils.ts

Lines 5953 to 5980 in 66f28d3

    
           return { 
        
               reportActionID: reportActionID ?? rand64(), 
        
               reportID: chatReport?.reportID, 
        
               actionName: CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW, 
        
               pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               originalMessage: { 
        
                   linkedReportID: iouReport?.reportID, 
        
               }, 
        
               message: [ 
        
                   { 
        
                       html: message, 
        
                       text: message, 
        
                       isEdited: false, 
        
                       type: CONST.REPORT.MESSAGE.TYPE.COMMENT, 
        
                   }, 
        
               ], 
        
               delegateAccountID: delegateAccountDetails?.accountID, 
        
               created, 
        
               accountID: iouReport?.managerID, 
        
               // The preview is initially whispered if created with a receipt, so the actor is the current user as well 
        
               actorAccountID: hasReceipt ? currentUserAccountID : reportActorAccountID, 
        
               childReportID: childReportID ?? iouReport?.reportID, 
        
               childMoneyRequestCount: 1, 
        
               childLastActorAccountID: currentUserAccountID, 
        
               childLastMoneyRequestComment: comment, 
        
               childRecentReceiptTransactionIDs: hasReceipt && !isEmptyObject(transaction) && transaction?.transactionID ? {[transaction.transactionID]: created} : undefined, 
        
               ...(isTestTransaction && {childStateNum: 2, childStatusNum: 4}), 
        
           };

I noticed that we have an inconsistency for the expense report's reportName. The default report title formula is {report:type} {report:startdate}, and we used it to generate reportName in optimistic data here but the backend return the reportName with the formula is {report:type} {report:reportID}. We should fix it from backend side to change the default formula of the title field to {report:type} {report:reportID} or fix reportName of new expense report.

The IOU report is displaying IOU, but this report has the custom report name in front-end; then we can use getReportName(iouReport) and fallback it to action.childReportName if iouReport data isn't available

{getReportName(iouReport) || action.childReportName}

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Lines 483 to 488 in 66f28d3

    
           <Text 
        
               style={[styles.headerText]} 
        
               testID="MoneyRequestReportPreview-reportName" 
        
           > 
        
               {action.childReportName} 
        
           </Text>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add a unit test for buildOptimisticReportPreview and verify that the childReportName is equal to iouReport.reportName.

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

melvin-bot · 2025-04-03T13:43:22Z

Job added to Upwork: https://www.upwork.com/jobs/~021907791019793338504

melvin-bot · 2025-04-03T13:43:27Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

hoangzinh · 2025-04-04T16:17:33Z

but the backend return the reportName with the formula is {report:type} {report:reportID}. We should fix it from backend side to change the default formula of the title field to {report:type} {report:reportID}

@nkdengineer I got confused here. Can you clarify what it means? I'm interpreting that because BE is already returning {report:type} {report:reportID}, why do we also need to change the default to {report:type} {report:reportID}?

nkdengineer · 2025-04-04T16:25:03Z

I'm interpreting that because BE is already returning {report:type} {report:reportID}

@hoangzinh That is the report name of the expense report.

I mean, we need to fix titleReportField.defaultValue to {report:type} {report:reportID}. It's {report:type} {report:startdate} that why the expense report's reportName is different in offline.

App/src/libs/ReportUtils.ts

Lines 5411 to 5413 in 3b313d1

    
           if (!!titleReportField && isPaidGroupPolicyExpenseReport(expenseReport)) { 
        
               expenseReport.reportName = populateOptimisticReportFormula(titleReportField.defaultValue, expenseReport, policy); 
        
           }

hoangzinh · 2025-04-04T22:50:56Z

Thank you for posting proposals @daledah @nkdengineer. I think we can go with @nkdengineer's proposal, because:

I asked for more information here. It looks like FE should use the formula stored in policy.fieldList.text_title.defaultValue to generate an optimistic reportName, which iouReport.reportName already does.
Besides that, I think it's also a BE issue, it should generate reportName based on policy.fieldList.text_title.defaultValue instead of {report:type} {report:reportID}. I found that we have an issue for it already [Tracking] Custom Report Names on New Expensify #44340

Link to proposal #59525 (comment)

🎀👀🎀 C+ reviewed

melvin-bot · 2025-04-04T22:51:09Z

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot · 2025-04-07T19:01:35Z

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

nkdengineer · 2025-04-10T03:13:19Z

@isabelastisser Because this issue requires BE change and we already had the issue to do that, should we hold it util BE is fixed? IMO, we can process this issue separately since we can verify it on offline mode. cc @hoangzinh

hoangzinh · 2025-04-10T12:44:22Z

cc @Beamanator ^ what do you think? I think we can continue to proceed with @nkdengineer PR here. The current issue is that the Report title of report preview will have the format "Expenses yyyy-mm-dd" briefly (FE optimistic), then change to "Expenses #id" format (BE response).

Beamanator · 2025-04-11T12:27:28Z

I like the idea of moving forward with this, BUT i don't necessarily love the idea of optimistic & BE being different, especially in case the BE changes takes a long time.

@neil-marcellini Can you help advise if it would make sense to move forward with this while you're working on the linked issue?

neil-marcellini · 2025-04-14T20:14:21Z

Yes I agree I don't think the optimistic data should be different from the backend data. I think we should hold this on the auto report title project. Instead, would you guys be interested in helping with this? Plan and implement a system for optimistic report title formula computation.

neil-marcellini · 2025-04-14T20:15:00Z

Actually instead of holding I'm going to close this as not planned, since it will be fixed as part of that project.

nkdengineer · 2025-04-14T20:19:10Z

@neil-marcellini Can you help advise if it would make sense to move forward with this while you're working on the linked issue?

@neil-marcellini This is only the back-end part of this issue. We still have the front-end bug with optimistic data here that we need to fix this, please help to re-open this issue.

neil-marcellini · 2025-04-14T20:22:48Z

The linked issue is specifically for the frontend.

nkdengineer · 2025-04-14T20:26:29Z

The linked issue is specifically for the frontend.

@neil-marcellini I mean, we're having another bug with Expense preview that isn't related to this issue.

The current issue is that the Report title of report preview will have the format "Expenses yyyy-mm-dd" briefly (FE optimistic), then change to "Expenses #id" format (BE response).

The problem we want to confirm here is will this issue fix this backend bug

neil-marcellini · 2025-04-14T20:33:31Z

Yes we'll make sure the frontend and backend report title computations work the same way.

nkdengineer · 2025-04-15T03:40:08Z

Yes we'll make sure the frontend and backend report title computations work the same way.

@neil-marcellini Got it now. But our bug here is that the report preview doesn't show the expense report name in offline. And the RCA is not related to the report title computations. It's related to childReportName isn't set of the REPORTPREVIEW action.

hoangzinh · 2025-04-15T15:13:10Z

Agreed with @nkdengineer, the original bug of this issue is report title part is blank because we missed adding optimistic data for report preview. You can take a look at this proposal #59525 (comment) @neil-marcellini

nkdengineer · 2025-04-23T06:47:01Z

@neil-marcellini Please help to check this comment above.

neil-marcellini · 2025-04-25T18:06:44Z

Agreed with @nkdengineer, the original bug of this issue is report title part is blank because we missed adding optimistic data for report preview. You can take a look at this proposal #59525 (comment) @neil-marcellini

Right that would be good to fix, but I'm still not clear on whether we can fix this without creating an inconsistency between the optimistic and backend data. If so, please update your proposal to do exactly that and explain why there is no inconsistency. If not, we should keep this closed and fix it holistically.

hoangzinh · 2025-04-27T06:40:59Z

I see. Actually, I'm unsure what the correct way to fix it from FE side. I mean, should we use iouReport.reportName or generate its own report name based on policy.fieldList.text_title.defaultValue. I'm happy to close this issue and fix it holistically here #59525 (comment)

hoangzinh · 2025-04-27T06:42:00Z

@isabelastisser, because the proposal has been accepted and the PR was created. Can you process payment here for @nkdengineer and me? Then we can close this issue.

isabelastisser · 2025-04-28T17:18:46Z

Payment summary:

$250 for C+ review to @hoangzinh, PENDING in NewDot.
$250 for proposal to @nkdengineer. Paid in Upwork here.

hoangzinh · 2025-04-28T23:31:46Z

Thank you @isabelastisser. I requested in ND

garrettmknight · 2025-05-02T14:39:22Z

$250 approved for @hoangzinh

IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Apr 2, 2025

melvin-bot bot assigned isabelastisser Apr 2, 2025

isabelastisser added External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Apr 3, 2025

melvin-bot bot changed the title ~~Expense preview- Report title part of report preview is blank briefly after submitting expense~~ [$250] Expense preview- Report title part of report preview is blank briefly after submitting expense Apr 3, 2025

isabelastisser added this to #expensify-bugs Apr 3, 2025

melvin-bot bot assigned hoangzinh Apr 3, 2025

dylanexpensify moved this to Bugs and Follow Up Issues in #expensify-bugs Apr 3, 2025

melvin-bot bot assigned Beamanator Apr 4, 2025

melvin-bot bot added the Overdue label Apr 7, 2025

isabelastisser assigned nkdengineer Apr 7, 2025

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 7, 2025

melvin-bot bot removed the Overdue label Apr 7, 2025

nkdengineer mentioned this issue Apr 8, 2025

Report title part of report preview is blank briefly after submitting expense #59838

Closed

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 8, 2025

neil-marcellini closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2025

github-project-automation bot moved this from Bugs and Follow Up Issues to Done in #expensify-bugs Apr 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$250] Expense preview- Report title part of report preview is blank briefly after submitting expense #59525

[$250] Expense preview- Report title part of report preview is blank briefly after submitting expense #59525

IuliiaHerets commented Apr 2, 2025 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Apr 2, 2025

daledah commented Apr 2, 2025 •

edited by github-actions bot

Loading

nkdengineer commented Apr 3, 2025

melvin-bot bot commented Apr 3, 2025

melvin-bot bot commented Apr 3, 2025

hoangzinh commented Apr 4, 2025

nkdengineer commented Apr 4, 2025 •

edited

Loading

hoangzinh commented Apr 4, 2025

melvin-bot bot commented Apr 4, 2025

melvin-bot bot commented Apr 7, 2025

nkdengineer commented Apr 10, 2025

hoangzinh commented Apr 10, 2025

Beamanator commented Apr 11, 2025

neil-marcellini commented Apr 14, 2025

neil-marcellini commented Apr 14, 2025

nkdengineer commented Apr 14, 2025

neil-marcellini commented Apr 14, 2025 •

edited

Loading

nkdengineer commented Apr 14, 2025

neil-marcellini commented Apr 14, 2025

nkdengineer commented Apr 15, 2025

hoangzinh commented Apr 15, 2025

nkdengineer commented Apr 23, 2025

neil-marcellini commented Apr 25, 2025

hoangzinh commented Apr 27, 2025

hoangzinh commented Apr 27, 2025

isabelastisser commented Apr 28, 2025

hoangzinh commented Apr 28, 2025

garrettmknight commented May 2, 2025

[$250] Expense preview- Report title part of report preview is blank briefly after submitting expense #59525

[$250] Expense preview- Report title part of report preview is blank briefly after submitting expense #59525

Comments

IuliiaHerets commented Apr 2, 2025 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Apr 2, 2025

daledah commented Apr 2, 2025 • edited by github-actions bot Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

nkdengineer commented Apr 3, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Apr 3, 2025

melvin-bot bot commented Apr 3, 2025

hoangzinh commented Apr 4, 2025

nkdengineer commented Apr 4, 2025 • edited Loading

hoangzinh commented Apr 4, 2025

melvin-bot bot commented Apr 4, 2025

melvin-bot bot commented Apr 7, 2025

nkdengineer commented Apr 10, 2025

hoangzinh commented Apr 10, 2025

Beamanator commented Apr 11, 2025

neil-marcellini commented Apr 14, 2025

neil-marcellini commented Apr 14, 2025

nkdengineer commented Apr 14, 2025

neil-marcellini commented Apr 14, 2025 • edited Loading

nkdengineer commented Apr 14, 2025

neil-marcellini commented Apr 14, 2025

nkdengineer commented Apr 15, 2025

hoangzinh commented Apr 15, 2025

nkdengineer commented Apr 23, 2025

neil-marcellini commented Apr 25, 2025

hoangzinh commented Apr 27, 2025

hoangzinh commented Apr 27, 2025

isabelastisser commented Apr 28, 2025

hoangzinh commented Apr 28, 2025

garrettmknight commented May 2, 2025

IuliiaHerets commented Apr 2, 2025 •

edited by melvin-bot bot

Loading

daledah commented Apr 2, 2025 •

edited by github-actions bot

Loading

nkdengineer commented Apr 4, 2025 •

edited

Loading

neil-marcellini commented Apr 14, 2025 •

edited

Loading