[Due for payment 2025-04-25] [$250] Reports - Report title changes from "x owes y" to "IOU" after holding the expense

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.22-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. [User A] Submit two expenses to User B.
3. [User B] Go to Reports > Expense Reports.
4. [User B] Select one of the expenses via checkbox.
5. [User B] Click on the dropdown > Hold.
6. [User B] Enter reason and save it.

Expected Result:

The report title will not change after holding the expense.

Actual Result:

The report title changes from "x owes y" to "IOU" after holding the expense.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021907426079430027656
• Upwork Job ID: 1907426079430027656
• Last Price Increase: 2025-04-02
• Automatic offers:
• mkzie2 | Contributor | 106850553

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The report title changes from "x owes y" to "IOU" after holding the expense.

What is the root cause of that problem?

We will return reportItem.reportName if the action isn't one of ['view', 'pay', 'paid'].

App/src/libs/SearchUIUtils.ts

Lines 255 to 269 in c3451e1

	if (reportItem.action === CONST.SEARCH.ACTION_TYPES.VIEW || reportItem.action === CONST.SEARCH.ACTION_TYPES.PAY) {
	return translateLocal('iou.payerOwesAmount', {
	payer: payerName,
	amount: formattedAmount,
	});
	}
	if (reportItem.action === CONST.SEARCH.ACTION_TYPES.PAID) {
	return translateLocal('iou.payerPaidAmount', {
	payer: payerName,
	amount: formattedAmount,
	});
	}
	return reportItem.reportName;

If we hold one transaction, the action returns review, and then the default name appears.

App/src/libs/SearchUIUtils.ts

Lines 366 to 368 in c3451e1

	if (shouldShowReview) {
	return CONST.SEARCH.ACTION_TYPES.REVIEW;
	}

What changes do you think we should make in order to solve the problem?

For iou report, we can remove the return reportItem.reportName and only return paid name if the action is paid, otherwise return x owes y.

function getIOUReportName(data: OnyxTypes.SearchResults['data'], reportItem: SearchReport) {
    const payerPersonalDetails = reportItem.managerID ? data.personalDetailsList?.[reportItem.managerID] : emptyPersonalDetails;
    const payerName = payerPersonalDetails?.displayName ?? payerPersonalDetails?.login ?? translateLocal('common.hidden');
    const formattedAmount = convertToDisplayString(reportItem.total ?? 0, reportItem.currency ?? CONST.CURRENCY.USD);

    if (reportItem.action === CONST.SEARCH.ACTION_TYPES.PAID) {
        return translateLocal('iou.payerPaidAmount', {
            payer: payerName,
            amount: formattedAmount,
        });
    }

    return translateLocal('iou.payerOwesAmount', {
        payer: payerName,
        amount: formattedAmount,
    });
}

App/src/libs/SearchUIUtils.ts

Lines 366 to 368 in c3451e1

	if (shouldShowReview) {
	return CONST.SEARCH.ACTION_TYPES.REVIEW;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update the result test with the case the action is review and verify that the reportName if iou report is correct.

What alternative solutions did you explore? (Optional)

Or we can add review case here.

App/src/libs/SearchUIUtils.ts

Lines 255 to 260 in c3451e1

	if (reportItem.action === CONST.SEARCH.ACTION_TYPES.VIEW || reportItem.action === CONST.SEARCH.ACTION_TYPES.PAY) {
	return translateLocal('iou.payerOwesAmount', {
	payer: payerName,
	amount: formattedAmount,
	});
	}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021907426079430027656

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-d (External)

[OfstadC]

I'll be OoO through next Monday - so if you need a BZ to take time sensitive action @rayane-d please re-add the bug label. Otherwise i'll check back in on Tuesday 😃

[melvin-bot]

@rayane-d Huh... This is 4 days overdue. Who can take care of this?

[rayane-d]

The proposal sounds good to me. Will test it later today

[rayane-d]

@mkzie2's proposal looks good to me

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @JS00001, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[JS00001]

@mkzie2 LGTM, please create a PR for the changes whenever you get the chance. Thank you!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• search report title changes to IOU when holding expenses #60058

If no regressions arise, payment will be issued on 2025-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @rayane-d requires payment through NewDot Manual Requests
• @mkzie2 requires payment automatic offer (Contributor)

[melvin-bot]

@rayane-d @OfstadC @rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[rayane-d]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: fix: report title is incorrect for IOU grouped expense in search page #47029 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/494110

Regression Test Proposal

Precondition:

• N/A

Test:

1. [User A] Submit two IOUs to User B in DM.
2. [User B] Go to Reports > Expense Reports.
3. [User B] Verify that the report containing the two expenses is displayed with a "x owes y" name.
4. [User B] Select one of the expenses via checkbox.
5. [User B] Click on the dropdown > Hold.
6. [User B] Enter reason and save it.
7. [User B] Verify the report title does not change to "IOU" (it should remain "x owes y")
8. [User B] Change the status of the report between 'view', 'review', 'submit', 'approve', 'pay'
9. [User B] Verify the report title remains "x owes y"
10. [User B] Change the status of the report to 'paid'
11. [User B] Verify the report title changes to "x paid y"

Do we agree 👍 or 👎

[OfstadC]

Payment Summary

• @rayane-d due $250 via manual NewDot requests
• @mkzie2 paid $250 via Upwork

[garrettmknight]

$250 approved for @rayane-d