[Due for payment 2025-04-23] [Due for payment 2025-04-14] [$125] Empty state animation does not show when switching the tabs

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.18-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kubabutkiewicz
Slack conversation (hyperlinked to channel name): #expensify-bugs

Action Performed:

1. Go to the Reports tab.
2. Search for something that does not exist and observe the empty state animation.
3. Navigate to a different tab, e.g., Settings.
4. Go back to Search using the Back button.

Expected Result:

The empty state animation should be displayed.

Actual Result:

The empty state animation does not appear.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1085.mp4

Screen.Recording.2025-03-25.at.13.25.13.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904673874830293667
• Upwork Job ID: 1904673874830293667
• Last Price Increase: 2025-03-25
• Automatic offers:
• nkdengineer | Contributor | 106709197

Issue Owner

Current Issue Owner: @sakluger

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The empty state animation does not appear.

What is the root cause of that problem?

We are not rendering EmptySearchView again when user clicks to the device back button

App/src/components/Search/index.tsx

Lines 370 to 379 in 57c8241

	if (shouldShowEmptyState(isDataLoaded, data.length, searchResults.search.type)) {
	return (
	<View style={[shouldUseNarrowLayout ? styles.searchListContentContainerStyles : styles.mt3, styles.flex1]}>
	<EmptySearchView
	type={type}
	hasResults={searchResults.search.hasResults}
	/>
	</View>
	);
	}

What changes do you think we should make in order to solve the problem?

We should only show the EmptySearchView when isFocused is true and and it will re-render when the user returns to the search page.

    if (shouldShowEmptyState(isDataLoaded, data.length, searchResults.search.type) && isFocused) 

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Or we can only render again EmptyStateComponent here when isFocus changed

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[sakluger]

This feels like a pretty simple change, so I'm going to set the price to $125. Let me know if you disagree.

@nkdengineer I'm not sure what's wrong with your proposal that triggered that automated comment, it looks like the proper format to me 🤷‍♂

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021904673874830293667

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[melvin-bot]

Upwork job price has been updated to $125

[rojiphil]

Thanks for the proposal.
@nkdengineer proposal to rerender using isFocused LGTM. But instead of rendering the entire view, let us restrict the re-rendering to the empty state animation only.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@sakluger This issue is not simple when it comes to finding the root cause and the solution, so I think we can consider keeping the old price cc @rojiphil

[nkdengineer]

@sakluger could you please check my comment here?

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Empty state animation does not show when switching the tabs #59325

If no regressions arise, payment will be issued on 2025-04-14. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@rojiphil @sakluger @rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[sakluger]

@nkdengineer I discussed with @luacmartins and we agree that it's fair to pay $250 due to a trickier investigation.

[sakluger]

@rojiphil could you please coomplete the BZ checklist today?

[sakluger]

Summarizing payment on this issue:

Contributor: @nkdengineer $250, sent offer via Upwork: https://www.upwork.com/nx/wm/offer/106915460
Contributor+: @rojiphil $250, please request on Newdot after completing BZ checklist

[rojiphil]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not Required. The existing checklist is good enough to capture such issues.

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition:

Test:

1. Click on Reports tab in LHN.
2. Search such that no results exists. This will result in the display of empty state animation
3. Click on Settings tab in LHN.
4. Use the browser Back button to navigate back to Reports page
5. Verify that the empty state animation displays the animation.

Do we agree 👍 or 👎

[rojiphil]

@sakluger BZ Checklist is done. Thanks.

[sakluger]

Thank you @rojiphil - feel free to request payment now.

[sakluger]

@nkdengineer just waiting for you to accept the Upwork offer now.

[nkdengineer]

@sakluger I accepted, thank you

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.28-15-staging and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Reports empty state is blank briefly #59711

If no regressions arise, payment will be issued on 2025-04-23. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@rojiphil @sakluger @rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[garrettmknight]

$250 approved for @rojiphil

[rojiphil]

@sakluger Can we please close this issue if there is no other pending work here? Thanks.

[sakluger]

Yep, thanks for the reminder! Closing.

[nkdengineer]

@nkdengineer requires payment automatic offer (Contributor)

@sakluger I haven't been paid here, could you please reopen the issue to handle it?

Thanks in advance!

[sakluger]

@nkdengineer sorry about that! I completed payment on your Upwork contract.