[Due for payment 2025-04-17] [$250] Android - Devices back button has to be tapped twice to return to the chat

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.17-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #58676
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy A52s 5G / Android 14
App Component: Other

Action Performed:

Precondition: A WS join link from a different account is copied to the clipboard.

1. Open the app
2. Log in with a new Gmail account
3. Choose the "Track" onboarding option
4. Track a manual expense in the self DM chat
5. Send the WS join link to the chat
6. Tap on the link
7. Tap on the Android "<" button on the bottom of the page
8. Tap on the Android "<" button on the bottom of the page again
9. Tap on the Android "<" button on the bottom of the page again

Expected Result:

I should be returned to the self DM.

Actual Result:

Devices back button has to be tapped twice to return to the chat at the settings page after tapping on a WS join link.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6779004_1742643455785.az_recorder_20250322_122032.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021905590808062421178
• Upwork Job ID: 1905590808062421178
• Last Price Increase: 2025-03-28
• Automatic offers:
• allgandalf | Reviewer | 106749641

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @allgandalf

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Need to press back twice to arrives back at chat after opening a ws join link.

What is the root cause of that problem?

After we open the WS join link, we will call navigateAfterJoinRequest which navigates to SETTINGS (the bottom tab) and SETTINGS_WORKSPACES (the WS list).

App/src/libs/navigateAfterJoinRequest/index.ts

Lines 4 to 9 in 4750e38

	const navigateAfterJoinRequest = () => {
	Navigation.goBack(undefined, {shouldPopToTop: true});
	Navigation.navigate(ROUTES.SETTINGS);
	Navigation.navigate(ROUTES.SETTINGS_WORKSPACES.route);
	};
	export default navigateAfterJoinRequest;

However, both routes will push a SETTINGS_SPLIT_NAVIGATOR to the stack, so we have 2 settings navigator.

That's why we need to press back twice.

What changes do you think we should make in order to solve the problem?

We don't need to navigate to ROUTES.SETTINGS anymore, so we need to remove it.

We can apply it to the .web and .desktop platform files too.

(btw, looks like they all have the same implementation, so we can just merge it into 1 file)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

@sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@sonialiap Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021905590808062421178

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[melvin-bot]

@allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

[allgandalf]

Proposal from @bernhardoj LGTM

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[aldo-expensify]

Friendly bump @allgandalf @bernhardoj , when do you think we can have a PR?

[aldo-expensify]

I'll try to reassign this, I'm going OOO next week.

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[aldo-expensify]

I failed, I try to do a label dance to reassign to another engineer, but got @laurenreidexpensify . Sorry for the noise, I'll ask in engineering chat.

[bernhardoj]

Oops, I missed this. PR is ready

cc: @allgandalf

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.25-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix needs to press back twice after opening a workspace join page #59697

If no regressions arise, payment will be issued on 2025-04-17. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment through NewDot Manual Requests
• @allgandalf requires payment automatic offer (Reviewer)

[melvin-bot]

@allgandalf @sonialiap @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[sonialiap]

Payment summary:

• @allgandalf $250 via upwork, please complete the checklist and I'll release the payment :) - paid ✔
• @bernhardoj $250 please request in ND

[allgandalf]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: Change of requirenment

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: No offending PR, over time the requirement changed and we didn't update the navigation

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:https://github.com/Expensify/Expensify/issues/492183

Regression Test Proposal

Precondition:

Test:

1. Open any chat > Send a workspace join link
2. Press the link to open it
3. (Web/mWeb) Press the back browser button once (Android) Press the device back button twice

Verify you arrive at the chat back

NOTE: iOS can't go back using swipe

Do we agree 👍 or 👎

[bernhardoj]

Requested in ND.

[sonialiap]

@allgandalf thanks! Paid

[JmillsExpensify]

$250 approved for @bernhardoj