[Due for payment 2025-04-07] [$125] iOS - Expense - Add receipt modal on confirmation page is smaller and does not fit the screen

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.16-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Money Requests

Action Performed:

Precondition:

• This issue is reproduced on iPhone 15 Pro Max with the third smallest font size.

1. Launch ND or hybrid app.
2. Go to workspace chat.
3. Tap + > Create expense > Manual.
4. Enter amount > Next.

Expected Result:

Add receipt modal will fit the screen (production behavior).

Actual Result:

Add receipt modal is smaller and does not fit the screen.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6777794_1742544985139.ScreenRecording_03-21-2025_16-12-05_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021903056049376197283
• Upwork Job ID: 1903056049376197283
• Last Price Increase: 2025-03-21
• Automatic offers:
• mkzie2 | Contributor | 106618711

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[parasharrajat]

@mountiny Looks like #53849 this might be one. reverting to see.

[mountiny]

Interesting, that has been merged for a while, I checked and it looks fine on my phone, it seems to be specific to the font size so demoting

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021903056049376197283

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Upwork job price has been updated to $125

[parasharrajat]

I couldn't confirm. App is crashing on ios for me.

[parasharrajat]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Changing the system font-size make the receipt preview small.

What is the root cause of that problem?

1. We are using maxWidth styles on the receipt preview which will impact how it is rendered. On normal pixel size, the maxWidth aligns well but when reduced, it is not enough.

App/src/components/ReceiptEmptyState.tsx

Line 41 in 67ea2f7

styles.moneyRequestViewImage,

we can see this issue on the resized browser window as well.

What changes do you think we should make in order to solve the problem?

1. We should change this style and apply maxWidth conditionally where needed.

App/src/components/ReceiptEmptyState.tsx

Line 41 in 67ea2f7

styles.moneyRequestViewImage,

2. Looks like MoneyRequestView & ReceiptImage component needs maxWidth in some places. So to handle that we can create a style prop on ReceiptEmptyState to modify Wrapper style and pass maxWidth styles from such components.
   

   App/src/components/ReportActionItem/MoneyRequestView.tsx

   Line 548 in 67ea2f7

   <ReceiptEmptyState

3. Carefully inspect all places where ReceiptEmptyState is used and use maxWidth style where needed only.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None, Ui changes.

What alternative solutions did you explore? (Optional)

none

[FitseTLT]

Regression from #55803 They decreased maxWidth from 400 to 360 not sure if its intentional or not.

[mountiny]

@ishpaul777 seems like you have reviewed the offending PR, can you please take a look at the proposal? cc @mkzie2

[mkzie2]

@shawnborton Can you please confirm what is the expected here?

[ishpaul777]

I'll check this in 2 hours

[ishpaul777]

@mkzie2 i think the expected should be what we have in production version, since PR is in regression period, I think preference should be @mkzie2 to work on a fix.

@mountiny can you please assign them as well

[melvin-bot]

📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mkzie2]

Waiting the expected here before creating the PR.

[cristipaval]

Let's tag @Expensify/design, Shawn is ooo.

[dannymcclain]

They decreased maxWidth from 400 to 360 not sure if its intentional or not.

Definitely seems related to the new eReceipts. Personally I think we need this empty state to fill the whole width here, but we might have to fiddle with the eReceipts too to make all of this harmonious. This doesn't seem like a super urgent problem, so I'd love to wait until @shawnborton can weigh in before we make a decision on how to proceed (he should be back online later today/tomorrow).

[shawnborton]

Yeah I would say this is definitely a bug. We only wanted to change the receipt width when you are viewing the one-expense view from an expense that already exists. @mkzie2 can you follow up and fix this please? Basically in the confirmation screen for expense creation, it should go full width. But you can keep the other change you implemented to shorten the receipt thumbnail from the expense view.

[mkzie2]

@ishpaul777 The PR is ready.

[ishpaul777]

PR is on staging, we can close this once it hits prod, no one is due payment here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.20-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Add receipt modal on confirmation page is smaller and does not fit the screen #59046

If no regressions arise, payment will be issued on 2025-04-07. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment through NewDot Manual Requests
• @mkzie2 requires payment automatic offer (Contributor)

[melvin-bot]

@ishpaul777 @Christinadobrzyn @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]