[Due for payment 2025-04-10] [Better Expense Report View] Expense Reports - Submit and approve system message appear in report, but not pay message

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.16-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #58360
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Go to workspace chat.
4. Submit a manual expense to the workspace chat.
5. Go to Reports.
6. Go to Expense Reports.
7. Click on the expense report from Step 4.
8. Click Submit.
9. Click Approve.
10. Click Pay elsewhere.

Expected Result:

Submit, approve and pay system message should all appear or not appear in the report view.

Actual Result:

Only the submit and approve system message appear in the report view. Pay system message does not appear in the report view.

Cancel payment, export to CSV system message also appear in the report view.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[luacmartins]

This view is behind a beta. NAB. cc @Kicu

[melvin-bot]

@Kicu, @sakluger, @luacmartins, @mountiny, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mountiny]

Handled as a follow up by @Kicu

[Kicu]

@mountiny @luacmartins I think I will need a bit of help with this one. As far as I understand the "payment" message is rendered using IOU reportAction type. I had no idea that IOU can cover more than just start of transaction but it seems they do.

I've found this:

App/src/CONST.ts

Line 2675 in e2c3b27

REPORT_ACTION_TYPE: {

which are different types (subtypes?) of IOU actions.

Here are my questions

1. Does what I wrote make sense? which specific types (subtypes) of IOU actions should we filter and which should we keep in the chat messages list?
2. Seems that this logic needs changing: https://github.com/Expensify/App/blob/main/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx#L59 - its too simple

I wonder if this way of grabbing transactions and filtering out "non-chat" actions is a good approach 🤔 ?

[luacmartins]

which are different types (subtypes?) of IOU actions.

correct, these are "subtypes" of the IOU action. I think we'd want to keep all, except for create, split and track

I wonder if this way of grabbing transactions and filtering out "non-chat" actions is a good approach 🤔 ?

Not sure that I'd call it "non-chat, but yea, we'll have to filter out actions that shouldn't be visible (usually just the create ones)

[mountiny]

Agreed, the create would be the one to hide on an expense report. split is added to a group chat, I think, so there is no need to filter there. track I am not sure but also that sounds like something for selfDM

[Kicu]

Alright will start with filtering out create and track. It will be easy to modify the set of unwanted actions later 👍

[Kicu]

Ok can confirm that this issue will be fixed in: #58903

[trjExpensify]

I think we can close this then!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.22-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Improve MoneyRequestReportView #58903

If no regressions arise, payment will be issued on 2025-04-10. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

@DylanDylann @sakluger @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]