[Due for payment 2025-04-25] [$250] Compose box - Compose box is not focused after closing RHP

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.16-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Login to the app
2. Open any chat.
3. send a message
4. Right click on the message > Edit Comment
5. Click on ctrl J or shift + ctrl k to open the RHP
6. Close the RHP

Expected Result:

Compose box is focused after closing RHP

Actual Result:

Compose box is not focused after closing RHP

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6777204_1742494807695.Screen_Recording_2025-03-20_at_9.09.08_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904147802785580616
• Upwork Job ID: 1904147802785580616
• Last Price Increase: 2025-04-07
• Automatic offers:
• FitseTLT | Contributor | 106874043

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-20 19:52:39 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Compose box - Compose box is not focused after closing RHP

What is the root cause of that problem?

We already implemented the refocusing mechanism for edit message compose and the focus is called correctly here

App/src/libs/actions/InputFocus/index.website.ts

Line 22 in 21c19f1

refSave.focus();

but it is called way too quickly before the dismiss modal is finished so the focus fails
We already have faced similar problem here

App/src/libs/focusComposerWithDelay/index.ts

Lines 35 to 37 in 21c19f1

	// When the closing modal has a focused text input focus() needs a delay to properly work.
	// Setting 150ms here is a temporary workaround for the Android HybridApp. It should be reverted once we identify the real root cause of this issue: https://github.com/Expensify/App/issues/56311.
	setTimeout(() => textInput.focus(), delay);

What changes do you think we should make in order to solve the problem?

We should add any type of delay like runAfterInteraction for instance to focus after finishing the interaction

InteractionManager.runAfterInteractions(() => {
                refSave?.focus();
            });

we can also use setTimeout like we did here or any other delaying mechanism.
We can optionally add the same delay here too.
And we need to apply the same changes for index.desktop file too

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A - complex UI bug

What alternative solutions did you explore? (Optional)

[melvin-bot]

@greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021904147802785580616

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-d (External)

[melvin-bot]

@rayane-d Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rayane-d]

Will review this weekend

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[greg-schroeder]

Thanks @rayane-d! Are you able to take a look at the proposal we have?

[melvin-bot]

@greg-schroeder @rayane-d this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@rayane-d Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rayane-d]

Didn't get a chance to review yet

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[rayane-d]

@FitseTLT's proposal looks good to me

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - Compose box - Compose box is not focused after closing RHP #60073

If no regressions arise, payment will be issued on 2025-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @FitseTLT requires payment automatic offer (Contributor)
• @rayane-d requires payment through NewDot Manual Requests

[melvin-bot]

@rayane-d @greg-schroeder @rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[rayane-d]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/29073/files#r2055826434

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/494094

Regression Test Proposal

Precondition:

• N/A

Test:

1. This test is only for large screen web and desktop
2. Open any chat.
3. Send a message
4. Right-click on the message > Edit Comment
5. Click on Command + J or Shift + Command + K to open the RHP
6. Close the RHP
7. Verify the edit Compose box is focused after closing RHP

Do we agree 👍 or 👎

[greg-schroeder]

Payment summary:

Contributor: @FitseTLT - $250 - Paid via Upwork
C+: @rayane-d - $250 - Manual request via ND

[garrettmknight]

$250 approved for @rayane-d