Skip to content

[Due for payment 2025-04-02] Help Panel - Help panel is shown on top of the testing preferences dialog #58831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
nlemma opened this issue Mar 20, 2025 · 13 comments
Closed
2 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@nlemma
Copy link

nlemma commented Mar 20, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.16-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #58576
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Other

Action Performed:

Precondition:

  • Run Onyx.set('nvp_sidePanel', {}) in console.
  1. Go to staging.new.expensify.com
  2. Open Help Panel
  3. clicking on CMD(ctrl) + D

Expected Result:

Help panel is closed and the testing preferences dialog is shown

Actual Result:

Help panel is shown on top of the testing preferences dialog

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6777161_1742492541260.Screen_Recording_2025-03-20_at_8.35.36_in_the_evening.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @stephanieelliott
@nlemma nlemma added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Mar 20, 2025
Copy link

melvin-bot bot commented Mar 20, 2025

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 20, 2025

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Mar 20, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Mar 20, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 20, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@nlemma
Copy link
Author

nlemma commented Mar 20, 2025

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@brunovjk
Copy link
Contributor

This issue seems to me to be a regression of our PR. Please assign me as C+. Thanks.

@AndrewGable
Copy link
Contributor

I think this is under a beta still, so no need to block the deploy.

@AndrewGable AndrewGable assigned francoisl and unassigned AndrewGable Mar 20, 2025
@AndrewGable AndrewGable added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 20, 2025
@brunovjk
Copy link
Contributor

I think this is under a beta still, so no need to block the deploy.

Not yet, we are still working on this PR, it should be merged soon, when merged for sure regular users can not access

@blazejkustra
Copy link
Contributor

Fixed as part of this PR cc @brunovjk

@melvin-bot melvin-bot bot added the Overdue label Mar 24, 2025
@stephanieelliott
Copy link
Contributor

Fixing PR was is on staging

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Overdue Daily KSv2 labels Mar 25, 2025
@melvin-bot melvin-bot bot changed the title Help Panel - Help panel is shown on top of the testing preferences dialog [Due for payment 2025-04-02] Help Panel - Help panel is shown on top of the testing preferences dialog Mar 26, 2025
Copy link

melvin-bot bot commented Mar 26, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-02. 🎊

For reference, here are some details about the assignees on this issue:

  • @brunovjk requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Mar 26, 2025

@brunovjk @stephanieelliott @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@brunovjk
Copy link
Contributor

brunovjk commented Mar 27, 2025

I can't reproduce this anymore after implementing this PR. Tested on 27 Mar v9.1.20-2 Develop. We can close payment and BZ checklist will be handled here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants