Skip to content

Help Panel - Compose box is not focused after closing help panel. #58450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
jponikarchuk opened this issue Mar 14, 2025 · 16 comments
Closed
2 of 8 tasks

Help Panel - Compose box is not focused after closing help panel. #58450

jponikarchuk opened this issue Mar 14, 2025 · 16 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 Reviewing Has a PR in review

Comments

@jponikarchuk
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #58092
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Other

Action Performed:

  1. https://staging.new.expensify.com/
  2. Open the developer console and run the following snippet: Onyx.set('nvp_sidePanel', {})
  3. Go to any chat and click on the help button at the top
  4. Close the help panel

Expected Result:

Compose box is focused

Actual Result:

Composed box is not focused after closing the help panel.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6770388_1741933232761.Screen_Recording_2025-03-14_at_9.08.31_in_the_morning.mp4

View all open jobs on GitHub

@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 14, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@grgia
Copy link
Contributor

grgia commented Mar 14, 2025

Commented in slack

@289Adam289
Copy link
Contributor

289Adam289 commented Mar 14, 2025

I don't think this is a blocker. It is rather a minor issue and will be fixed with changes @blazejkustra is currently working on.

@blazejkustra
Copy link
Contributor

Commenting for assignment 👀

@grgia grgia removed the DeployBlockerCash This issue or pull request should block deployment label Mar 14, 2025
@grgia grgia added Daily KSv2 and removed Hourly KSv2 labels Mar 14, 2025
@grgia
Copy link
Contributor

grgia commented Mar 14, 2025

Thank you! Assigned

@brunovjk
Copy link
Contributor

I reviewed the PR that caused this regression. Please assign me here as a C+. Thanks!

@brunovjk
Copy link
Contributor

... will be fixed with changes @blazejkustra is currently working on.

Not overdue.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Mar 18, 2025
@blazejkustra
Copy link
Contributor

Update: PR is ready for review.

Copy link

melvin-bot bot commented Mar 20, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Mar 20, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@brunovjk
Copy link
Contributor

brunovjk commented Mar 27, 2025

I can't reproduce this anymore after implementing this PR. Tested on 27 Mar v9.1.20-2 Develop. We can close and payment and BZ checklist will be handled here. Thanks!

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Apr 21, 2025
Copy link

melvin-bot bot commented Apr 21, 2025

This issue has not been updated in over 15 days. @JmillsExpensify, @grgia, @blazejkustra, @brunovjk, @289Adam289 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mallenexpensify
Copy link
Contributor

No longer reproducible. Per @brunovjk here, we're closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants