Skip to content

[Due for payment 2025-03-31] Receipt - Unable to replace receipt and page stucks #58814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 8 tasks
lanitochka17 opened this issue Mar 20, 2025 · 18 comments
Closed
3 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 20, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.16-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app
  2. Tap fab - create a scan expense
  3. Open expense &Enter amount and merchant and save
  4. Tap receipt and select replace

Expected Result:

In scan expense, user must be able to replace receipt

Actual Result:

In scan expense, unable to replace receipt and page stucks. After tapping replace option, user navigated to expense details page and user cannot scroll the page. Page stucks

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6777062_1742487511707.Screenrecorder-2025-03-20-21-44-35-731.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @RachCHopkins
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 20, 2025
Copy link

melvin-bot bot commented Mar 20, 2025

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 20, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@arosiclair
Copy link
Contributor

I don't have 9.1.16-0 available in the Play Store even though I'm in the beta. So I can't reproduce in staging atm. I am able to reproduce in dev after checking out 9.1.16-1.

@arosiclair
Copy link
Contributor

Discussing this in slack. I tried reverting a couple PRs but it didn't fix it (won't link them here to avoid marking them as regressions).

@WojtekBoman
Copy link
Contributor

Hey, I'm working on that

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Mar 21, 2025
@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Mar 21, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 24, 2025
@melvin-bot melvin-bot bot changed the title Receipt - Unable to replace receipt and page stucks [Due for payment 2025-03-31] Receipt - Unable to replace receipt and page stucks Mar 24, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 24, 2025
Copy link

melvin-bot bot commented Mar 24, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 24, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.17-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-31. 🎊

For reference, here are some details about the assignees on this issue:

@arosiclair
Copy link
Contributor

@ZhenjaHorbach did the C+ PR for this

@arosiclair arosiclair added the Bug Something is broken. Auto assigns a BugZero manager. label Mar 24, 2025
Copy link

melvin-bot bot commented Mar 24, 2025

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Mar 24, 2025
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Mar 24, 2025
@arosiclair arosiclair added Weekly KSv2 and removed Daily KSv2 labels Mar 24, 2025
@RachCHopkins
Copy link
Contributor

@ZhenjaHorbach Can I get a checklist please?

@RachCHopkins
Copy link
Contributor

@ZhenjaHorbach I have also sent you an offer!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 31, 2025
Copy link

melvin-bot bot commented Mar 31, 2025

Payment Summary

Upwork Job

BugZero Checklist (@RachCHopkins)

  • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Mar 31, 2025

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    As far as I remember, we couldn't find a suitable PR that could cause the issue
    But this is possibly Remove reportID param from dismissModal function #58191 from my PR that I reviewed

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: NA

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Test:

  1. Launch app
  2. Tap fab - create a scan expense
  3. Open expense and enter amount and merchant and save
  4. Tap receipt and select replace
  5. Verify if the upload image page has been opened

Do we agree 👍 or 👎

@ZhenjaHorbach
Copy link
Contributor

@ZhenjaHorbach I have also sent you an offer!

And about payment
This is possibly a regression from my PR that I reviewed

@melvin-bot melvin-bot bot added the Overdue label Apr 2, 2025
@RachCHopkins
Copy link
Contributor

Uh oh, sorry @ZhenjaHorbach I did not realise that. @arosiclair are you able to confirm that for me please? i.e. that this is a regression and @ZhenjaHorbach is not due payment?

@melvin-bot melvin-bot bot removed the Overdue label Apr 2, 2025
@arosiclair
Copy link
Contributor

Ah I see what you mean. Yeah it seems this issue is cleanup after merging #58191. That'd mean there should be no payment.

@RachCHopkins
Copy link
Contributor

Ok, upwork contract (payment only) cancelled, and @ZhenjaHorbach rejected the offer (thank you), no one to pay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants